| Message ID | 1545256515-16945-1-git-send-email-Bryan.Whitehead@microchip.com |
|---|---|
| State | Accepted, archived |
| Delegated to: | David Miller |
| Headers | show |
| Series | [v1,net] lan743x: Remove MAC Reset from initialization | expand |
From: Bryan Whitehead <Bryan.Whitehead@microchip.com> Date: Wed, 19 Dec 2018 16:55:15 -0500 > The MAC Reset was noticed to erase important EEPROM settings. > It is also unnecessary since a chip wide reset was done earlier > in initialization, and that reset preserves EEPROM settings. > > There for this patch removes the unnecessary MAC specific reset. > > Signed-off-by: Bryan Whitehead <Bryan.Whitehead@microchip.com> Applied.
diff --git a/drivers/net/ethernet/microchip/lan743x_main.c b/drivers/net/ethernet/microchip/lan743x_main.c index 1ba8ea0..20c9377 100644 --- a/drivers/net/ethernet/microchip/lan743x_main.c +++ b/drivers/net/ethernet/microchip/lan743x_main.c @@ -802,14 +802,8 @@ static int lan743x_mac_init(struct lan743x_adapter *adapter) u32 mac_addr_hi = 0; u32 mac_addr_lo = 0; u32 data; - int ret; netdev = adapter->netdev; - lan743x_csr_write(adapter, MAC_CR, MAC_CR_RST_); - ret = lan743x_csr_wait_for_bit(adapter, MAC_CR, MAC_CR_RST_, - 0, 1000, 20000, 100); - if (ret) - return ret; /* setup auto duplex, and speed detection */ data = lan743x_csr_read(adapter, MAC_CR);
The MAC Reset was noticed to erase important EEPROM settings. It is also unnecessary since a chip wide reset was done earlier in initialization, and that reset preserves EEPROM settings. There for this patch removes the unnecessary MAC specific reset. Signed-off-by: Bryan Whitehead <Bryan.Whitehead@microchip.com> --- drivers/net/ethernet/microchip/lan743x_main.c | 6 ------ 1 file changed, 6 deletions(-)