diff mbox series

[U-Boot] bmips: swapping IO space isn't required

Message ID 20181209094127.14078-1-noltari@gmail.com
State Accepted, archived
Commit 4c0411eb4423fe864f437cf85dce4044d362fc27
Delegated to: Daniel Schwierzeck
Headers show
Series [U-Boot] bmips: swapping IO space isn't required | expand

Commit Message

Álvaro Fernández Rojas Dec. 9, 2018, 9:41 a.m. UTC 
Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com>
---
 arch/mips/mach-bmips/Kconfig | 10 ----------
 1 file changed, 10 deletions(-)

Comments

Daniel Schwierzeck Dec. 10, 2018, 2:50 p.m. UTC | #1 
Am 09.12.18 um 10:41 schrieb Álvaro Fernández Rojas:
> Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com>
> ---
>  arch/mips/mach-bmips/Kconfig | 10 ----------
>  1 file changed, 10 deletions(-)

Reviewed-by: Daniel Schwierzeck <daniel.schwierzeck@gmail.com>

I guess this is related to your recent series "serial: bcm6345: switch
to raw I/O functions"? As Tom already applied this series, this patch
should go in 2019.01 too?

> 
> diff --git a/arch/mips/mach-bmips/Kconfig b/arch/mips/mach-bmips/Kconfig
> index 521996599e..b259a931c9 100644
> --- a/arch/mips/mach-bmips/Kconfig
> +++ b/arch/mips/mach-bmips/Kconfig
> @@ -25,7 +25,6 @@ config SOC_BMIPS_BCM3380
>  	select MIPS_TUNE_4KC
>  	select SUPPORTS_BIG_ENDIAN
>  	select SUPPORTS_CPU_MIPS32_R1
> -	select SWAP_IO_SPACE
>  	select SYSRESET_WATCHDOG
>  	help
>  	  This supports BMIPS BCM3380 family.
> @@ -36,7 +35,6 @@ config SOC_BMIPS_BCM6318
>  	select MIPS_TUNE_4KC
>  	select SUPPORTS_BIG_ENDIAN
>  	select SUPPORTS_CPU_MIPS32_R1
> -	select SWAP_IO_SPACE
>  	select SYSRESET_SYSCON
>  	help
>  	  This supports BMIPS BCM6318 family.
> @@ -47,7 +45,6 @@ config SOC_BMIPS_BCM6328
>  	select MIPS_TUNE_4KC
>  	select SUPPORTS_BIG_ENDIAN
>  	select SUPPORTS_CPU_MIPS32_R1
> -	select SWAP_IO_SPACE
>  	select SYSRESET_SYSCON
>  	help
>  	  This supports BMIPS BCM6328 family including BCM63281 and BCM63283.
> @@ -58,7 +55,6 @@ config SOC_BMIPS_BCM6338
>  	select MIPS_TUNE_4KC
>  	select SUPPORTS_BIG_ENDIAN
>  	select SUPPORTS_CPU_MIPS32_R1
> -	select SWAP_IO_SPACE
>  	select SYSRESET_SYSCON
>  	help
>  	  This supports BMIPS BCM6338 family.
> @@ -69,7 +65,6 @@ config SOC_BMIPS_BCM6348
>  	select MIPS_TUNE_4KC
>  	select SUPPORTS_BIG_ENDIAN
>  	select SUPPORTS_CPU_MIPS32_R1
> -	select SWAP_IO_SPACE
>  	select SYSRESET_WATCHDOG
>  	help
>  	  This supports BMIPS BCM6348 family.
> @@ -80,7 +75,6 @@ config SOC_BMIPS_BCM6358
>  	select MIPS_TUNE_4KC
>  	select SUPPORTS_BIG_ENDIAN
>  	select SUPPORTS_CPU_MIPS32_R1
> -	select SWAP_IO_SPACE
>  	select SYSRESET_SYSCON
>  	help
>  	  This supports BMIPS BCM6358 family including BCM6358 and BCM6359.
> @@ -91,7 +85,6 @@ config SOC_BMIPS_BCM6368
>  	select MIPS_TUNE_4KC
>  	select SUPPORTS_BIG_ENDIAN
>  	select SUPPORTS_CPU_MIPS32_R1
> -	select SWAP_IO_SPACE
>  	select SYSRESET_SYSCON
>  	help
>  	  This supports BMIPS BCM6368 family including BCM6368 and BCM6369.
> @@ -102,7 +95,6 @@ config SOC_BMIPS_BCM6362
>  	select MIPS_TUNE_4KC
>  	select SUPPORTS_BIG_ENDIAN
>  	select SUPPORTS_CPU_MIPS32_R1
> -	select SWAP_IO_SPACE
>  	select SYSRESET_SYSCON
>  	help
>  	  This supports BMIPS BCM6362 family including BCM6361 and BCM6362.
> @@ -113,7 +105,6 @@ config SOC_BMIPS_BCM63268
>  	select MIPS_TUNE_4KC
>  	select SUPPORTS_BIG_ENDIAN
>  	select SUPPORTS_CPU_MIPS32_R1
> -	select SWAP_IO_SPACE
>  	select SYSRESET_SYSCON
>  	help
>  	  This supports BMIPS BCM63268 family including BCM63168, BCM63169,
> @@ -125,7 +116,6 @@ config SOC_BMIPS_BCM6838
>  	select MIPS_TUNE_4KC
>  	select SUPPORTS_BIG_ENDIAN
>  	select SUPPORTS_CPU_MIPS32_R1
> -	select SWAP_IO_SPACE
>  	select SYSRESET_SYSCON
>  	help
>  	  This supports BMIPS BCM6838 family including BCM68380, BCM68381,
>
Álvaro Fernández Rojas Dec. 10, 2018, 4:35 p.m. UTC | #2 
Hi Daniel,

El 10/12/2018 a las 15:50, Daniel Schwierzeck escribió:
> Am 09.12.18 um 10:41 schrieb Álvaro Fernández Rojas:
>> Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com>
>> ---
>>   arch/mips/mach-bmips/Kconfig | 10 ----------
>>   1 file changed, 10 deletions(-)
> Reviewed-by: Daniel Schwierzeck <daniel.schwierzeck@gmail.com>
>
> I guess this is related to your recent series "serial: bcm6345: switch
> to raw I/O functions"? As Tom already applied this series, this patch
> should go in 2019.01 too?

Yes, I completely forgot I had copied SWAP_IO_SPACE from linux target 
without really needing it.

Without this patch serial driver isn't working for bmips boards, so yeah 
this should go in 2019.01.

>
>> diff --git a/arch/mips/mach-bmips/Kconfig b/arch/mips/mach-bmips/Kconfig
>> index 521996599e..b259a931c9 100644
>> --- a/arch/mips/mach-bmips/Kconfig
>> +++ b/arch/mips/mach-bmips/Kconfig
>> @@ -25,7 +25,6 @@ config SOC_BMIPS_BCM3380
>>   	select MIPS_TUNE_4KC
>>   	select SUPPORTS_BIG_ENDIAN
>>   	select SUPPORTS_CPU_MIPS32_R1
>> -	select SWAP_IO_SPACE
>>   	select SYSRESET_WATCHDOG
>>   	help
>>   	  This supports BMIPS BCM3380 family.
>> @@ -36,7 +35,6 @@ config SOC_BMIPS_BCM6318
>>   	select MIPS_TUNE_4KC
>>   	select SUPPORTS_BIG_ENDIAN
>>   	select SUPPORTS_CPU_MIPS32_R1
>> -	select SWAP_IO_SPACE
>>   	select SYSRESET_SYSCON
>>   	help
>>   	  This supports BMIPS BCM6318 family.
>> @@ -47,7 +45,6 @@ config SOC_BMIPS_BCM6328
>>   	select MIPS_TUNE_4KC
>>   	select SUPPORTS_BIG_ENDIAN
>>   	select SUPPORTS_CPU_MIPS32_R1
>> -	select SWAP_IO_SPACE
>>   	select SYSRESET_SYSCON
>>   	help
>>   	  This supports BMIPS BCM6328 family including BCM63281 and BCM63283.
>> @@ -58,7 +55,6 @@ config SOC_BMIPS_BCM6338
>>   	select MIPS_TUNE_4KC
>>   	select SUPPORTS_BIG_ENDIAN
>>   	select SUPPORTS_CPU_MIPS32_R1
>> -	select SWAP_IO_SPACE
>>   	select SYSRESET_SYSCON
>>   	help
>>   	  This supports BMIPS BCM6338 family.
>> @@ -69,7 +65,6 @@ config SOC_BMIPS_BCM6348
>>   	select MIPS_TUNE_4KC
>>   	select SUPPORTS_BIG_ENDIAN
>>   	select SUPPORTS_CPU_MIPS32_R1
>> -	select SWAP_IO_SPACE
>>   	select SYSRESET_WATCHDOG
>>   	help
>>   	  This supports BMIPS BCM6348 family.
>> @@ -80,7 +75,6 @@ config SOC_BMIPS_BCM6358
>>   	select MIPS_TUNE_4KC
>>   	select SUPPORTS_BIG_ENDIAN
>>   	select SUPPORTS_CPU_MIPS32_R1
>> -	select SWAP_IO_SPACE
>>   	select SYSRESET_SYSCON
>>   	help
>>   	  This supports BMIPS BCM6358 family including BCM6358 and BCM6359.
>> @@ -91,7 +85,6 @@ config SOC_BMIPS_BCM6368
>>   	select MIPS_TUNE_4KC
>>   	select SUPPORTS_BIG_ENDIAN
>>   	select SUPPORTS_CPU_MIPS32_R1
>> -	select SWAP_IO_SPACE
>>   	select SYSRESET_SYSCON
>>   	help
>>   	  This supports BMIPS BCM6368 family including BCM6368 and BCM6369.
>> @@ -102,7 +95,6 @@ config SOC_BMIPS_BCM6362
>>   	select MIPS_TUNE_4KC
>>   	select SUPPORTS_BIG_ENDIAN
>>   	select SUPPORTS_CPU_MIPS32_R1
>> -	select SWAP_IO_SPACE
>>   	select SYSRESET_SYSCON
>>   	help
>>   	  This supports BMIPS BCM6362 family including BCM6361 and BCM6362.
>> @@ -113,7 +105,6 @@ config SOC_BMIPS_BCM63268
>>   	select MIPS_TUNE_4KC
>>   	select SUPPORTS_BIG_ENDIAN
>>   	select SUPPORTS_CPU_MIPS32_R1
>> -	select SWAP_IO_SPACE
>>   	select SYSRESET_SYSCON
>>   	help
>>   	  This supports BMIPS BCM63268 family including BCM63168, BCM63169,
>> @@ -125,7 +116,6 @@ config SOC_BMIPS_BCM6838
>>   	select MIPS_TUNE_4KC
>>   	select SUPPORTS_BIG_ENDIAN
>>   	select SUPPORTS_CPU_MIPS32_R1
>> -	select SWAP_IO_SPACE
>>   	select SYSRESET_SYSCON
>>   	help
>>   	  This supports BMIPS BCM6838 family including BCM68380, BCM68381,
>>
Daniel Schwierzeck Dec. 10, 2018, 6:03 p.m. UTC | #3 
Am 09.12.18 um 10:41 schrieb Álvaro Fernández Rojas:
> Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com>
> ---
>  arch/mips/mach-bmips/Kconfig | 10 ----------
>  1 file changed, 10 deletions(-)
> 

applied to u-boot-mips/fixes, thanks.
diff mbox series

Patch

diff --git a/arch/mips/mach-bmips/Kconfig b/arch/mips/mach-bmips/Kconfig
index 521996599e..b259a931c9 100644
--- a/arch/mips/mach-bmips/Kconfig
+++ b/arch/mips/mach-bmips/Kconfig
@@ -25,7 +25,6 @@  config SOC_BMIPS_BCM3380
 	select MIPS_TUNE_4KC
 	select SUPPORTS_BIG_ENDIAN
 	select SUPPORTS_CPU_MIPS32_R1
-	select SWAP_IO_SPACE
 	select SYSRESET_WATCHDOG
 	help
 	  This supports BMIPS BCM3380 family.
@@ -36,7 +35,6 @@  config SOC_BMIPS_BCM6318
 	select MIPS_TUNE_4KC
 	select SUPPORTS_BIG_ENDIAN
 	select SUPPORTS_CPU_MIPS32_R1
-	select SWAP_IO_SPACE
 	select SYSRESET_SYSCON
 	help
 	  This supports BMIPS BCM6318 family.
@@ -47,7 +45,6 @@  config SOC_BMIPS_BCM6328
 	select MIPS_TUNE_4KC
 	select SUPPORTS_BIG_ENDIAN
 	select SUPPORTS_CPU_MIPS32_R1
-	select SWAP_IO_SPACE
 	select SYSRESET_SYSCON
 	help
 	  This supports BMIPS BCM6328 family including BCM63281 and BCM63283.
@@ -58,7 +55,6 @@  config SOC_BMIPS_BCM6338
 	select MIPS_TUNE_4KC
 	select SUPPORTS_BIG_ENDIAN
 	select SUPPORTS_CPU_MIPS32_R1
-	select SWAP_IO_SPACE
 	select SYSRESET_SYSCON
 	help
 	  This supports BMIPS BCM6338 family.
@@ -69,7 +65,6 @@  config SOC_BMIPS_BCM6348
 	select MIPS_TUNE_4KC
 	select SUPPORTS_BIG_ENDIAN
 	select SUPPORTS_CPU_MIPS32_R1
-	select SWAP_IO_SPACE
 	select SYSRESET_WATCHDOG
 	help
 	  This supports BMIPS BCM6348 family.
@@ -80,7 +75,6 @@  config SOC_BMIPS_BCM6358
 	select MIPS_TUNE_4KC
 	select SUPPORTS_BIG_ENDIAN
 	select SUPPORTS_CPU_MIPS32_R1
-	select SWAP_IO_SPACE
 	select SYSRESET_SYSCON
 	help
 	  This supports BMIPS BCM6358 family including BCM6358 and BCM6359.
@@ -91,7 +85,6 @@  config SOC_BMIPS_BCM6368
 	select MIPS_TUNE_4KC
 	select SUPPORTS_BIG_ENDIAN
 	select SUPPORTS_CPU_MIPS32_R1
-	select SWAP_IO_SPACE
 	select SYSRESET_SYSCON
 	help
 	  This supports BMIPS BCM6368 family including BCM6368 and BCM6369.
@@ -102,7 +95,6 @@  config SOC_BMIPS_BCM6362
 	select MIPS_TUNE_4KC
 	select SUPPORTS_BIG_ENDIAN
 	select SUPPORTS_CPU_MIPS32_R1
-	select SWAP_IO_SPACE
 	select SYSRESET_SYSCON
 	help
 	  This supports BMIPS BCM6362 family including BCM6361 and BCM6362.
@@ -113,7 +105,6 @@  config SOC_BMIPS_BCM63268
 	select MIPS_TUNE_4KC
 	select SUPPORTS_BIG_ENDIAN
 	select SUPPORTS_CPU_MIPS32_R1
-	select SWAP_IO_SPACE
 	select SYSRESET_SYSCON
 	help
 	  This supports BMIPS BCM63268 family including BCM63168, BCM63169,
@@ -125,7 +116,6 @@  config SOC_BMIPS_BCM6838
 	select MIPS_TUNE_4KC
 	select SUPPORTS_BIG_ENDIAN
 	select SUPPORTS_CPU_MIPS32_R1
-	select SWAP_IO_SPACE
 	select SYSRESET_SYSCON
 	help
 	  This supports BMIPS BCM6838 family including BCM68380, BCM68381,