| Message ID | 20181210094358.3241-3-markz@nvidia.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | NVIDIA Shield TV device tree patch set | expand |
On 10/12/2018 09:43, Mark Zhang wrote: > Add the device tree binding documentation for NVIDIA Shield TV. > > Signed-off-by: Mark Zhang <markz@nvidia.com> > --- > Documentation/devicetree/bindings/arm/tegra.txt | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/Documentation/devicetree/bindings/arm/tegra.txt b/Documentation/devicetree/bindings/arm/tegra.txt > index c59b15f64346..8f1c070b7cce 100644 > --- a/Documentation/devicetree/bindings/arm/tegra.txt > +++ b/Documentation/devicetree/bindings/arm/tegra.txt > @@ -33,6 +33,8 @@ board-specific compatible values: > nvidia,cardhu-a02 > nvidia,cardhu-a04 > nvidia,dalmore > + nvidia,darcy > + nvidia,foster-e > nvidia,harmony > nvidia,jetson-tk1 > nvidia,norrin Do we describe anywhere the differences between darcy and foster-e? Why do we need both? Cheers Jon
On Mon, Dec 10, 2018 at 05:43:55PM +0800, Mark Zhang wrote: > Add the device tree binding documentation for NVIDIA Shield TV. > > Signed-off-by: Mark Zhang <markz@nvidia.com> > --- > Documentation/devicetree/bindings/arm/tegra.txt | 2 ++ > 1 file changed, 2 insertions(+) Note that there's a patch to convert this file to the new DT schema format using json-schema. That's likely going to land in v4.21, and since we're past the v4.21 deadline for ARM SoC code, this one will have to be rebased eventually. Just a heads-up, nothing to worry about right now. Thierry
On Mon, Dec 10, 2018 at 09:50:50AM +0000, Jon Hunter wrote: > > On 10/12/2018 09:43, Mark Zhang wrote: > > Add the device tree binding documentation for NVIDIA Shield TV. > > > > Signed-off-by: Mark Zhang <markz@nvidia.com> > > --- > > Documentation/devicetree/bindings/arm/tegra.txt | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/arm/tegra.txt b/Documentation/devicetree/bindings/arm/tegra.txt > > index c59b15f64346..8f1c070b7cce 100644 > > --- a/Documentation/devicetree/bindings/arm/tegra.txt > > +++ b/Documentation/devicetree/bindings/arm/tegra.txt > > @@ -33,6 +33,8 @@ board-specific compatible values: > > nvidia,cardhu-a02 > > nvidia,cardhu-a04 > > nvidia,dalmore > > + nvidia,darcy > > + nvidia,foster-e > > nvidia,harmony > > nvidia,jetson-tk1 > > nvidia,norrin > > Do we describe anywhere the differences between darcy and foster-e? Why > do we need both? Agreed, it'd be good to eventually have some documentation about the boards that are being specified here. As I mentioned in another subthread, Rob is currently working on converting this file to be DT schema, at which point it should become easier to add descriptions for the boards. Thierry
On Mon, Dec 10, 2018 at 11:00:34AM +0100, Thierry Reding wrote: > On Mon, Dec 10, 2018 at 05:43:55PM +0800, Mark Zhang wrote: > > Add the device tree binding documentation for NVIDIA Shield TV. > > > > Signed-off-by: Mark Zhang <markz@nvidia.com> > > --- > > Documentation/devicetree/bindings/arm/tegra.txt | 2 ++ > > 1 file changed, 2 insertions(+) > > Note that there's a patch to convert this file to the new DT schema > format using json-schema. That's likely going to land in v4.21, and > since we're past the v4.21 deadline for ARM SoC code, this one will > have to be rebased eventually. > > Just a heads-up, nothing to worry about right now. Here's a link to the patch, in case you're interested: http://patchwork.ozlabs.org/patch/1007248/ Thierry
On 12/10/2018 6:01 PM, Thierry Reding wrote: > On Mon, Dec 10, 2018 at 09:50:50AM +0000, Jon Hunter wrote: >> >> On 10/12/2018 09:43, Mark Zhang wrote: >>> Add the device tree binding documentation for NVIDIA Shield TV. >>> >>> Signed-off-by: Mark Zhang <markz@nvidia.com> >>> --- >>> Documentation/devicetree/bindings/arm/tegra.txt | 2 ++ >>> 1 file changed, 2 insertions(+) >>> >>> diff --git a/Documentation/devicetree/bindings/arm/tegra.txt b/Documentation/devicetree/bindings/arm/tegra.txt >>> index c59b15f64346..8f1c070b7cce 100644 >>> --- a/Documentation/devicetree/bindings/arm/tegra.txt >>> +++ b/Documentation/devicetree/bindings/arm/tegra.txt >>> @@ -33,6 +33,8 @@ board-specific compatible values: >>> nvidia,cardhu-a02 >>> nvidia,cardhu-a04 >>> nvidia,dalmore >>> + nvidia,darcy >>> + nvidia,foster-e >>> nvidia,harmony >>> nvidia,jetson-tk1 >>> nvidia,norrin >> >> Do we describe anywhere the differences between darcy and foster-e? Why >> do we need both? > > Agreed, it'd be good to eventually have some documentation about the > boards that are being specified here. As I mentioned in another > subthread, Rob is currently working on converting this file to be DT > schema, at which point it should become easier to add descriptions for > the boards. > Indeed. Let me remove foster-e in next version, thanks. Mark > Thierry >
diff --git a/Documentation/devicetree/bindings/arm/tegra.txt b/Documentation/devicetree/bindings/arm/tegra.txt index c59b15f64346..8f1c070b7cce 100644 --- a/Documentation/devicetree/bindings/arm/tegra.txt +++ b/Documentation/devicetree/bindings/arm/tegra.txt @@ -33,6 +33,8 @@ board-specific compatible values: nvidia,cardhu-a02 nvidia,cardhu-a04 nvidia,dalmore + nvidia,darcy + nvidia,foster-e nvidia,harmony nvidia,jetson-tk1 nvidia,norrin
Add the device tree binding documentation for NVIDIA Shield TV. Signed-off-by: Mark Zhang <markz@nvidia.com> --- Documentation/devicetree/bindings/arm/tegra.txt | 2 ++ 1 file changed, 2 insertions(+)