Message ID | 20181206184522.118062-2-evgreen@chromium.org |
---|---|
State | Not Applicable, archived |
Headers | show |
Series | arm64: dts: qcom: sdm845: Add SD nodes | expand |
Context | Check | Description |
---|---|---|
robh/checkpatch | success |
Hi, On Thu, Dec 6, 2018 at 10:45 AM Evan Green <evgreen@chromium.org> wrote: > > In sdhci-msm-v5 and beyond, the MCI registers are removed, so there is only > one register region required. > > Signed-off-by: Evan Green <evgreen@chromium.org> > --- > > Changes in v2: None > > Documentation/devicetree/bindings/mmc/sdhci-msm.txt | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) You probably should have skipped this patch from v2. Ulf already landed it. It can be found at: https://git.kernel.org/pub/scm/linux/kernel/git/ulfh/mmc.git/commit/?h=next&id=68fe87ac8a9309bbdc960cbd774725e44ea98b58 -Doug
On Thu, Dec 6, 2018 at 3:34 PM Doug Anderson <dianders@chromium.org> wrote: > > Hi, > On Thu, Dec 6, 2018 at 10:45 AM Evan Green <evgreen@chromium.org> wrote: > > > > In sdhci-msm-v5 and beyond, the MCI registers are removed, so there is only > > one register region required. > > > > Signed-off-by: Evan Green <evgreen@chromium.org> > > --- > > > > Changes in v2: None > > > > Documentation/devicetree/bindings/mmc/sdhci-msm.txt | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > You probably should have skipped this patch from v2. Ulf already > landed it. It can be found at: > > https://git.kernel.org/pub/scm/linux/kernel/git/ulfh/mmc.git/commit/?h=next&id=68fe87ac8a9309bbdc960cbd774725e44ea98b58 > Oh, oops. Ignore this 1/3 patch then, but the other two are valid. -Evan
diff --git a/Documentation/devicetree/bindings/mmc/sdhci-msm.txt b/Documentation/devicetree/bindings/mmc/sdhci-msm.txt index b72871ac90cb2..da4edb146a983 100644 --- a/Documentation/devicetree/bindings/mmc/sdhci-msm.txt +++ b/Documentation/devicetree/bindings/mmc/sdhci-msm.txt @@ -25,7 +25,7 @@ Required properties: - reg: Base address and length of the register in the following order: - Host controller register map (required) - - SD Core register map (required) + - SD Core register map (required for msm-v4 and below) - interrupts: Should contain an interrupt-specifiers for the interrupts: - Host controller interrupt (required) - pinctrl-names: Should contain only one value - "default".
In sdhci-msm-v5 and beyond, the MCI registers are removed, so there is only one register region required. Signed-off-by: Evan Green <evgreen@chromium.org> --- Changes in v2: None Documentation/devicetree/bindings/mmc/sdhci-msm.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)