Message ID | 20181206180824.1761-2-gabriel@inconstante.eti.br |
---|---|
State | New |
Headers | show |
Series | Add missing nldbl functions to libc | expand |
On Thu, 6 Dec 2018, Gabriel F. T. Gomes wrote: > Since the commit > > commit 698fb75b9ff5ae454a1344b5f9fafa0ca367c555 > Author: Zack Weinberg <zackw@panix.com> > Date: Wed Mar 7 14:32:01 2018 -0500 > > Add __v*printf_internal with flags arguments > > _IO_vfprintf is gone. This did not trigger any test case failures on I see that libio/iolibio.h has a call to _IO_vfprintf in a definition of _IO_vprintf as a macro. I suppose that's just left over from a previous patch? Other than that, yes, _IO_vfprintf seems gone apart from the aliases for ABI compatibility, so this patch is OK.
On Thu, Dec 6, 2018 at 3:34 PM Joseph Myers <joseph@codesourcery.com> wrote: > On Thu, 6 Dec 2018, Gabriel F. T. Gomes wrote: > > > > _IO_vfprintf is gone. This did not trigger any test case failures on > > I see that libio/iolibio.h has a call to _IO_vfprintf in a definition of > _IO_vprintf as a macro. I suppose that's just left over from a previous > patch? When I did the patches to stop installing libio.h, I noticed there were a whole bunch of stale definitions and prototypes in iolibio.h, but I decided it wasn't worth cleaning them up in that patch series, since iolibio.h has never (AFAICT) been installed. "Minimize the use of _IO_ interfaces throughout glibc" would be a good patch series for someone [who has more time than I do right now ;-)] to tackle, and maybe we would discover that iolibio.h was completely redundant at the end of it. zw
On Thu, 06 Dec 2018, Joseph Myers wrote: >I see that libio/iolibio.h has a call to _IO_vfprintf in a definition of >_IO_vprintf as a macro. I suppose that's just left over from a previous >patch? Other than that, yes, _IO_vfprintf seems gone apart from the >aliases for ABI compatibility, so this patch is OK. Thanks, now committed.
diff --git a/libio/libio.h b/libio/libio.h index 3a93807efc..e19d860dc6 100644 --- a/libio/libio.h +++ b/libio/libio.h @@ -300,7 +300,6 @@ extern void _IO_free_wbackup_area (FILE *) __THROW; #ifdef __LDBL_COMPAT __LDBL_REDIR_DECL (_IO_vfscanf) -__LDBL_REDIR_DECL (_IO_vfprintf) #endif libc_hidden_proto (__overflow)