| Message ID | 20181127222045.18491-1-khilman@baylibre.com |
|---|---|
| State | New |
| Headers | show |
| Series | ARC: change defconfig defaults to ARCv2 | expand |
On 11/27/18 2:21 PM, Kevin Hilman wrote: > Change the default defconfig (used with 'make defconfig') to the ARCv2 > nsim_hs_defconfig, and also switch the default Kconfig ISA selection to > ARCv2. > > This allows several default defconfigs (e.g. make defconfig, make > allnoconfig, make tinyconfig) to all work with ARCv2 by default. > > Signed-off-by: Kevin Hilman <khilman@baylibre.com> Applied to for-curr Thx, -Vineet
Hi Vineet, Vineet Gupta <vineet.gupta1@synopsys.com> writes: > On 11/27/18 2:21 PM, Kevin Hilman wrote: >> Change the default defconfig (used with 'make defconfig') to the ARCv2 >> nsim_hs_defconfig, and also switch the default Kconfig ISA selection to >> ARCv2. >> >> This allows several default defconfigs (e.g. make defconfig, make >> allnoconfig, make tinyconfig) to all work with ARCv2 by default. >> >> Signed-off-by: Kevin Hilman <khilman@baylibre.com> > > Applied to for-curr If it's not too late, could you tag this for stable? Even though this is not technicall a regression, Greg said (in a different thread) he'd be willing to accept this for stable if it fixes the builders like kernelCI. Thanks, Kevin
On 11/29/18 11:18 AM, Kevin Hilman wrote: > Hi Vineet, > > Vineet Gupta <vineet.gupta1@synopsys.com> writes: > >> On 11/27/18 2:21 PM, Kevin Hilman wrote: >>> Change the default defconfig (used with 'make defconfig') to the ARCv2 >>> nsim_hs_defconfig, and also switch the default Kconfig ISA selection to >>> ARCv2. >>> >>> This allows several default defconfigs (e.g. make defconfig, make >>> allnoconfig, make tinyconfig) to all work with ARCv2 by default. >>> >>> Signed-off-by: Kevin Hilman <khilman@baylibre.com> >> Applied to for-curr > If it's not too late, could you tag this for stable? > > Even though this is not technicall a regression, Greg said (in a > different thread) he'd be willing to accept this for stable if it fixes > the builders like kernelCI. Sure thing. But this change actually causes regression in our in-house testing for the arc700 defconfigs which falter due to missing CONFIG_ISA_ARCOMPACT which was the default before. Alexey found this and will post a fixup whcih I plan to squash into ur patch to keep bisectability (and allow trivial stable backports) and then regen the relevant defconfigs. -Vineet
diff --git a/arch/arc/Kconfig b/arch/arc/Kconfig index c9e2a1323536..a65ca0955d8b 100644 --- a/arch/arc/Kconfig +++ b/arch/arc/Kconfig @@ -109,7 +109,7 @@ endmenu choice prompt "ARC Instruction Set" - default ISA_ARCOMPACT + default ISA_ARCV2 config ISA_ARCOMPACT bool "ARCompact ISA" diff --git a/arch/arc/Makefile b/arch/arc/Makefile index c64c505d966c..df00578c279d 100644 --- a/arch/arc/Makefile +++ b/arch/arc/Makefile @@ -6,7 +6,7 @@ # published by the Free Software Foundation. # -KBUILD_DEFCONFIG := nsim_700_defconfig +KBUILD_DEFCONFIG := nsim_hs_defconfig cflags-y += -fno-common -pipe -fno-builtin -mmedium-calls -D__linux__ cflags-$(CONFIG_ISA_ARCOMPACT) += -mA7
Change the default defconfig (used with 'make defconfig') to the ARCv2 nsim_hs_defconfig, and also switch the default Kconfig ISA selection to ARCv2. This allows several default defconfigs (e.g. make defconfig, make allnoconfig, make tinyconfig) to all work with ARCv2 by default. Signed-off-by: Kevin Hilman <khilman@baylibre.com> --- Applies on v4.20-rc4 arch/arc/Kconfig | 2 +- arch/arc/Makefile | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)