diff mbox series

Don't warn on "long" OPAL_RESYNC_TIMEBASE calls

Message ID 20181127211630.22259-1-stewart@linux.ibm.com
State Accepted
Headers show
Series Don't warn on "long" OPAL_RESYNC_TIMEBASE calls | expand

Checks

Context Check Description
snowpatch_ozlabs/apply_patch success master/apply_patch Successfully applied
snowpatch_ozlabs/snowpatch_job_snowpatch-skiboot success Test snowpatch/job/snowpatch-skiboot on branch master

Commit Message

Stewart Smith Nov. 27, 2018, 9:16 p.m. UTC
On P8 this is called when we exit fastsleep, and we shouldn't measure
the "time" spent in the call for what (in retrospect) is an obvious
reason.

Fixes: 50ea35c2d07874755c03e6ae2bdf7a33ad2c768a
Signed-off-by: Stewart Smith <stewart@linux.ibm.com>
---
 core/opal.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Stewart Smith Nov. 29, 2018, 2:16 a.m. UTC | #1
Stewart Smith <stewart@linux.ibm.com> writes:
> On P8 this is called when we exit fastsleep, and we shouldn't measure
> the "time" spent in the call for what (in retrospect) is an obvious
> reason.
>
> Fixes: 50ea35c2d07874755c03e6ae2bdf7a33ad2c768a
> Signed-off-by: Stewart Smith <stewart@linux.ibm.com>
> ---
>  core/opal.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Merged to master as of 37bce07eea2b317871810d186c75b3b9d73e71d9
diff mbox series

Patch

diff --git a/core/opal.c b/core/opal.c
index 2834b38e02b0..3a8ea30b79f0 100644
--- a/core/opal.c
+++ b/core/opal.c
@@ -197,7 +197,7 @@  int64_t opal_exit_check(int64_t retval, struct stack_frame *eframe)
 		}
 	}
 
-	if (call_time > 100) {
+	if (call_time > 100 && token != OPAL_RESYNC_TIMEBASE) {
 		prlog((call_time < 1000) ? PR_DEBUG : PR_WARNING,
 		      "Spent %llu msecs in OPAL call %llu!\n",
 		      call_time, token);