| Message ID | alpine.LNX.2.00.1103092250510.4471@swampdragon.chaosbits.net |
|---|---|
| State | Not Applicable, archived |
| Delegated to: | David Miller |
| Headers | show |
On Wed, Mar 09, 2011 at 10:55:05PM +0100, Jesper Juhl wrote: > There's no sense to 'ct = ct = ' in ip_vs_notrack(). Just assign > nf_ct_get()'s return value directly to the pointer variable 'ct' once. Thanks Jesper, applied to lvs-test-2.6. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/include/net/ip_vs.h b/include/net/ip_vs.h index b7bbd6c..269d1ef 100644 --- a/include/net/ip_vs.h +++ b/include/net/ip_vs.h @@ -1031,7 +1031,7 @@ static inline void ip_vs_notrack(struct sk_buff *skb) { #if defined(CONFIG_NF_CONNTRACK) || defined(CONFIG_NF_CONNTRACK_MODULE) enum ip_conntrack_info ctinfo; - struct nf_conn *ct = ct = nf_ct_get(skb, &ctinfo); + struct nf_conn *ct = nf_ct_get(skb, &ctinfo); if (!ct || !nf_ct_is_untracked(ct)) { nf_reset(skb);
There's no sense to 'ct = ct = ' in ip_vs_notrack(). Just assign nf_ct_get()'s return value directly to the pointer variable 'ct' once. Signed-off-by: Jesper Juhl <jj@chaosbits.net> --- ip_vs.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)