| Message ID | 20181109150710.31085-4-crosa@redhat.com |
|---|---|
| State | New |
| Headers | show |
| Series | Record Python version and misc test/CI fixes | expand |
Cleber Rosa <crosa@redhat.com> writes: > For the two Python jobs, which seem to have the goal of making sure > QEMU builds successfully on the 3.0-3.6 spectrum of Python 3 versions, > the specified version is only applicable if a Python virtual > environment is used. To do that, it's necessary to define the > (primary?) language of the job to be Python. > > Also, Travis doesn't have a 3.0 Python installation available for the > chosen distro, 3.2 being the lower version available. > > Reference: https://docs.travis-ci.com/user/languages/python/#specifying-python-versions > Signed-off-by: Cleber Rosa <crosa@redhat.com> Reviewed-by: Alex Bennée <alex.bennee@linaro.org> Do you want me to take this via my tree or keep it with the other patches? > --- > .travis.yml | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/.travis.yml b/.travis.yml > index aa49c7b114..5c18d3e268 100644 > --- a/.travis.yml > +++ b/.travis.yml > @@ -112,9 +112,11 @@ matrix: > compiler: clang > # Python builds > - env: CONFIG="--target-list=x86_64-softmmu" > + language: python > python: > - - "3.0" > + - "3.2" > - env: CONFIG="--target-list=x86_64-softmmu" > + language: python > python: > - "3.6" > # Acceptance (Functional) tests -- Alex Bennée
On 9/11/18 16:07, Cleber Rosa wrote: > For the two Python jobs, which seem to have the goal of making sure > QEMU builds successfully on the 3.0-3.6 spectrum of Python 3 versions, > the specified version is only applicable if a Python virtual > environment is used. To do that, it's necessary to define the > (primary?) language of the job to be Python. > > Also, Travis doesn't have a 3.0 Python installation available for the > chosen distro, 3.2 being the lower version available. > > Reference: https://docs.travis-ci.com/user/languages/python/#specifying-python-versions On this link the lower version available is 3.3, isnt' it? > Signed-off-by: Cleber Rosa <crosa@redhat.com> > --- > .travis.yml | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/.travis.yml b/.travis.yml > index aa49c7b114..5c18d3e268 100644 > --- a/.travis.yml > +++ b/.travis.yml > @@ -112,9 +112,11 @@ matrix: > compiler: clang > # Python builds > - env: CONFIG="--target-list=x86_64-softmmu" > + language: python > python: > - - "3.0" > + - "3.2" > - env: CONFIG="--target-list=x86_64-softmmu" > + language: python > python: > - "3.6" > # Acceptance (Functional) tests >
On 11/9/18 2:34 PM, Philippe Mathieu-Daudé wrote: > On 9/11/18 16:07, Cleber Rosa wrote: >> For the two Python jobs, which seem to have the goal of making sure >> QEMU builds successfully on the 3.0-3.6 spectrum of Python 3 versions, >> the specified version is only applicable if a Python virtual >> environment is used. To do that, it's necessary to define the >> (primary?) language of the job to be Python. >> >> Also, Travis doesn't have a 3.0 Python installation available for the >> chosen distro, 3.2 being the lower version available. >> >> Reference: >> https://docs.travis-ci.com/user/languages/python/#specifying-python-versions >> > > On this link the lower version available is 3.3, isnt' it? I found out that this list is not comprehensive. It looks like it's just an example. - Cleber. > >> Signed-off-by: Cleber Rosa <crosa@redhat.com> >> --- >> .travis.yml | 4 +++- >> 1 file changed, 3 insertions(+), 1 deletion(-) >> >> diff --git a/.travis.yml b/.travis.yml >> index aa49c7b114..5c18d3e268 100644 >> --- a/.travis.yml >> +++ b/.travis.yml >> @@ -112,9 +112,11 @@ matrix: >> compiler: clang >> # Python builds >> - env: CONFIG="--target-list=x86_64-softmmu" >> + language: python >> python: >> - - "3.0" >> + - "3.2" >> - env: CONFIG="--target-list=x86_64-softmmu" >> + language: python >> python: >> - "3.6" >> # Acceptance (Functional) tests >>
On Fri, Nov 09, 2018 at 10:07:09AM -0500, Cleber Rosa wrote: > For the two Python jobs, which seem to have the goal of making sure > QEMU builds successfully on the 3.0-3.6 spectrum of Python 3 versions, > the specified version is only applicable if a Python virtual > environment is used. To do that, it's necessary to define the > (primary?) language of the job to be Python. > > Also, Travis doesn't have a 3.0 Python installation available for the > chosen distro, 3.2 being the lower version available. > > Reference: https://docs.travis-ci.com/user/languages/python/#specifying-python-versions > Signed-off-by: Cleber Rosa <crosa@redhat.com> This doesn't depend on patches 1 and 2, right? The rest of the series will wait for the next release, but this looks like something we want to merge before QEMU 3.1.
On Fri, Nov 09, 2018 at 03:52:49PM +0000, Alex Bennée wrote: > > Cleber Rosa <crosa@redhat.com> writes: > > > For the two Python jobs, which seem to have the goal of making sure > > QEMU builds successfully on the 3.0-3.6 spectrum of Python 3 versions, > > the specified version is only applicable if a Python virtual > > environment is used. To do that, it's necessary to define the > > (primary?) language of the job to be Python. > > > > Also, Travis doesn't have a 3.0 Python installation available for the > > chosen distro, 3.2 being the lower version available. > > > > Reference: https://docs.travis-ci.com/user/languages/python/#specifying-python-versions > > Signed-off-by: Cleber Rosa <crosa@redhat.com> > > Reviewed-by: Alex Bennée <alex.bennee@linaro.org> > > Do you want me to take this via my tree or keep it with the other patches? Considering that the rest of the series will be included only after 3.1 and I don't have other Python patches queued for 3.1, can you merge this one through your tree? Thanks!
On 11/12/18 11:23 AM, Eduardo Habkost wrote: > On Fri, Nov 09, 2018 at 10:07:09AM -0500, Cleber Rosa wrote: >> For the two Python jobs, which seem to have the goal of making sure >> QEMU builds successfully on the 3.0-3.6 spectrum of Python 3 versions, >> the specified version is only applicable if a Python virtual >> environment is used. To do that, it's necessary to define the >> (primary?) language of the job to be Python. >> >> Also, Travis doesn't have a 3.0 Python installation available for the >> chosen distro, 3.2 being the lower version available. >> >> Reference: https://docs.travis-ci.com/user/languages/python/#specifying-python-versions >> Signed-off-by: Cleber Rosa <crosa@redhat.com> > > This doesn't depend on patches 1 and 2, right? > No, it doesn't. > The rest of the series will wait for the next release, but this > looks like something we want to merge before QEMU 3.1. > Sounds good! - Cleber.
diff --git a/.travis.yml b/.travis.yml index aa49c7b114..5c18d3e268 100644 --- a/.travis.yml +++ b/.travis.yml @@ -112,9 +112,11 @@ matrix: compiler: clang # Python builds - env: CONFIG="--target-list=x86_64-softmmu" + language: python python: - - "3.0" + - "3.2" - env: CONFIG="--target-list=x86_64-softmmu" + language: python python: - "3.6" # Acceptance (Functional) tests
For the two Python jobs, which seem to have the goal of making sure QEMU builds successfully on the 3.0-3.6 spectrum of Python 3 versions, the specified version is only applicable if a Python virtual environment is used. To do that, it's necessary to define the (primary?) language of the job to be Python. Also, Travis doesn't have a 3.0 Python installation available for the chosen distro, 3.2 being the lower version available. Reference: https://docs.travis-ci.com/user/languages/python/#specifying-python-versions Signed-off-by: Cleber Rosa <crosa@redhat.com> --- .travis.yml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)