mbox series

[net-next,0/8] net: sched: pie: align PIE implementation with RFC 8033

Message ID 1541002772-28040-1-git-send-email-lesliemonis@gmail.com
Headers show
Series net: sched: pie: align PIE implementation with RFC 8033 | expand

Message

Leslie Monis Oct. 31, 2018, 4:19 p.m. UTC
The current implementation of PIE queueing discipline is according to an IETF
draft [http://tools.ietf.org/html/draft-pan-aqm-pie-00] and the paper
[PIE: A Lightweight Control Scheme to Address the Bufferbloat Problem].
However, a lot of necessary modifications and enhancements have been proposed
in RFC 8033, which have not yet been incorporated in the source code of Linux
kernel. The following series of patches helps in achieving the same.

This patch series includes:

1. Change the value of QUEUE_THRESHOLD
2. Change the default value of pie_params->target
3. Change the default value of pie_params->tupdate
4. Change the initial value of pie_vars->burst_time
5. Add more conditions to auto-tune alpha and beta
6. Add mechanism to set PIE active/inactive
7. Add a derandomization mechanism
8. Update references

Mohit P. Tahiliani (8):
  net: sched: pie: change value of QUEUE_THRESHOLD
  net: sched: pie: change default value of pie_params->target
  net: sched: pie: change default value of pie_params->tupdate
  net: sched: pie: change initial value of pie_vars->burst_time
  net: sched: pie: add more conditions to auto-tune alpha and beta
  net: sched: pie: add mechanism to set PIE active/inactive
  net: sched: pie: add derandomization mechanism
  net: sched: pie: update references

 net/sched/sch_pie.c | 77 +++++++++++++++++++++++++++++++++++++++++++----------
 1 file changed, 63 insertions(+), 14 deletions(-)

Comments

Stephen Hemminger Oct. 31, 2018, 4:36 p.m. UTC | #1
On Wed, 31 Oct 2018 21:49:24 +0530
Leslie Monis <lesliemonis@gmail.com> wrote:

> The current implementation of PIE queueing discipline is according to an IETF
> draft [http://tools.ietf.org/html/draft-pan-aqm-pie-00] and the paper
> [PIE: A Lightweight Control Scheme to Address the Bufferbloat Problem].
> However, a lot of necessary modifications and enhancements have been proposed
> in RFC 8033, which have not yet been incorporated in the source code of Linux
> kernel. The following series of patches helps in achieving the same.
> 
> This patch series includes:
> 
> 1. Change the value of QUEUE_THRESHOLD
> 2. Change the default value of pie_params->target
> 3. Change the default value of pie_params->tupdate
> 4. Change the initial value of pie_vars->burst_time
> 5. Add more conditions to auto-tune alpha and beta
> 6. Add mechanism to set PIE active/inactive
> 7. Add a derandomization mechanism
> 8. Update references
> 
> Mohit P. Tahiliani (8):
>   net: sched: pie: change value of QUEUE_THRESHOLD
>   net: sched: pie: change default value of pie_params->target
>   net: sched: pie: change default value of pie_params->tupdate
>   net: sched: pie: change initial value of pie_vars->burst_time
>   net: sched: pie: add more conditions to auto-tune alpha and beta
>   net: sched: pie: add mechanism to set PIE active/inactive
>   net: sched: pie: add derandomization mechanism
>   net: sched: pie: update references
> 
>  net/sched/sch_pie.c | 77 +++++++++++++++++++++++++++++++++++++++++++----------
>  1 file changed, 63 insertions(+), 14 deletions(-)
> 

Did you do performance tests? Often the RFC is out of date and
the actual values are better than those in the standard.
David Miller Oct. 31, 2018, 5:43 p.m. UTC | #2
net-next is closed, please resubmit this when net-next opens back up.

Thank you.