| Message ID | 20181019220743.15020-30-lukas.auer@aisec.fraunhofer.de |
|---|---|
| State | Superseded |
| Delegated to: | Andes |
| Headers | show |
| Series | General fixes / cleanup for RISC-V and improvements to qemu-riscv | expand |
Hi Lukas, On Sat, Oct 20, 2018 at 6:11 AM Lukas Auer <lukas.auer@aisec.fraunhofer.de> wrote: > > Signed-off-by: Lukas Auer <lukas.auer@aisec.fraunhofer.de> > --- > > include/dm/ofnode.h | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/include/dm/ofnode.h b/include/dm/ofnode.h > index 2fc9fa39a3..a7b8609cf4 100644 > --- a/include/dm/ofnode.h > +++ b/include/dm/ofnode.h > @@ -216,6 +216,16 @@ static inline int ofnode_read_s32(ofnode node, const char *propname, > return ofnode_read_u32(node, propname, (u32 *)out_value); > } > > +/** > + * ofnode_read_u64() - Read a 64-bit integer from a property > + * > + * @node: valid node reference to read property from > + * @propname: name of the property to read from > + * @outp: place to put value (if found) > + * @return 0 if OK, -ve on error > + */ > +int ofnode_read_u64(ofnode node, const char *propname, u64 *outp); > + Can you please put this at the same location in ofnode.c? eg: put after ofnode_read_s32_default() > /** > * ofnode_read_u32_default() - Read a 32-bit integer from a property > * > -- Regards, Bin
Hi Bin, On Mon, 2018-10-22 at 17:35 +0800, Bin Meng wrote: > Hi Lukas, > > On Sat, Oct 20, 2018 at 6:11 AM Lukas Auer > <lukas.auer@aisec.fraunhofer.de> wrote: > > > > Signed-off-by: Lukas Auer <lukas.auer@aisec.fraunhofer.de> > > --- > > > > include/dm/ofnode.h | 10 ++++++++++ > > 1 file changed, 10 insertions(+) > > > > diff --git a/include/dm/ofnode.h b/include/dm/ofnode.h > > index 2fc9fa39a3..a7b8609cf4 100644 > > --- a/include/dm/ofnode.h > > +++ b/include/dm/ofnode.h > > @@ -216,6 +216,16 @@ static inline int ofnode_read_s32(ofnode node, > > const char *propname, > > return ofnode_read_u32(node, propname, (u32 *)out_value); > > } > > > > +/** > > + * ofnode_read_u64() - Read a 64-bit integer from a property > > + * > > + * @node: valid node reference to read property from > > + * @propname: name of the property to read from > > + * @outp: place to put value (if found) > > + * @return 0 if OK, -ve on error > > + */ > > +int ofnode_read_u64(ofnode node, const char *propname, u64 *outp); > > + > > Can you please put this at the same location in ofnode.c? eg: put > after ofnode_read_s32_default() > Yes, I will fix this in v2. Thanks, Lukas > > /** > > * ofnode_read_u32_default() - Read a 32-bit integer from a > > property > > * > > -- > > Regards, > Bin
diff --git a/include/dm/ofnode.h b/include/dm/ofnode.h index 2fc9fa39a3..a7b8609cf4 100644 --- a/include/dm/ofnode.h +++ b/include/dm/ofnode.h @@ -216,6 +216,16 @@ static inline int ofnode_read_s32(ofnode node, const char *propname, return ofnode_read_u32(node, propname, (u32 *)out_value); } +/** + * ofnode_read_u64() - Read a 64-bit integer from a property + * + * @node: valid node reference to read property from + * @propname: name of the property to read from + * @outp: place to put value (if found) + * @return 0 if OK, -ve on error + */ +int ofnode_read_u64(ofnode node, const char *propname, u64 *outp); + /** * ofnode_read_u32_default() - Read a 32-bit integer from a property *
Signed-off-by: Lukas Auer <lukas.auer@aisec.fraunhofer.de> --- include/dm/ofnode.h | 10 ++++++++++ 1 file changed, 10 insertions(+)