| Message ID | 1539086718-4119-1-git-send-email-laoar.shao@gmail.com |
|---|---|
| State | Changes Requested, archived |
| Delegated to: | David Miller |
| Headers | show |
| Series | [v3,net-next] inet: remove redundant backlog setting in listen(2) | expand |
On Tue, Oct 9, 2018 at 5:05 AM Yafang Shao <laoar.shao@gmail.com> wrote: > > The sk_max_ack_backlog will be set in the caller inet_listen() and > dccp_listen_start(), so it is redundant to set it in > inet_csk_listen_start(). > Just remove this setting. > > Signed-off-by: Yafang Shao <laoar.shao@gmail.com> > --- > net/ipv4/inet_connection_sock.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/net/ipv4/inet_connection_sock.c b/net/ipv4/inet_connection_sock.c > index dfd5009..cdd5c95 100644 > --- a/net/ipv4/inet_connection_sock.c > +++ b/net/ipv4/inet_connection_sock.c > @@ -871,7 +871,6 @@ int inet_csk_listen_start(struct sock *sk, int backlog) > > reqsk_queue_alloc(&icsk->icsk_accept_queue); > > - sk->sk_max_ack_backlog = backlog; > sk->sk_ack_backlog = 0; > inet_csk_delack_init(sk); You got it wrong again. Can you read my feedbacks one more time ? This setting is not redundant, unless you move the ones in inet_listen() and inet_dccp_listen() earlier.
diff --git a/net/ipv4/inet_connection_sock.c b/net/ipv4/inet_connection_sock.c index dfd5009..cdd5c95 100644 --- a/net/ipv4/inet_connection_sock.c +++ b/net/ipv4/inet_connection_sock.c @@ -871,7 +871,6 @@ int inet_csk_listen_start(struct sock *sk, int backlog) reqsk_queue_alloc(&icsk->icsk_accept_queue); - sk->sk_max_ack_backlog = backlog; sk->sk_ack_backlog = 0; inet_csk_delack_init(sk);
The sk_max_ack_backlog will be set in the caller inet_listen() and dccp_listen_start(), so it is redundant to set it in inet_csk_listen_start(). Just remove this setting. Signed-off-by: Yafang Shao <laoar.shao@gmail.com> --- net/ipv4/inet_connection_sock.c | 1 - 1 file changed, 1 deletion(-)