Message ID | 20181008201027.17952-15-boris.brezillon@bootlin.com |
---|---|
State | Not Applicable, archived |
Headers | show |
Series | mtd: maps: physmap cleanups | expand |
HI Boris Usually they want the bindings to be sent before the changes. You might want to swap the order of 13 and 14. And I think the version reviewed by Rob is too different to this version, maybe we want to ping him to be 100% sure that his review is still valid. FWIW: To the whose serie, after you send the fixed version, you can add to all the patches my: Reviewed-by: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com> and to the last one: Tested-by: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com> Thanks a lot for the serie! On Mon, Oct 8, 2018 at 10:10 PM Boris Brezillon <boris.brezillon@bootlin.com> wrote: > > From: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com> > > Add documentation for the addr-gpios. This extension to the physmap > binding allow creating flash devices that are paged using GPIOs. > > Cc: devicetree@vger.kernel.org > Reviewed-by: Rob Herring <robh@kernel.org> > Signed-off-by: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com> > Signed-off-by: Boris Brezillon <boris.brezillon@bootlin.com> > --- > Documentation/devicetree/bindings/mtd/mtd-physmap.txt | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/Documentation/devicetree/bindings/mtd/mtd-physmap.txt b/Documentation/devicetree/bindings/mtd/mtd-physmap.txt > index 232fa12e90ef..7df0dcaccb7d 100644 > --- a/Documentation/devicetree/bindings/mtd/mtd-physmap.txt > +++ b/Documentation/devicetree/bindings/mtd/mtd-physmap.txt > @@ -29,6 +29,8 @@ file systems on embedded devices. > - use-advanced-sector-protection: boolean to enable support for the > advanced sector protection (Spansion: PPB - Persistent Protection > Bits) locking. > + - addr-gpios : (optional) List of GPIO descriptors that will be used to > + address the MSBs address lines. The order goes from LSB to MSB. > > For JEDEC compatible devices, the following additional properties > are defined: > -- > 2.14.1 >
Hi Ricardo, On Tue, 9 Oct 2018 09:43:16 +0200 Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com> wrote: > HI Boris > > Usually they want the bindings to be sent before the changes. You > might want to swap the order of 13 and 14 Sure. > And I think the version > reviewed by Rob is too different to this version, maybe we want to > ping him to be 100% sure that his review is still valid. I'll drop his R-b then. > > FWIW: To the whose serie, after you send the fixed version, you can > add to all the patches my: > Reviewed-by: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com> > > and to the last one: > Tested-by: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com> > > Thanks a lot for the serie! And thanks for testing+reviewing it. Regards, Boris
diff --git a/Documentation/devicetree/bindings/mtd/mtd-physmap.txt b/Documentation/devicetree/bindings/mtd/mtd-physmap.txt index 232fa12e90ef..7df0dcaccb7d 100644 --- a/Documentation/devicetree/bindings/mtd/mtd-physmap.txt +++ b/Documentation/devicetree/bindings/mtd/mtd-physmap.txt @@ -29,6 +29,8 @@ file systems on embedded devices. - use-advanced-sector-protection: boolean to enable support for the advanced sector protection (Spansion: PPB - Persistent Protection Bits) locking. + - addr-gpios : (optional) List of GPIO descriptors that will be used to + address the MSBs address lines. The order goes from LSB to MSB. For JEDEC compatible devices, the following additional properties are defined: