| Message ID | 20181005124940.15539-1-ricardo.ribalda@gmail.com |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | [v8,1/3,media] imx214: device tree binding | expand |
On Fri, Oct 05, 2018 at 02:49:37PM +0200, Ricardo Ribalda Delgado wrote: > From: Ricardo Ribalda <ricardo.ribalda@gmail.com> > > Document bindings for imx214 camera sensor > > Cc: devicetree@vger.kernel.org > Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > Signed-off-by: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com> checkpatch.pl complains that the author and S-o-b don't match. > --- > .../devicetree/bindings/media/i2c/imx214.txt | 53 +++++++++++++++++++ sony,imx214.txt is preferred. > 1 file changed, 53 insertions(+) > create mode 100644 Documentation/devicetree/bindings/media/i2c/imx214.txt > > diff --git a/Documentation/devicetree/bindings/media/i2c/imx214.txt b/Documentation/devicetree/bindings/media/i2c/imx214.txt > new file mode 100644 > index 000000000000..421a019ab7f9 > --- /dev/null > +++ b/Documentation/devicetree/bindings/media/i2c/imx214.txt > @@ -0,0 +1,53 @@ > +* Sony 1/3.06-Inch 13.13Mp CMOS Digital Image Sensor > + > +The Sony imx214 is a 1/3.06-inch CMOS active pixel digital image sensor with > +an active array size of 4224H x 3200V. It is programmable through an I2C > +interface. The I2C address can be configured to 0x1a or 0x10, depending on > +how the hardware is wired. Move the addresses to reg description. > +Image data is sent through MIPI CSI-2, through 2 or 4 lanes at a maximum > +throughput of 1.2Gbps/lane. > + > + > +Required Properties: > +- compatible: value should be "sony,imx214" for imx214 sensor > +- reg: I2C bus address of the device > +- enable-gpios: GPIO descriptor for the enable pin. > +- vdddo-supply: Chip digital IO regulator (1.8V). > +- vdda-supply: Chip analog regulator (2.7V). > +- vddd-supply: Chip digital core regulator (1.12V). > +- clocks: Reference to the xclk clock. > +- clock-names: Shall be "xclk". > + > +Optional Properties: > +- flash-leds: See ../video-interfaces.txt > +- lens-focus: See ../video-interfaces.txt > + > +The imx214 device node shall contain one 'port' child node with > +an 'endpoint' subnode. For further reading on port node refer to > +Documentation/devicetree/bindings/media/video-interfaces.txt. > + > +Required Properties on endpoint: > +- data-lanes: check ../video-interfaces.txt > +- link-frequencies: check ../video-interfaces.txt > +- remote-endpoint: check ../video-interfaces.txt > + > +Example: > + > + camera_rear@1a { camera-sensor@1a If you need location, then perhaps use 'label'. > + compatible = "sony,imx214"; > + reg = <0x1a>; > + vdddo-supply = <&pm8994_lvs1>; > + vddd-supply = <&camera_vddd_1v12>; > + vdda-supply = <&pm8994_l17>; > + lens-focus = <&ad5820>; > + enable-gpios = <&msmgpio 25 GPIO_ACTIVE_HIGH>; > + clocks = <&mmcc CAMSS_MCLK0_CLK>; > + clock-names = "xclk"; > + port { > + imx214_ep: endpoint { > + data-lanes = <1 2 3 4>; > + link-frequencies = /bits/ 64 <480000000>; > + remote-endpoint = <&csiphy0_ep>; > + }; > + }; > + }; > -- > 2.19.0 >
Hi Ricardo, On Fri, Oct 05, 2018 at 02:49:37PM +0200, Ricardo Ribalda Delgado wrote: > From: Ricardo Ribalda <ricardo.ribalda@gmail.com> > > Document bindings for imx214 camera sensor > > Cc: devicetree@vger.kernel.org > Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > Signed-off-by: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com> > --- > .../devicetree/bindings/media/i2c/imx214.txt | 53 +++++++++++++++++++ > 1 file changed, 53 insertions(+) > create mode 100644 Documentation/devicetree/bindings/media/i2c/imx214.txt > > diff --git a/Documentation/devicetree/bindings/media/i2c/imx214.txt b/Documentation/devicetree/bindings/media/i2c/imx214.txt > new file mode 100644 > index 000000000000..421a019ab7f9 > --- /dev/null > +++ b/Documentation/devicetree/bindings/media/i2c/imx214.txt > @@ -0,0 +1,53 @@ > +* Sony 1/3.06-Inch 13.13Mp CMOS Digital Image Sensor > + > +The Sony imx214 is a 1/3.06-inch CMOS active pixel digital image sensor with > +an active array size of 4224H x 3200V. It is programmable through an I2C > +interface. The I2C address can be configured to 0x1a or 0x10, depending on > +how the hardware is wired. > +Image data is sent through MIPI CSI-2, through 2 or 4 lanes at a maximum > +throughput of 1.2Gbps/lane. > + > + > +Required Properties: > +- compatible: value should be "sony,imx214" for imx214 sensor should -> shall ?
diff --git a/Documentation/devicetree/bindings/media/i2c/imx214.txt b/Documentation/devicetree/bindings/media/i2c/imx214.txt new file mode 100644 index 000000000000..421a019ab7f9 --- /dev/null +++ b/Documentation/devicetree/bindings/media/i2c/imx214.txt @@ -0,0 +1,53 @@ +* Sony 1/3.06-Inch 13.13Mp CMOS Digital Image Sensor + +The Sony imx214 is a 1/3.06-inch CMOS active pixel digital image sensor with +an active array size of 4224H x 3200V. It is programmable through an I2C +interface. The I2C address can be configured to 0x1a or 0x10, depending on +how the hardware is wired. +Image data is sent through MIPI CSI-2, through 2 or 4 lanes at a maximum +throughput of 1.2Gbps/lane. + + +Required Properties: +- compatible: value should be "sony,imx214" for imx214 sensor +- reg: I2C bus address of the device +- enable-gpios: GPIO descriptor for the enable pin. +- vdddo-supply: Chip digital IO regulator (1.8V). +- vdda-supply: Chip analog regulator (2.7V). +- vddd-supply: Chip digital core regulator (1.12V). +- clocks: Reference to the xclk clock. +- clock-names: Shall be "xclk". + +Optional Properties: +- flash-leds: See ../video-interfaces.txt +- lens-focus: See ../video-interfaces.txt + +The imx214 device node shall contain one 'port' child node with +an 'endpoint' subnode. For further reading on port node refer to +Documentation/devicetree/bindings/media/video-interfaces.txt. + +Required Properties on endpoint: +- data-lanes: check ../video-interfaces.txt +- link-frequencies: check ../video-interfaces.txt +- remote-endpoint: check ../video-interfaces.txt + +Example: + + camera_rear@1a { + compatible = "sony,imx214"; + reg = <0x1a>; + vdddo-supply = <&pm8994_lvs1>; + vddd-supply = <&camera_vddd_1v12>; + vdda-supply = <&pm8994_l17>; + lens-focus = <&ad5820>; + enable-gpios = <&msmgpio 25 GPIO_ACTIVE_HIGH>; + clocks = <&mmcc CAMSS_MCLK0_CLK>; + clock-names = "xclk"; + port { + imx214_ep: endpoint { + data-lanes = <1 2 3 4>; + link-frequencies = /bits/ 64 <480000000>; + remote-endpoint = <&csiphy0_ep>; + }; + }; + };