diff mbox series

[21/23] python-pyhamcrest: new package

Message ID 20180926153505.3411-22-asafka7@gmail.com
State Accepted
Headers show
Series Fix python-crossbar to work with python 3.7 | expand

Commit Message

Asaf Kahlon Sept. 26, 2018, 3:35 p.m. UTC 
Hamcrest framework for matcher objects.

Signed-off-by: Asaf Kahlon <asafka7@gmail.com>
---
 DEVELOPERS                                       |  1 +
 package/Config.in                                |  1 +
 package/python-pyhamcrest/Config.in              |  8 ++++++++
 package/python-pyhamcrest/python-pyhamcrest.hash |  5 +++++
 package/python-pyhamcrest/python-pyhamcrest.mk   | 14 ++++++++++++++
 5 files changed, 29 insertions(+)
 create mode 100644 package/python-pyhamcrest/Config.in
 create mode 100644 package/python-pyhamcrest/python-pyhamcrest.hash
 create mode 100644 package/python-pyhamcrest/python-pyhamcrest.mk

Comments

Thomas Petazzoni Oct. 4, 2018, 12:02 p.m. UTC | #1 
Hello,

On Wed, 26 Sep 2018 18:35:03 +0300, Asaf Kahlon wrote:
> Hamcrest framework for matcher objects.
> 
> Signed-off-by: Asaf Kahlon <asafka7@gmail.com>
> ---
>  DEVELOPERS                                       |  1 +
>  package/Config.in                                |  1 +
>  package/python-pyhamcrest/Config.in              |  8 ++++++++
>  package/python-pyhamcrest/python-pyhamcrest.hash |  5 +++++
>  package/python-pyhamcrest/python-pyhamcrest.mk   | 14 ++++++++++++++
>  5 files changed, 29 insertions(+)
>  create mode 100644 package/python-pyhamcrest/Config.in
>  create mode 100644 package/python-pyhamcrest/python-pyhamcrest.hash
>  create mode 100644 package/python-pyhamcrest/python-pyhamcrest.mk

I've applied to master with Yegor Reviewed-by. However, I have a
question, see below.

> +config BR2_PACKAGE_PYTHON_PYHAMCREST
> +	bool "python-pyhamcrest"
> +	select BR2_PACKAGE_PYTHON_SETUPTOOLS # runtime

How do you know, or how does scanpypi knows when setuptools is needed
on the target vs. when it's only needed at build time on the build
machine ?

Thanks,

Thomas
Asaf Kahlon Oct. 4, 2018, 7:30 p.m. UTC | #2 
Thomas, Yegor,

On Thu, Oct 4, 2018 at 3:02 PM Thomas Petazzoni
<thomas.petazzoni@bootlin.com> wrote:
>
> Hello,
>
> On Wed, 26 Sep 2018 18:35:03 +0300, Asaf Kahlon wrote:
> > Hamcrest framework for matcher objects.
> >
> > Signed-off-by: Asaf Kahlon <asafka7@gmail.com>
> > ---
> >  DEVELOPERS                                       |  1 +
> >  package/Config.in                                |  1 +
> >  package/python-pyhamcrest/Config.in              |  8 ++++++++
> >  package/python-pyhamcrest/python-pyhamcrest.hash |  5 +++++
> >  package/python-pyhamcrest/python-pyhamcrest.mk   | 14 ++++++++++++++
> >  5 files changed, 29 insertions(+)
> >  create mode 100644 package/python-pyhamcrest/Config.in
> >  create mode 100644 package/python-pyhamcrest/python-pyhamcrest.hash
> >  create mode 100644 package/python-pyhamcrest/python-pyhamcrest.mk
>
> I've applied to master with Yegor Reviewed-by. However, I have a
> question, see below.
>
> > +config BR2_PACKAGE_PYTHON_PYHAMCREST
> > +     bool "python-pyhamcrest"
> > +     select BR2_PACKAGE_PYTHON_SETUPTOOLS # runtime
>
> How do you know, or how does scanpypi knows when setuptools is needed
> on the target vs. when it's only needed at build time on the build
> machine ?

As far as I know, there's no special treatment for setuptools in
scanpypi. For pyhamcrest, setuptools was added since it was explicitly
mentioned under install_requires.
Generally, not adding setuptools to install_requires is much like not
adding any other package and scanpypi won't catch this. (Yegor,
correct me if I am wrong).
Most of the times, I try to run python and import the package for
sanity check, but (at least from a first glance) I don't think there's
a way to know exactly if setuptools is needed on target although not
specified in install_requires.

>
> Thanks,
>
> Thomas
> --
> Thomas Petazzoni, CTO, Bootlin
> Embedded Linux and Kernel engineering
> https://bootlin.com

Regards,
Asaf.
Yegor Yefremov Oct. 6, 2018, 3:03 p.m. UTC | #3 
On Thu, Oct 4, 2018 at 9:30 PM Asaf Kahlon <asafka7@gmail.com> wrote:
>
> Thomas, Yegor,
>
> On Thu, Oct 4, 2018 at 3:02 PM Thomas Petazzoni
> <thomas.petazzoni@bootlin.com> wrote:
> >
> > Hello,
> >
> > On Wed, 26 Sep 2018 18:35:03 +0300, Asaf Kahlon wrote:
> > > Hamcrest framework for matcher objects.
> > >
> > > Signed-off-by: Asaf Kahlon <asafka7@gmail.com>
> > > ---
> > >  DEVELOPERS                                       |  1 +
> > >  package/Config.in                                |  1 +
> > >  package/python-pyhamcrest/Config.in              |  8 ++++++++
> > >  package/python-pyhamcrest/python-pyhamcrest.hash |  5 +++++
> > >  package/python-pyhamcrest/python-pyhamcrest.mk   | 14 ++++++++++++++
> > >  5 files changed, 29 insertions(+)
> > >  create mode 100644 package/python-pyhamcrest/Config.in
> > >  create mode 100644 package/python-pyhamcrest/python-pyhamcrest.hash
> > >  create mode 100644 package/python-pyhamcrest/python-pyhamcrest.mk
> >
> > I've applied to master with Yegor Reviewed-by. However, I have a
> > question, see below.
> >
> > > +config BR2_PACKAGE_PYTHON_PYHAMCREST
> > > +     bool "python-pyhamcrest"
> > > +     select BR2_PACKAGE_PYTHON_SETUPTOOLS # runtime
> >
> > How do you know, or how does scanpypi knows when setuptools is needed
> > on the target vs. when it's only needed at build time on the build
> > machine ?
>
> As far as I know, there's no special treatment for setuptools in
> scanpypi. For pyhamcrest, setuptools was added since it was explicitly
> mentioned under install_requires.
> Generally, not adding setuptools to install_requires is much like not
> adding any other package and scanpypi won't catch this. (Yegor,
> correct me if I am wrong).
> Most of the times, I try to run python and import the package for
> sanity check, but (at least from a first glance) I don't think there's
> a way to know exactly if setuptools is needed on target although not
> specified in install_requires.

This is my point of view too. In most cases setuotools is not needed
for the module itself, but for the installed scripts.

Yegor
diff mbox series

Patch

diff --git a/DEVELOPERS b/DEVELOPERS
index 986423e9a7..b667b24d18 100644
--- a/DEVELOPERS
+++ b/DEVELOPERS
@@ -207,6 +207,7 @@  F:	package/python-paramiko/
 F:	package/python-passlib/
 F:	package/python-pyasn1/
 F:	package/python-pyasn1-modules/
+F:	package/python-pyhamcrest/
 F:	package/python-pyroute2/
 F:	package/python-pytz/
 F:	package/python-reentry/
diff --git a/package/Config.in b/package/Config.in
index 38b4196f67..5034126c68 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -929,6 +929,7 @@  menu "External python modules"
 	source "package/python-pyftpdlib/Config.in"
 	source "package/python-pygame/Config.in"
 	source "package/python-pygments/Config.in"
+	source "package/python-pyhamcrest/Config.in"
 	source "package/python-pyicu/Config.in"
 	source "package/python-pyinotify/Config.in"
 	source "package/python-pylibftdi/Config.in"
diff --git a/package/python-pyhamcrest/Config.in b/package/python-pyhamcrest/Config.in
new file mode 100644
index 0000000000..c2a4dc06f7
--- /dev/null
+++ b/package/python-pyhamcrest/Config.in
@@ -0,0 +1,8 @@ 
+config BR2_PACKAGE_PYTHON_PYHAMCREST
+	bool "python-pyhamcrest"
+	select BR2_PACKAGE_PYTHON_SETUPTOOLS # runtime
+	select BR2_PACKAGE_PYTHON_SIX # runtime
+	help
+	  Hamcrest framework for matcher objects.
+
+	  https://github.com/hamcrest/PyHamcrest
diff --git a/package/python-pyhamcrest/python-pyhamcrest.hash b/package/python-pyhamcrest/python-pyhamcrest.hash
new file mode 100644
index 0000000000..0c1660e08a
--- /dev/null
+++ b/package/python-pyhamcrest/python-pyhamcrest.hash
@@ -0,0 +1,5 @@ 
+# md5, sha256 from https://pypi.org/pypi/pyhamcrest/json
+md5	8b833a3fa30197455df79424f30c8c3f  PyHamcrest-1.9.0.tar.gz
+sha256	8ffaa0a53da57e89de14ced7185ac746227a8894dbd5a3c718bf05ddbd1d56cd  PyHamcrest-1.9.0.tar.gz
+# Locally computed sha256 checksums
+sha256	ec76c04449607010d061b1e29c9d20a5ffae74db9d04670ae82538ccfe68b941  LICENSE.txt
diff --git a/package/python-pyhamcrest/python-pyhamcrest.mk b/package/python-pyhamcrest/python-pyhamcrest.mk
new file mode 100644
index 0000000000..244aa8c606
--- /dev/null
+++ b/package/python-pyhamcrest/python-pyhamcrest.mk
@@ -0,0 +1,14 @@ 
+################################################################################
+#
+# python-pyhamcrest
+#
+################################################################################
+
+PYTHON_PYHAMCREST_VERSION = 1.9.0
+PYTHON_PYHAMCREST_SOURCE = PyHamcrest-$(PYTHON_PYHAMCREST_VERSION).tar.gz
+PYTHON_PYHAMCREST_SITE = https://files.pythonhosted.org/packages/a4/89/a469aad9256aedfbb47a29ec2b2eeb855d9f24a7a4c2ff28bd8d1042ef02
+PYTHON_PYHAMCREST_SETUP_TYPE = setuptools
+PYTHON_PYHAMCREST_LICENSE = BSD-3-Clause
+PYTHON_PYHAMCREST_LICENSE_FILES = LICENSE.txt
+
+$(eval $(python-package))