Message ID | 20180926150739.15316-1-miquel.raynal@bootlin.com |
---|---|
Headers | show |
Series | SPI-NAND support (third batch) | expand |
On Wed, 26 Sep 2018 17:07:32 +0200 Miquel Raynal <miquel.raynal@bootlin.com> wrote: > > Miquel Raynal (7): > mtd: uclass: add probe function > mtd: mtdpart: add a generic mtdparts-like parser > mtd: mtdpart: search for an equivalent MTD name with the mtdids > mtd: mtdpart: implement proper partition handling > cmd: mtd: add 'mtd' command > cmd: ubi: clean the partition handling > cmd: mtdparts: describe as legacy > The whole series is Reviewed-by: Boris Brezillon <boris.brezillon@bootlin.com> > cmd/Kconfig | 18 +- > cmd/Makefile | 1 + > cmd/mtd.c | 471 +++++++++++++++++++++++ > cmd/ubi.c | 96 ++--- > drivers/mtd/Makefile | 2 +- > drivers/mtd/mtd-uclass.c | 16 + > drivers/mtd/mtd_uboot.c | 154 +++++++- > drivers/mtd/mtdcore.c | 2 + > drivers/mtd/mtdpart.c | 683 +++++++++++++++++++++------------ > include/linux/mtd/mtd.h | 31 ++ > include/linux/mtd/partitions.h | 7 +- > include/mtd.h | 3 + > 12 files changed, 1169 insertions(+), 315 deletions(-) > create mode 100644 cmd/mtd.c >
Hi Jagan, Boris Brezillon <boris.brezillon@bootlin.com> wrote on Thu, 27 Sep 2018 08:10:05 +0200: > On Wed, 26 Sep 2018 17:07:32 +0200 > Miquel Raynal <miquel.raynal@bootlin.com> wrote: > > > > > Miquel Raynal (7): > > mtd: uclass: add probe function > > mtd: mtdpart: add a generic mtdparts-like parser > > mtd: mtdpart: search for an equivalent MTD name with the mtdids > > mtd: mtdpart: implement proper partition handling > > cmd: mtd: add 'mtd' command > > cmd: ubi: clean the partition handling > > cmd: mtdparts: describe as legacy > > > > The whole series is > > Reviewed-by: Boris Brezillon <boris.brezillon@bootlin.com> Actually, we could have a build issue with people not enabling MTD_PARTITIONS. Let me send a v10 where: * mtd_search_alternate_name() is moved in mtd_uboot.c (generic code, everybody wants to use mtdids). * mtd_parse_partitions() is still in mtdparts.c because it depends on partitions support, but the header file declaring it (include/linux/mtd/partitions.h) also has a dummy function if #ifdef MTD_PARTITIONS is false. Thanks, Miquèl