Message ID | 20180820111623.23173-3-chrismcc@gmail.com |
---|---|
State | Accepted |
Headers | show |
Series | scancpan patches | expand |
2018-08-20 13:16 GMT+02:00 Christopher McCrory <chrismcc@gmail.com>: > Signed-off-by: Christopher McCrory <chrismcc@gmail.com> > --- > utils/scancpan | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/utils/scancpan b/utils/scancpan > index 6c90588ed4..c83730fa13 100755 > --- a/utils/scancpan > +++ b/utils/scancpan > @@ -603,6 +603,7 @@ sub fetch { > # we could use the host Module::CoreList data, because host > perl and > # target perl have the same major version > next if ${$dep}{phase} eq q{develop}; > + next if ${$dep}{phase} eq q{x_Dist_Zilla}; > please, indent with only space (no hard tab). François > next if !($test && $top) && ${$dep}{phase} eq q{test}; > my $distname = $mcpan->module( $modname )->{distribution}; > if (${$dep}{phase} eq q{runtime}) { > -- > 2.14.4 > > _______________________________________________ > buildroot mailing list > buildroot@busybox.net > http://lists.busybox.net/mailman/listinfo/buildroot > <div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">2018-08-20 13:16 GMT+02:00 Christopher McCrory <span dir="ltr"><<a href="mailto:chrismcc@gmail.com" target="_blank">chrismcc@gmail.com</a>></span>:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Signed-off-by: Christopher McCrory <<a href="mailto:chrismcc@gmail.com">chrismcc@gmail.com</a>><br> ---<br> utils/scancpan | 1 +<br> 1 file changed, 1 insertion(+)<br> <br> diff --git a/utils/scancpan b/utils/scancpan<br> index 6c90588ed4..c83730fa13 100755<br> --- a/utils/scancpan<br> +++ b/utils/scancpan<br> @@ -603,6 +603,7 @@ sub fetch {<br> # we could use the host Module::CoreList data, because host perl and<br> # target perl have the same major version<br> next if ${$dep}{phase} eq q{develop};<br> + next if ${$dep}{phase} eq q{x_Dist_Zilla};<br></blockquote><div><br></div><div>please, indent with only space (no hard tab).<br></div><div><br></div><div>François<br></div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"> next if !($test && $top) && ${$dep}{phase} eq q{test};<br> my $distname = $mcpan->module( $modname )->{distribution};<br> if (${$dep}{phase} eq q{runtime}) {<br> <span class="HOEnZb"><font color="#888888">-- <br> 2.14.4<br> <br> ______________________________<wbr>_________________<br> buildroot mailing list<br> <a href="mailto:buildroot@busybox.net">buildroot@busybox.net</a><br> <a href="http://lists.busybox.net/mailman/listinfo/buildroot" rel="noreferrer" target="_blank">http://lists.busybox.net/<wbr>mailman/listinfo/buildroot</a><br> </font></span></blockquote></div><br></div></div>
Hello, On Mon, 20 Aug 2018 04:16:22 -0700, Christopher McCrory wrote: > Signed-off-by: Christopher McCrory <chrismcc@gmail.com> > --- > utils/scancpan | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/utils/scancpan b/utils/scancpan > index 6c90588ed4..c83730fa13 100755 > --- a/utils/scancpan > +++ b/utils/scancpan > @@ -603,6 +603,7 @@ sub fetch { > # we could use the host Module::CoreList data, because host perl and > # target perl have the same major version > next if ${$dep}{phase} eq q{develop}; > + next if ${$dep}{phase} eq q{x_Dist_Zilla}; I fixed the indentation issue that François reported, and applied. BTW, it is not really great that a comment made on August 21 is not addressed by a new version of the patches while we are a month later. I was in fact waiting for a new version to apply this change, but since it didn't arrive, I ended up fixing it up before applying. Thanks, Thomas
diff --git a/utils/scancpan b/utils/scancpan index 6c90588ed4..c83730fa13 100755 --- a/utils/scancpan +++ b/utils/scancpan @@ -603,6 +603,7 @@ sub fetch { # we could use the host Module::CoreList data, because host perl and # target perl have the same major version next if ${$dep}{phase} eq q{develop}; + next if ${$dep}{phase} eq q{x_Dist_Zilla}; next if !($test && $top) && ${$dep}{phase} eq q{test}; my $distname = $mcpan->module( $modname )->{distribution}; if (${$dep}{phase} eq q{runtime}) {
Signed-off-by: Christopher McCrory <chrismcc@gmail.com> --- utils/scancpan | 1 + 1 file changed, 1 insertion(+)