mbox series

[iproute2,v2,0/3] testsuite: make alltests fixes

Message ID 20180919233624.18494-1-petr.vorel@gmail.com
Headers show
Series testsuite: make alltests fixes | expand

Message

Petr Vorel Sept. 19, 2018, 11:36 p.m. UTC 
Hi,

here are simply fixes to restore 'make alltests'.
Currently it does not run.

Kind regards,
Petr

Petr Vorel (3):
  testsuite: Fix missing generate_nlmsg
  testsuite: Generate generate_nlmsg when needed
  testsuite: Warn about empty $(IPVERS)

 testsuite/Makefile | 21 ++++++++++++++-------
 1 file changed, 14 insertions(+), 7 deletions(-)

Comments

Phil Sutter Sept. 20, 2018, 8:02 a.m. UTC | #1 
Hi Petr,

On Thu, Sep 20, 2018 at 01:36:21AM +0200, Petr Vorel wrote:
> here are simply fixes to restore 'make alltests'.
> Currently it does not run.

Yeah, that testsuite definitely deserves some love.

Just one nit: The one-line summary in Fixes: tags should be enclosed in
quotes and parens, e.g.:

| Fixes: deadbeef ("foo bar")

Cheers, Phil
Luca Boccassi Sept. 20, 2018, 10:02 a.m. UTC | #2 
On Thu, 2018-09-20 at 01:36 +0200, Petr Vorel wrote:
> Hi,
> 
> here are simply fixes to restore 'make alltests'.
> Currently it does not run.
> 
> Kind regards,
> Petr
> 
> Petr Vorel (3):
>   testsuite: Fix missing generate_nlmsg
>   testsuite: Generate generate_nlmsg when needed
>   testsuite: Warn about empty $(IPVERS)
> 
>  testsuite/Makefile | 21 ++++++++++++++-------
>  1 file changed, 14 insertions(+), 7 deletions(-)

Series-tested-by: Luca Boccassi <bluca@debian.org>
Stephen Hemminger Sept. 21, 2018, 4:16 p.m. UTC | #3 
On Thu, 20 Sep 2018 01:36:21 +0200
Petr Vorel <petr.vorel@gmail.com> wrote:

> Hi,
> 
> here are simply fixes to restore 'make alltests'.
> Currently it does not run.
> 
> Kind regards,
> Petr
> 
> Petr Vorel (3):
>   testsuite: Fix missing generate_nlmsg
>   testsuite: Generate generate_nlmsg when needed
>   testsuite: Warn about empty $(IPVERS)
> 
>  testsuite/Makefile | 21 ++++++++++++++-------
>  1 file changed, 14 insertions(+), 7 deletions(-)
> 

Applied, it would be good to have 'make tests' at the top level.