diff mbox series

[02/18] perl-dbd-mysql: new package

Message ID 20180820115519.24046-3-chrismcc@gmail.com
State Accepted
Headers show
Series perl modules again | expand

Commit Message

Christopher McCrory Aug. 20, 2018, 11:55 a.m. UTC 
Signed-off-by: Christopher McCrory <chrismcc@gmail.com>
---
 DEVELOPERS                                 |  1 +
 package/Config.in                          |  1 +
 package/perl-dbd-mysql/Config.in           | 12 ++++++++++++
 package/perl-dbd-mysql/perl-dbd-mysql.hash |  6 ++++++
 package/perl-dbd-mysql/perl-dbd-mysql.mk   | 15 +++++++++++++++
 5 files changed, 35 insertions(+)
 create mode 100644 package/perl-dbd-mysql/Config.in
 create mode 100644 package/perl-dbd-mysql/perl-dbd-mysql.hash
 create mode 100644 package/perl-dbd-mysql/perl-dbd-mysql.mk

Comments

Francois Perrad Aug. 21, 2018, 1:16 p.m. UTC | #1 
2018-08-20 13:55 GMT+02:00 Christopher McCrory <chrismcc@gmail.com>:

> Signed-off-by: Christopher McCrory <chrismcc@gmail.com>
>

Acked-by: Francois Perrad <francois.perrad@gadz.org>

---
>  DEVELOPERS                                 |  1 +
>  package/Config.in                          |  1 +
>  package/perl-dbd-mysql/Config.in           | 12 ++++++++++++
>  package/perl-dbd-mysql/perl-dbd-mysql.hash |  6 ++++++
>  package/perl-dbd-mysql/perl-dbd-mysql.mk   | 15 +++++++++++++++
>  5 files changed, 35 insertions(+)
>  create mode 100644 package/perl-dbd-mysql/Config.in
>  create mode 100644 package/perl-dbd-mysql/perl-dbd-mysql.hash
>  create mode 100644 package/perl-dbd-mysql/perl-dbd-mysql.mk
>
> diff --git a/DEVELOPERS b/DEVELOPERS
> index 9a2576ddc7..75237eae3b 100644
> --- a/DEVELOPERS
> +++ b/DEVELOPERS
> @@ -489,6 +489,7 @@ F:  package/perl-class-std-fast/
>  F:     package/perl-data-optlist/
>  F:     package/perl-data-uuid/
>  F:     package/perl-date-manip/
> +F:     package/perl-dbd-mysql/
>  F:     package/perl-dbi/
>  F:     package/perl-device-serialport/
>  F:     package/perl-file-slurp/
> diff --git a/package/Config.in b/package/Config.in
> index eda0f698dc..b6e739dade 100644
> --- a/package/Config.in
> +++ b/package/Config.in
> @@ -678,6 +678,7 @@ menu "Perl libraries/modules"
>         source "package/perl-data-uuid/Config.in"
>         source "package/perl-date-manip/Config.in"
>         source "package/perl-datetime-tiny/Config.in"
> +       source "package/perl-dbd-mysql/Config.in"
>         source "package/perl-dbi/Config.in"
>         source "package/perl-device-serialport/Config.in"
>         source "package/perl-digest-hmac/Config.in"
> diff --git a/package/perl-dbd-mysql/Config.in b/package/perl-dbd-mysql/
> Config.in
> new file mode 100644
> index 0000000000..49e7ff99d6
> --- /dev/null
> +++ b/package/perl-dbd-mysql/Config.in
> @@ -0,0 +1,12 @@
> +config BR2_PACKAGE_PERL_DBD_MYSQL
> +       bool "perl-dbd-mysql"
> +       depends on !BR2_STATIC_LIBS
> +       select BR2_PACKAGE_PERL_DBI
> +       select BR2_PACKAGE_MYSQL
> +       help
> +         A MySQL driver for the Perl5 Database Interface (DBI)
> +
> +         http://dbi.perl.org/
> +
> +comment "perl-dbd-mysql needs a toolchain w/ dynamic library"
> +       depends on BR2_STATIC_LIBS
> diff --git a/package/perl-dbd-mysql/perl-dbd-mysql.hash
> b/package/perl-dbd-mysql/perl-dbd-mysql.hash
> new file mode 100644
> index 0000000000..51de476095
> --- /dev/null
> +++ b/package/perl-dbd-mysql/perl-dbd-mysql.hash
> @@ -0,0 +1,6 @@
> +# retrieved by scancpan from http://cpan.metacpan.org/
> +md5    bdf4f4d899b8af29ebd8ebfb7438d05f DBD-mysql-4.046.tar.gz
> +sha256 6165652ec959d05b97f5413fa3dff014b78a44cf6de21ae87283b28378daf1f7
> DBD-mysql-4.046.tar.gz
> +
> +# computed by scancpan
> +sha256 7a9ba29702b957805cfa8aa63bca43175625824263232dbade0010d385ab888c
> LICENSE
> diff --git a/package/perl-dbd-mysql/perl-dbd-mysql.mk
> b/package/perl-dbd-mysql/perl-dbd-mysql.mk
> new file mode 100644
> index 0000000000..752bc199b1
> --- /dev/null
> +++ b/package/perl-dbd-mysql/perl-dbd-mysql.mk
> @@ -0,0 +1,15 @@
> +###########################################################
> #####################
> +#
> +# perl-dbd-mysql
> +#
> +###########################################################
> #####################
> +
> +PERL_DBD_MYSQL_VERSION = 4.046
> +PERL_DBD_MYSQL_SOURCE = DBD-mysql-$(PERL_DBD_MYSQL_VERSION).tar.gz
> +PERL_DBD_MYSQL_SITE = $(BR2_CPAN_MIRROR)/authors/id/C/CA/CAPTTOFU
> +PERL_DBD_MYSQL_DEPENDENCIES = host-perl-dbi perl-dbi mysql
> +PERL_DBD_MYSQL_CONF_OPTS += --mysql_config=$(STAGING_DIR)/
> usr/bin/mysql_config
> +PERL_DBD_MYSQL_LICENSE = Artistic or GPL-1.0+
> +PERL_DBD_MYSQL_LICENSE_FILES = LICENSE
> +
> +$(eval $(perl-package))
> --
> 2.14.4
>
> _______________________________________________
> buildroot mailing list
> buildroot@busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
>
<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">2018-08-20 13:55 GMT+02:00 Christopher McCrory <span dir="ltr">&lt;<a href="mailto:chrismcc@gmail.com" target="_blank">chrismcc@gmail.com</a>&gt;</span>:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Signed-off-by: Christopher McCrory &lt;<a href="mailto:chrismcc@gmail.com">chrismcc@gmail.com</a>&gt;<br></blockquote><div><br></div><div>Acked-by: Francois Perrad &lt;<a href="mailto:francois.perrad@gadz.org">francois.perrad@gadz.org</a>&gt;<br></div><div> <br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
---<br>
 DEVELOPERS                                 |  1 +<br>
 package/Config.in                          |  1 +<br>
 package/perl-dbd-mysql/Config.<wbr>in           | 12 ++++++++++++<br>
 package/perl-dbd-mysql/perl-<wbr>dbd-mysql.hash |  6 ++++++<br>
 package/perl-dbd-mysql/<a href="http://perl-dbd-mysql.mk" rel="noreferrer" target="_blank">perl-<wbr>dbd-mysql.mk</a>   | 15 +++++++++++++++<br>
 5 files changed, 35 insertions(+)<br>
 create mode 100644 package/perl-dbd-mysql/Config.<wbr>in<br>
 create mode 100644 package/perl-dbd-mysql/perl-<wbr>dbd-mysql.hash<br>
 create mode 100644 package/perl-dbd-mysql/<a href="http://perl-dbd-mysql.mk" rel="noreferrer" target="_blank">perl-<wbr>dbd-mysql.mk</a><br>
<br>
diff --git a/DEVELOPERS b/DEVELOPERS<br>
index 9a2576ddc7..75237eae3b 100644<br>
--- a/DEVELOPERS<br>
+++ b/DEVELOPERS<br>
@@ -489,6 +489,7 @@ F:  package/perl-class-std-fast/<br>
 F:     package/perl-data-optlist/<br>
 F:     package/perl-data-uuid/<br>
 F:     package/perl-date-manip/<br>
+F:     package/perl-dbd-mysql/<br>
 F:     package/perl-dbi/<br>
 F:     package/perl-device-<wbr>serialport/<br>
 F:     package/perl-file-slurp/<br>
diff --git a/package/Config.in b/package/Config.in<br>
index eda0f698dc..b6e739dade 100644<br>
--- a/package/Config.in<br>
+++ b/package/Config.in<br>
@@ -678,6 +678,7 @@ menu &quot;Perl libraries/modules&quot;<br>
        source &quot;package/perl-data-uuid/<wbr>Config.in&quot;<br>
        source &quot;package/perl-date-manip/<wbr>Config.in&quot;<br>
        source &quot;package/perl-datetime-tiny/<wbr>Config.in&quot;<br>
+       source &quot;package/perl-dbd-mysql/<wbr>Config.in&quot;<br>
        source &quot;package/perl-dbi/Config.in&quot;<br>
        source &quot;package/perl-device-<wbr>serialport/Config.in&quot;<br>
        source &quot;package/perl-digest-hmac/<wbr>Config.in&quot;<br>
diff --git a/package/perl-dbd-mysql/<wbr>Config.in b/package/perl-dbd-mysql/<wbr>Config.in<br>
new file mode 100644<br>
index 0000000000..49e7ff99d6<br>
--- /dev/null<br>
+++ b/package/perl-dbd-mysql/<wbr>Config.in<br>
@@ -0,0 +1,12 @@<br>
+config BR2_PACKAGE_PERL_DBD_MYSQL<br>
+       bool &quot;perl-dbd-mysql&quot;<br>
+       depends on !BR2_STATIC_LIBS<br>
+       select BR2_PACKAGE_PERL_DBI<br>
+       select BR2_PACKAGE_MYSQL<br>
+       help<br>
+         A MySQL driver for the Perl5 Database Interface (DBI)<br>
+<br>
+         <a href="http://dbi.perl.org/" rel="noreferrer" target="_blank">http://dbi.perl.org/</a><br>
+<br>
+comment &quot;perl-dbd-mysql needs a toolchain w/ dynamic library&quot;<br>
+       depends on BR2_STATIC_LIBS<br>
diff --git a/package/perl-dbd-mysql/perl-<wbr>dbd-mysql.hash b/package/perl-dbd-mysql/perl-<wbr>dbd-mysql.hash<br>
new file mode 100644<br>
index 0000000000..51de476095<br>
--- /dev/null<br>
+++ b/package/perl-dbd-mysql/perl-<wbr>dbd-mysql.hash<br>
@@ -0,0 +1,6 @@<br>
+# retrieved by scancpan from <a href="http://cpan.metacpan.org/" rel="noreferrer" target="_blank">http://cpan.metacpan.org/</a><br>
+md5    bdf4f4d899b8af29ebd8ebfb7438d0<wbr>5f DBD-mysql-4.046.tar.gz<br>
+sha256 6165652ec959d05b97f5413fa3dff0<wbr>14b78a44cf6de21ae87283b28378da<wbr>f1f7 DBD-mysql-4.046.tar.gz<br>
+<br>
+# computed by scancpan<br>
+sha256 7a9ba29702b957805cfa8aa63bca43<wbr>175625824263232dbade0010d385ab<wbr>888c LICENSE<br>
diff --git a/package/perl-dbd-mysql/<a href="http://perl-dbd-mysql.mk" rel="noreferrer" target="_blank">perl-<wbr>dbd-mysql.mk</a> b/package/perl-dbd-mysql/<a href="http://perl-dbd-mysql.mk" rel="noreferrer" target="_blank">perl-<wbr>dbd-mysql.mk</a><br>
new file mode 100644<br>
index 0000000000..752bc199b1<br>
--- /dev/null<br>
+++ b/package/perl-dbd-mysql/<a href="http://perl-dbd-mysql.mk" rel="noreferrer" target="_blank">perl-<wbr>dbd-mysql.mk</a><br>
@@ -0,0 +1,15 @@<br>
+#############################<wbr>##############################<wbr>#####################<br>
+#<br>
+# perl-dbd-mysql<br>
+#<br>
+#############################<wbr>##############################<wbr>#####################<br>
+<br>
+PERL_DBD_MYSQL_VERSION = 4.046<br>
+PERL_DBD_MYSQL_SOURCE = DBD-mysql-$(PERL_DBD_MYSQL_<wbr>VERSION).tar.gz<br>
+PERL_DBD_MYSQL_SITE = $(BR2_CPAN_MIRROR)/authors/id/<wbr>C/CA/CAPTTOFU<br>
+PERL_DBD_MYSQL_DEPENDENCIES = host-perl-dbi perl-dbi mysql<br>
+PERL_DBD_MYSQL_CONF_OPTS += --mysql_config=$(STAGING_DIR)/<wbr>usr/bin/mysql_config<br>
+PERL_DBD_MYSQL_LICENSE = Artistic or GPL-1.0+<br>
+PERL_DBD_MYSQL_LICENSE_FILES = LICENSE<br>
+<br>
+$(eval $(perl-package))<br>
<span class="gmail-HOEnZb"><font color="#888888">-- <br>
2.14.4<br>
<br>
______________________________<wbr>_________________<br>
buildroot mailing list<br>
<a href="mailto:buildroot@busybox.net">buildroot@busybox.net</a><br>
<a href="http://lists.busybox.net/mailman/listinfo/buildroot" rel="noreferrer" target="_blank">http://lists.busybox.net/<wbr>mailman/listinfo/buildroot</a><br>
</font></span></blockquote></div><br></div></div>
Thomas Petazzoni Sept. 11, 2018, 1:42 p.m. UTC | #2 
Hello,

On Mon, 20 Aug 2018 04:55:03 -0700, Christopher McCrory wrote:
> Signed-off-by: Christopher McCrory <chrismcc@gmail.com>
> ---
>  DEVELOPERS                                 |  1 +
>  package/Config.in                          |  1 +
>  package/perl-dbd-mysql/Config.in           | 12 ++++++++++++
>  package/perl-dbd-mysql/perl-dbd-mysql.hash |  6 ++++++
>  package/perl-dbd-mysql/perl-dbd-mysql.mk   | 15 +++++++++++++++
>  5 files changed, 35 insertions(+)
>  create mode 100644 package/perl-dbd-mysql/Config.in
>  create mode 100644 package/perl-dbd-mysql/perl-dbd-mysql.hash
>  create mode 100644 package/perl-dbd-mysql/perl-dbd-mysql.mk

I've applied, but there was a mistake in the patch, see below.

> diff --git a/package/perl-dbd-mysql/Config.in b/package/perl-dbd-mysql/Config.in
> new file mode 100644
> index 0000000000..49e7ff99d6
> --- /dev/null
> +++ b/package/perl-dbd-mysql/Config.in
> @@ -0,0 +1,12 @@
> +config BR2_PACKAGE_PERL_DBD_MYSQL
> +	bool "perl-dbd-mysql"
> +	depends on !BR2_STATIC_LIBS
> +	select BR2_PACKAGE_PERL_DBI
> +	select BR2_PACKAGE_MYSQL

You select BR2_PACKAGE_MYSQL without replicating its dependencies:
BR2_USE_MMU, BR2_TOOLCHAIN_HAS_THREADS and BR2_INSTALL_LIBSTDCPP. While
BR2_USE_MMU is guaranteed to be true because perl itself cannot be
enabled if !BR2_USE_MMU, there is nothing that guarantees
BR2_INSTALL_LIBSTDCPP and BR2_TOOLCHAIN_HAS_THREADS are true.

I fixed that by adding the appropriate dependencies, and adjusting the
Config.in comment accordingly.

> +PERL_DBD_MYSQL_VERSION = 4.046
> +PERL_DBD_MYSQL_SOURCE = DBD-mysql-$(PERL_DBD_MYSQL_VERSION).tar.gz
> +PERL_DBD_MYSQL_SITE = $(BR2_CPAN_MIRROR)/authors/id/C/CA/CAPTTOFU
> +PERL_DBD_MYSQL_DEPENDENCIES = host-perl-dbi perl-dbi mysql
> +PERL_DBD_MYSQL_CONF_OPTS += --mysql_config=$(STAGING_DIR)/usr/bin/mysql_config

Minor nit: the += here isn't really needed, a = was sufficient.

Thanks!

Thomas
diff mbox series

Patch

diff --git a/DEVELOPERS b/DEVELOPERS
index 9a2576ddc7..75237eae3b 100644
--- a/DEVELOPERS
+++ b/DEVELOPERS
@@ -489,6 +489,7 @@  F:	package/perl-class-std-fast/
 F:	package/perl-data-optlist/
 F:	package/perl-data-uuid/
 F:	package/perl-date-manip/
+F:	package/perl-dbd-mysql/
 F:	package/perl-dbi/
 F:	package/perl-device-serialport/
 F:	package/perl-file-slurp/
diff --git a/package/Config.in b/package/Config.in
index eda0f698dc..b6e739dade 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -678,6 +678,7 @@  menu "Perl libraries/modules"
 	source "package/perl-data-uuid/Config.in"
 	source "package/perl-date-manip/Config.in"
 	source "package/perl-datetime-tiny/Config.in"
+	source "package/perl-dbd-mysql/Config.in"
 	source "package/perl-dbi/Config.in"
 	source "package/perl-device-serialport/Config.in"
 	source "package/perl-digest-hmac/Config.in"
diff --git a/package/perl-dbd-mysql/Config.in b/package/perl-dbd-mysql/Config.in
new file mode 100644
index 0000000000..49e7ff99d6
--- /dev/null
+++ b/package/perl-dbd-mysql/Config.in
@@ -0,0 +1,12 @@ 
+config BR2_PACKAGE_PERL_DBD_MYSQL
+	bool "perl-dbd-mysql"
+	depends on !BR2_STATIC_LIBS
+	select BR2_PACKAGE_PERL_DBI
+	select BR2_PACKAGE_MYSQL
+	help
+	  A MySQL driver for the Perl5 Database Interface (DBI)
+
+	  http://dbi.perl.org/
+
+comment "perl-dbd-mysql needs a toolchain w/ dynamic library"
+	depends on BR2_STATIC_LIBS
diff --git a/package/perl-dbd-mysql/perl-dbd-mysql.hash b/package/perl-dbd-mysql/perl-dbd-mysql.hash
new file mode 100644
index 0000000000..51de476095
--- /dev/null
+++ b/package/perl-dbd-mysql/perl-dbd-mysql.hash
@@ -0,0 +1,6 @@ 
+# retrieved by scancpan from http://cpan.metacpan.org/
+md5    bdf4f4d899b8af29ebd8ebfb7438d05f DBD-mysql-4.046.tar.gz
+sha256 6165652ec959d05b97f5413fa3dff014b78a44cf6de21ae87283b28378daf1f7 DBD-mysql-4.046.tar.gz
+
+# computed by scancpan
+sha256 7a9ba29702b957805cfa8aa63bca43175625824263232dbade0010d385ab888c LICENSE
diff --git a/package/perl-dbd-mysql/perl-dbd-mysql.mk b/package/perl-dbd-mysql/perl-dbd-mysql.mk
new file mode 100644
index 0000000000..752bc199b1
--- /dev/null
+++ b/package/perl-dbd-mysql/perl-dbd-mysql.mk
@@ -0,0 +1,15 @@ 
+################################################################################
+#
+# perl-dbd-mysql
+#
+################################################################################
+
+PERL_DBD_MYSQL_VERSION = 4.046
+PERL_DBD_MYSQL_SOURCE = DBD-mysql-$(PERL_DBD_MYSQL_VERSION).tar.gz
+PERL_DBD_MYSQL_SITE = $(BR2_CPAN_MIRROR)/authors/id/C/CA/CAPTTOFU
+PERL_DBD_MYSQL_DEPENDENCIES = host-perl-dbi perl-dbi mysql
+PERL_DBD_MYSQL_CONF_OPTS += --mysql_config=$(STAGING_DIR)/usr/bin/mysql_config
+PERL_DBD_MYSQL_LICENSE = Artistic or GPL-1.0+
+PERL_DBD_MYSQL_LICENSE_FILES = LICENSE
+
+$(eval $(perl-package))