| Message ID | 1536186133-9933-2-git-send-email-angelo.compagnucci@gmail.com |
|---|---|
| State | Rejected |
| Headers | show |
| Series | Add tainting support to buildroot | expand |
Hello, On Thu, 6 Sep 2018 00:22:11 +0200, Angelo Compagnucci wrote: > Packages who harms the build reproducibility or licensing can declare > FOO_TAINTS variable. If a package taints the build it will be added > to a list of tainting packages. The build ends with a warning if the > tainting packages list is not empty. Moreover, legal info will show > a warning in presence of a tainting package. > > Tainting of host packages is not supported right now. > > Signed-off-by: Angelo Compagnucci <angelo@amarulasolutions.com> > Signed-off-by: Angelo Compagnucci <angelo.compagnucci@gmail.com> Why two SoBs ? Just one matching the From: is good enough. > +ifdef $(2)_TAINTS > +ifeq ($$($$($(2)_KCONFIG_VAR)),y) > +BR2_TAINTED_BY+=$$($(2)_RAWNAME) Spaces around += No need to resend just for that. Just explain why you have two SoB, if I can keep just one, I can fix that up when applying. Thanks, Thomas
On Thu, Sep 6, 2018 at 9:44 AM, Thomas Petazzoni <thomas.petazzoni@bootlin.com> wrote: > Hello, > > On Thu, 6 Sep 2018 00:22:11 +0200, Angelo Compagnucci wrote: >> Packages who harms the build reproducibility or licensing can declare >> FOO_TAINTS variable. If a package taints the build it will be added >> to a list of tainting packages. The build ends with a warning if the >> tainting packages list is not empty. Moreover, legal info will show >> a warning in presence of a tainting package. >> >> Tainting of host packages is not supported right now. >> >> Signed-off-by: Angelo Compagnucci <angelo@amarulasolutions.com> >> Signed-off-by: Angelo Compagnucci <angelo.compagnucci@gmail.com> > > Why two SoBs ? Just one matching the From: is good enough. > >> +ifdef $(2)_TAINTS >> +ifeq ($$($$($(2)_KCONFIG_VAR)),y) >> +BR2_TAINTED_BY+=$$($(2)_RAWNAME) > > Spaces around += > > No need to resend just for that. Just explain why you have two SoB, if > I can keep just one, I can fix that up when applying. Sorry Thomas, I was on another pc and forget about different git configuration. You can keep angelo@amarulasolutions.com one please. Thanks! > > Thanks, > > Thomas > -- > Thomas Petazzoni, CTO, Bootlin > Embedded Linux and Kernel engineering > https://bootlin.com
diff --git a/Makefile b/Makefile index 9d66bba..ad61130 100644 --- a/Makefile +++ b/Makefile @@ -758,12 +758,21 @@ endif touch $(TARGET_DIR)/usr +.PHONY: check-tainted +check-tainted: +ifneq ($(BR2_TAINTED_BY),) + $(error Your buildroot configuration is tainted by: $(BR2_TAINTED_BY)) +else + @echo "Your buildroot configuration is not tainted" +endif + .PHONY: target-post-image target-post-image: $(TARGETS_ROOTFS) target-finalize @rm -f $(ROOTFS_COMMON_TAR) @$(foreach s, $(call qstrip,$(BR2_ROOTFS_POST_IMAGE_SCRIPT)), \ $(call MESSAGE,"Executing post-image script $(s)"); \ $(EXTRA_ENV) $(s) $(BINARIES_DIR) $(call qstrip,$(BR2_ROOTFS_POST_SCRIPT_ARGS))$(sep)) + $(if $(BR2_TAINTED_BY),@echo "WARNING: Your buildroot configuration is tainted by: $(BR2_TAINTED_BY).") .PHONY: source source: $(foreach p,$(PACKAGES),$(p)-all-source) @@ -1070,6 +1079,7 @@ help: @echo ' source - download all sources needed for offline-build' @echo ' external-deps - list external packages used' @echo ' legal-info - generate info about license compliance' + @echo ' check-tainted - check if any selected package harms build reproducibility or licensing' @echo ' printvars - dump all the internal variables' @echo @echo ' make V=0|1 - 0 => quiet build (default), 1 => verbose build' diff --git a/package/pkg-generic.mk b/package/pkg-generic.mk index 91b61c6..465916c 100644 --- a/package/pkg-generic.mk +++ b/package/pkg-generic.mk @@ -870,6 +870,15 @@ else $(2)_KCONFIG_VAR = BR2_PACKAGE_$(2) endif +ifdef $(2)_TAINTS +ifeq ($$($$($(2)_KCONFIG_VAR)),y) +BR2_TAINTED_BY+=$$($(2)_RAWNAME) +endif +ifeq ($$($(2)_TYPE),host) +$$(error "Host package $(1) has $(2)_TAINTS set: not supported) +endif +endif + # legal-info: declare dependencies and set values used later for the manifest ifneq ($$($(2)_LICENSE_FILES),) $(2)_MANIFEST_LICENSE_FILES = $$($(2)_LICENSE_FILES) @@ -909,6 +918,12 @@ else $(Q)$$(foreach F,$$($(2)_LICENSE_FILES),$$(call legal-license-file,$$($(2)_RAWNAME),$$($(2)_BASENAME_RAW),$$($(2)_PKGDIR),$$(F),$$($(2)_DIR)/$$(F),$$(call UPPERCASE,$(4)))$$(sep)) endif # license files +ifeq ($$(call qstrip,$$($(2)_TAINTS)),YES) +ifeq ($$($$($(2)_KCONFIG_VAR)),y) + $(Q)$$(call legal-warning-pkg,$$($(2)_RAWNAME),unknown license for additional modules or dependencies) +endif +endif + ifeq ($$($(2)_SITE_METHOD),local) # Packages without a tarball: don't save and warn @$$(call legal-warning-nosource,$$($(2)_RAWNAME),local)