Message ID | 20180903084853.18092-6-quentin.schulz@bootlin.com |
---|---|
State | Not Applicable, archived |
Headers | show |
Series | None | expand |
On Mon, Sep 03, 2018 at 10:48:52AM +0200, Quentin Schulz wrote: > Compatible isn't a required property for PHYs so let's remove it from > the binding DT of the VSC8531 PHYs. Hi Quentin It is actually a optional property. So you could move it into that section of the binding documentation. But removing it is also O.K. Andrew
Hi Andrew, On Mon, Sep 03, 2018 at 03:30:20PM +0200, Andrew Lunn wrote: > On Mon, Sep 03, 2018 at 10:48:52AM +0200, Quentin Schulz wrote: > > Compatible isn't a required property for PHYs so let's remove it from > > the binding DT of the VSC8531 PHYs. > > Hi Quentin > > It is actually a optional property. So you could move it into that > section of the binding documentation. But removing it is also O.K. > It's a property that is already defined in Documentation/devicetree/bindings/net/phy.txt I don't think it's actually useful to redefine it there (on the same principle that we don't redefine/re-explain the reg property). What do we do? Do I put it in optional properties and refer to the aforementioned doc or do I just remove it as it's done in this patch? Thanks, Quentin
> What do we do? Do I put it in optional properties and refer to the > aforementioned doc or do I just remove it as it's done in this patch? Just remove it. Andrew
diff --git a/Documentation/devicetree/bindings/net/mscc-phy-vsc8531.txt b/Documentation/devicetree/bindings/net/mscc-phy-vsc8531.txt index 0eedabe22cc3..664d9d0543fc 100644 --- a/Documentation/devicetree/bindings/net/mscc-phy-vsc8531.txt +++ b/Documentation/devicetree/bindings/net/mscc-phy-vsc8531.txt @@ -1,10 +1,5 @@ * Microsemi - vsc8531 Giga bit ethernet phy -Required properties: -- compatible : Should contain phy id as "ethernet-phy-idAAAA.BBBB" - The PHY device uses the binding described in - Documentation/devicetree/bindings/net/phy.txt - Optional properties: - vsc8531,vddmac : The vddmac in mV. Allowed values is listed in the first row of Table 1 (below).