| Message ID | 20180828015252.28511-1-robh@kernel.org |
|---|---|
| State | New |
| Headers | show |
| Series | ARM: omap: Convert to using %pOFn instead of device_node.name | expand |
> -----Original Message----- > From: Rob Herring [mailto:robh@kernel.org] > Sent: Tuesday, August 28, 2018 9:53 AM > To: linux-kernel@vger.kernel.org > Cc: Linus Walleij <linus.walleij@linaro.org>; A.s. Dong > <aisheng.dong@nxp.com>; Fabio Estevam <festevam@gmail.com>; Shawn > Guo <shawnguo@kernel.org>; Stefan Agner <stefan@agner.ch>; Pengutronix > Kernel Team <kernel@pengutronix.de>; Sean Wang > <sean.wang@mediatek.com>; Matthias Brugger <matthias.bgg@gmail.com>; > Carlo Caione <carlo@caione.org>; Kevin Hilman <khilman@baylibre.com>; > Jason Cooper <jason@lakedaemon.net>; Andrew Lunn <andrew@lunn.ch>; > Gregory Clement <gregory.clement@bootlin.com>; Sebastian Hesselbarth > <sebastian.hesselbarth@gmail.com>; Jean-Christophe Plagniol-Villard > <plagnioj@jcrosoft.com>; Nicolas Ferre <nicolas.ferre@microchip.com>; > Alexandre Belloni <alexandre.belloni@bootlin.com>; Heiko Stuebner > <heiko@sntech.de>; Tony Lindgren <tony@atomide.com>; Haojian Zhuang > <haojian.zhuang@linaro.org>; Patrice Chotard <patrice.chotard@st.com>; > Barry Song <baohua@kernel.org>; Maxime Coquelin > <mcoquelin.stm32@gmail.com>; Alexandre Torgue > <alexandre.torgue@st.com>; Maxime Ripard <maxime.ripard@bootlin.com>; > Chen-Yu Tsai <wens@csie.org>; linux-gpio@vger.kernel.org; > linux-mediatek@lists.infradead.org; linux-arm-kernel@lists.infradead.org; > linux-amlogic@lists.infradead.org; linux-rockchip@lists.infradead.org; > linux-omap@vger.kernel.org > Subject: [PATCH] pinctrl: Convert to using %pOFn instead of device_node.name > > In preparation to remove the node name pointer from struct device_node, > convert printf users to use the %pOFn format specifier. > > Cc: Linus Walleij <linus.walleij@linaro.org> > Cc: Dong Aisheng <aisheng.dong@nxp.com> > Cc: Fabio Estevam <festevam@gmail.com> > Cc: Shawn Guo <shawnguo@kernel.org> > Cc: Stefan Agner <stefan@agner.ch> > Cc: Pengutronix Kernel Team <kernel@pengutronix.de> > Cc: Sean Wang <sean.wang@mediatek.com> > Cc: Matthias Brugger <matthias.bgg@gmail.com> > Cc: Carlo Caione <carlo@caione.org> > Cc: Kevin Hilman <khilman@baylibre.com> > Cc: Jason Cooper <jason@lakedaemon.net> > Cc: Andrew Lunn <andrew@lunn.ch> > Cc: Gregory Clement <gregory.clement@bootlin.com> > Cc: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com> > Cc: Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com> > Cc: Nicolas Ferre <nicolas.ferre@microchip.com> > Cc: Alexandre Belloni <alexandre.belloni@bootlin.com> > Cc: Heiko Stuebner <heiko@sntech.de> > Cc: Tony Lindgren <tony@atomide.com> > Cc: Haojian Zhuang <haojian.zhuang@linaro.org> > Cc: Patrice Chotard <patrice.chotard@st.com> > Cc: Barry Song <baohua@kernel.org> > Cc: Maxime Coquelin <mcoquelin.stm32@gmail.com> > Cc: Alexandre Torgue <alexandre.torgue@st.com> > Cc: Maxime Ripard <maxime.ripard@bootlin.com> > Cc: Chen-Yu Tsai <wens@csie.org> > Cc: linux-gpio@vger.kernel.org > Cc: linux-mediatek@lists.infradead.org > Cc: linux-arm-kernel@lists.infradead.org > Cc: linux-amlogic@lists.infradead.org > Cc: linux-rockchip@lists.infradead.org > Cc: linux-omap@vger.kernel.org > Signed-off-by: Rob Herring <robh@kernel.org> > --- > drivers/pinctrl/berlin/berlin.c | 6 ++-- > drivers/pinctrl/freescale/pinctrl-imx.c | 7 ++-- > drivers/pinctrl/freescale/pinctrl-imx1-core.c | 12 +++---- For i.MX, Acked-by: Dong Aisheng <aisheng.dong@nxp.com> Regards Dong Aisheng
Dear Rob, On 2018년 08월 28일 10:52, Rob Herring wrote: > In preparation to remove the node name pointer from struct device_node, > convert printf users to use the %pOFn format specifier. > > Cc: Chanwoo Choi <cw00.choi@samsung.com> > Cc: MyungJoo Ham <myungjoo.ham@samsung.com> > Cc: Kyungmin Park <kyungmin.park@samsung.com> > Cc: Kukjin Kim <kgene@kernel.org> > Cc: Krzysztof Kozlowski <krzk@kernel.org> > Cc: linux-pm@vger.kernel.org > Cc: linux-arm-kernel@lists.infradead.org > Cc: linux-samsung-soc@vger.kernel.org > Signed-off-by: Rob Herring <robh@kernel.org> > --- > drivers/devfreq/event/exynos-ppmu.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/devfreq/event/exynos-ppmu.c b/drivers/devfreq/event/exynos-ppmu.c > index a9c64f0d3284..c61de0bdf053 100644 > --- a/drivers/devfreq/event/exynos-ppmu.c > +++ b/drivers/devfreq/event/exynos-ppmu.c > @@ -535,8 +535,8 @@ static int of_get_devfreq_events(struct device_node *np, > > if (i == ARRAY_SIZE(ppmu_events)) { > dev_warn(dev, > - "don't know how to configure events : %s\n", > - node->name); > + "don't know how to configure events : %pOFn\n", > + node); > continue; > } > > Acked-by: Chanwoo Choi <cw00.choi@samsung.com>
On Mon, 2018-08-27 at 20:52 -0500, Rob Herring wrote: > In preparation to remove the node name pointer from struct device_node, > convert printf users to use the %pOFn format specifier. [] > diff --git a/arch/arm/mach-omap2/omap_hwmod.c b/arch/arm/mach-omap2/omap_hwmod.c [] > @@ -738,7 +738,7 @@ static int __init _setup_clkctrl_provider(struct device_node *np) > provider->size = size | 0xff; > provider->node = np; > > - pr_debug("%s: %s: %x...%x [+%x]\n", __func__, np->parent->name, > + pr_debug("%pOF: %s: %x...%x [+%x]\n", __func__, np->parent, Wrong argument order I didn't look at the rest.
On 27/08/2018 20:52:41-0500, Rob Herring wrote: > In preparation to remove the node name pointer from struct device_node, > convert printf users to use the %pOFn format specifier. > > Cc: Linus Walleij <linus.walleij@linaro.org> > Cc: Dong Aisheng <aisheng.dong@nxp.com> > Cc: Fabio Estevam <festevam@gmail.com> > Cc: Shawn Guo <shawnguo@kernel.org> > Cc: Stefan Agner <stefan@agner.ch> > Cc: Pengutronix Kernel Team <kernel@pengutronix.de> > Cc: Sean Wang <sean.wang@mediatek.com> > Cc: Matthias Brugger <matthias.bgg@gmail.com> > Cc: Carlo Caione <carlo@caione.org> > Cc: Kevin Hilman <khilman@baylibre.com> > Cc: Jason Cooper <jason@lakedaemon.net> > Cc: Andrew Lunn <andrew@lunn.ch> > Cc: Gregory Clement <gregory.clement@bootlin.com> > Cc: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com> > Cc: Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com> > Cc: Nicolas Ferre <nicolas.ferre@microchip.com> > Cc: Alexandre Belloni <alexandre.belloni@bootlin.com> > Cc: Heiko Stuebner <heiko@sntech.de> > Cc: Tony Lindgren <tony@atomide.com> > Cc: Haojian Zhuang <haojian.zhuang@linaro.org> > Cc: Patrice Chotard <patrice.chotard@st.com> > Cc: Barry Song <baohua@kernel.org> > Cc: Maxime Coquelin <mcoquelin.stm32@gmail.com> > Cc: Alexandre Torgue <alexandre.torgue@st.com> > Cc: Maxime Ripard <maxime.ripard@bootlin.com> > Cc: Chen-Yu Tsai <wens@csie.org> > Cc: linux-gpio@vger.kernel.org > Cc: linux-mediatek@lists.infradead.org > Cc: linux-arm-kernel@lists.infradead.org > Cc: linux-amlogic@lists.infradead.org > Cc: linux-rockchip@lists.infradead.org > Cc: linux-omap@vger.kernel.org > Signed-off-by: Rob Herring <robh@kernel.org> For at91: Reviewed-by: Alexandre Belloni <alexandre.belloni@bootlin.com> > --- > drivers/pinctrl/berlin/berlin.c | 6 ++-- > drivers/pinctrl/freescale/pinctrl-imx.c | 7 ++-- > drivers/pinctrl/freescale/pinctrl-imx1-core.c | 12 +++---- > drivers/pinctrl/mediatek/pinctrl-mtk-common.c | 4 +-- > drivers/pinctrl/meson/pinctrl-meson.c | 2 +- > drivers/pinctrl/mvebu/pinctrl-mvebu.c | 4 +-- > drivers/pinctrl/nomadik/pinctrl-nomadik.c | 6 ++-- > drivers/pinctrl/pinctrl-at91.c | 8 ++--- > drivers/pinctrl/pinctrl-lantiq.c | 8 ++--- > drivers/pinctrl/pinctrl-rockchip.c | 8 ++--- > drivers/pinctrl/pinctrl-rza1.c | 8 ++--- > drivers/pinctrl/pinctrl-single.c | 32 +++++++++---------- > drivers/pinctrl/pinctrl-st.c | 6 ++-- > drivers/pinctrl/sirf/pinctrl-atlas7.c | 4 +-- > drivers/pinctrl/stm32/pinctrl-stm32.c | 4 +-- > drivers/pinctrl/sunxi/pinctrl-sunxi.c | 8 ++--- > drivers/pinctrl/ti/pinctrl-ti-iodelay.c | 8 ++--- > 17 files changed, 66 insertions(+), 69 deletions(-) > > diff --git a/drivers/pinctrl/berlin/berlin.c b/drivers/pinctrl/berlin/berlin.c > index b5903fffb3d0..b17a03cf87be 100644 > --- a/drivers/pinctrl/berlin/berlin.c > +++ b/drivers/pinctrl/berlin/berlin.c > @@ -64,16 +64,14 @@ static int berlin_pinctrl_dt_node_to_map(struct pinctrl_dev *pctrl_dev, > ret = of_property_read_string(node, "function", &function_name); > if (ret) { > dev_err(pctrl->dev, > - "missing function property in node %s\n", > - node->name); > + "missing function property in node %pOFn\n", node); > return -EINVAL; > } > > ngroups = of_property_count_strings(node, "groups"); > if (ngroups < 0) { > dev_err(pctrl->dev, > - "missing groups property in node %s\n", > - node->name); > + "missing groups property in node %pOFn\n", node); > return -EINVAL; > } > > diff --git a/drivers/pinctrl/freescale/pinctrl-imx.c b/drivers/pinctrl/freescale/pinctrl-imx.c > index b04edc22dad7..4e8cf0e357c6 100644 > --- a/drivers/pinctrl/freescale/pinctrl-imx.c > +++ b/drivers/pinctrl/freescale/pinctrl-imx.c > @@ -69,8 +69,7 @@ static int imx_dt_node_to_map(struct pinctrl_dev *pctldev, > */ > grp = imx_pinctrl_find_group_by_name(pctldev, np->name); > if (!grp) { > - dev_err(ipctl->dev, "unable to find group for node %s\n", > - np->name); > + dev_err(ipctl->dev, "unable to find group for node %pOFn\n", np); > return -EINVAL; > } > > @@ -434,7 +433,7 @@ static int imx_pinctrl_parse_groups(struct device_node *np, > int i; > u32 config; > > - dev_dbg(ipctl->dev, "group(%d): %s\n", index, np->name); > + dev_dbg(ipctl->dev, "group(%d): %pOFn\n", index, np); > > if (info->flags & SHARE_MUX_CONF_REG) > pin_size = FSL_PIN_SHARE_SIZE; > @@ -544,7 +543,7 @@ static int imx_pinctrl_parse_functions(struct device_node *np, > struct group_desc *grp; > u32 i = 0; > > - dev_dbg(pctl->dev, "parse function(%d): %s\n", index, np->name); > + dev_dbg(pctl->dev, "parse function(%d): %pOFn\n", index, np); > > func = pinmux_generic_get_function(pctl, index); > if (!func) > diff --git a/drivers/pinctrl/freescale/pinctrl-imx1-core.c b/drivers/pinctrl/freescale/pinctrl-imx1-core.c > index deb7870b3d1a..7e29e3fecdb2 100644 > --- a/drivers/pinctrl/freescale/pinctrl-imx1-core.c > +++ b/drivers/pinctrl/freescale/pinctrl-imx1-core.c > @@ -233,8 +233,8 @@ static int imx1_dt_node_to_map(struct pinctrl_dev *pctldev, > */ > grp = imx1_pinctrl_find_group_by_name(info, np->name); > if (!grp) { > - dev_err(info->dev, "unable to find group for node %s\n", > - np->name); > + dev_err(info->dev, "unable to find group for node %pOFn\n", > + np); > return -EINVAL; > } > > @@ -466,7 +466,7 @@ static int imx1_pinctrl_parse_groups(struct device_node *np, > const __be32 *list; > int i; > > - dev_dbg(info->dev, "group(%d): %s\n", index, np->name); > + dev_dbg(info->dev, "group(%d): %pOFn\n", index, np); > > /* Initialise group */ > grp->name = np->name; > @@ -477,8 +477,8 @@ static int imx1_pinctrl_parse_groups(struct device_node *np, > list = of_get_property(np, "fsl,pins", &size); > /* we do not check return since it's safe node passed down */ > if (!size || size % 12) { > - dev_notice(info->dev, "Not a valid fsl,pins property (%s)\n", > - np->name); > + dev_notice(info->dev, "Not a valid fsl,pins property (%pOFn)\n", > + np); > return -EINVAL; > } > > @@ -513,7 +513,7 @@ static int imx1_pinctrl_parse_functions(struct device_node *np, > static u32 grp_index; > u32 i = 0; > > - dev_dbg(info->dev, "parse function(%d): %s\n", index, np->name); > + dev_dbg(info->dev, "parse function(%d): %pOFn\n", index, np); > > func = &info->functions[index]; > > diff --git a/drivers/pinctrl/mediatek/pinctrl-mtk-common.c b/drivers/pinctrl/mediatek/pinctrl-mtk-common.c > index 16ff56f93501..071623873ca5 100644 > --- a/drivers/pinctrl/mediatek/pinctrl-mtk-common.c > +++ b/drivers/pinctrl/mediatek/pinctrl-mtk-common.c > @@ -514,8 +514,8 @@ static int mtk_pctrl_dt_subnode_to_map(struct pinctrl_dev *pctldev, > > pins = of_find_property(node, "pinmux", NULL); > if (!pins) { > - dev_err(pctl->dev, "missing pins property in node %s .\n", > - node->name); > + dev_err(pctl->dev, "missing pins property in node %pOFn .\n", > + node); > return -EINVAL; > } > > diff --git a/drivers/pinctrl/meson/pinctrl-meson.c b/drivers/pinctrl/meson/pinctrl-meson.c > index 29a458da78db..9cb81aec4e3b 100644 > --- a/drivers/pinctrl/meson/pinctrl-meson.c > +++ b/drivers/pinctrl/meson/pinctrl-meson.c > @@ -451,7 +451,7 @@ static struct regmap *meson_map_resource(struct meson_pinctrl *pc, > > meson_regmap_config.max_register = resource_size(&res) - 4; > meson_regmap_config.name = devm_kasprintf(pc->dev, GFP_KERNEL, > - "%s-%s", node->name, > + "%pOFn-%s", node, > name); > if (!meson_regmap_config.name) > return ERR_PTR(-ENOMEM); > diff --git a/drivers/pinctrl/mvebu/pinctrl-mvebu.c b/drivers/pinctrl/mvebu/pinctrl-mvebu.c > index d7ec7119701b..7ee5f7970585 100644 > --- a/drivers/pinctrl/mvebu/pinctrl-mvebu.c > +++ b/drivers/pinctrl/mvebu/pinctrl-mvebu.c > @@ -413,14 +413,14 @@ static int mvebu_pinctrl_dt_node_to_map(struct pinctrl_dev *pctldev, > ret = of_property_read_string(np, "marvell,function", &function); > if (ret) { > dev_err(pctl->dev, > - "missing marvell,function in node %s\n", np->name); > + "missing marvell,function in node %pOFn\n", np); > return 0; > } > > nmaps = of_property_count_strings(np, "marvell,pins"); > if (nmaps < 0) { > dev_err(pctl->dev, > - "missing marvell,pins in node %s\n", np->name); > + "missing marvell,pins in node %pOFn\n", np); > return 0; > } > > diff --git a/drivers/pinctrl/nomadik/pinctrl-nomadik.c b/drivers/pinctrl/nomadik/pinctrl-nomadik.c > index f0e7a8c114b2..866db2706b8b 100644 > --- a/drivers/pinctrl/nomadik/pinctrl-nomadik.c > +++ b/drivers/pinctrl/nomadik/pinctrl-nomadik.c > @@ -1051,7 +1051,7 @@ static struct nmk_gpio_chip *nmk_gpio_populate_chip(struct device_node *np, > > gpio_pdev = of_find_device_by_node(np); > if (!gpio_pdev) { > - pr_err("populate \"%s\": device not found\n", np->name); > + pr_err("populate \"%pOFn\": device not found\n", np); > return ERR_PTR(-ENODEV); > } > if (of_property_read_u32(np, "gpio-bank", &id)) { > @@ -1904,8 +1904,8 @@ static int nmk_pinctrl_probe(struct platform_device *pdev) > gpio_np = of_parse_phandle(np, "nomadik-gpio-chips", i); > if (gpio_np) { > dev_info(&pdev->dev, > - "populate NMK GPIO %d \"%s\"\n", > - i, gpio_np->name); > + "populate NMK GPIO %d \"%pOFn\"\n", > + i, gpio_np); > nmk_chip = nmk_gpio_populate_chip(gpio_np, pdev); > if (IS_ERR(nmk_chip)) > dev_err(&pdev->dev, > diff --git a/drivers/pinctrl/pinctrl-at91.c b/drivers/pinctrl/pinctrl-at91.c > index 50f0ec42c637..cfd8239f2727 100644 > --- a/drivers/pinctrl/pinctrl-at91.c > +++ b/drivers/pinctrl/pinctrl-at91.c > @@ -263,8 +263,8 @@ static int at91_dt_node_to_map(struct pinctrl_dev *pctldev, > */ > grp = at91_pinctrl_find_group_by_name(info, np->name); > if (!grp) { > - dev_err(info->dev, "unable to find group for node %s\n", > - np->name); > + dev_err(info->dev, "unable to find group for node %pOFn\n", > + np); > return -EINVAL; > } > > @@ -1071,7 +1071,7 @@ static int at91_pinctrl_parse_groups(struct device_node *np, > const __be32 *list; > int i, j; > > - dev_dbg(info->dev, "group(%d): %s\n", index, np->name); > + dev_dbg(info->dev, "group(%d): %pOFn\n", index, np); > > /* Initialise group */ > grp->name = np->name; > @@ -1122,7 +1122,7 @@ static int at91_pinctrl_parse_functions(struct device_node *np, > static u32 grp_index; > u32 i = 0; > > - dev_dbg(info->dev, "parse function(%d): %s\n", index, np->name); > + dev_dbg(info->dev, "parse function(%d): %pOFn\n", index, np); > > func = &info->functions[index]; > > diff --git a/drivers/pinctrl/pinctrl-lantiq.c b/drivers/pinctrl/pinctrl-lantiq.c > index 81632af3a86a..22e80613e269 100644 > --- a/drivers/pinctrl/pinctrl-lantiq.c > +++ b/drivers/pinctrl/pinctrl-lantiq.c > @@ -80,14 +80,14 @@ static void ltq_pinctrl_dt_subnode_to_map(struct pinctrl_dev *pctldev, > int ret, i; > > if (!pins && !groups) { > - dev_err(pctldev->dev, "%s defines neither pins nor groups\n", > - np->name); > + dev_err(pctldev->dev, "%pOFn defines neither pins nor groups\n", > + np); > return; > } > > if (pins && groups) { > - dev_err(pctldev->dev, "%s defines both pins and groups\n", > - np->name); > + dev_err(pctldev->dev, "%pOFn defines both pins and groups\n", > + np); > return; > } > > diff --git a/drivers/pinctrl/pinctrl-rockchip.c b/drivers/pinctrl/pinctrl-rockchip.c > index f4a61429e06e..1fe72af3717b 100644 > --- a/drivers/pinctrl/pinctrl-rockchip.c > +++ b/drivers/pinctrl/pinctrl-rockchip.c > @@ -501,8 +501,8 @@ static int rockchip_dt_node_to_map(struct pinctrl_dev *pctldev, > */ > grp = pinctrl_name_to_group(info, np->name); > if (!grp) { > - dev_err(info->dev, "unable to find group for node %s\n", > - np->name); > + dev_err(info->dev, "unable to find group for node %pOFn\n", > + np); > return -EINVAL; > } > > @@ -2454,7 +2454,7 @@ static int rockchip_pinctrl_parse_groups(struct device_node *np, > int i, j; > int ret; > > - dev_dbg(info->dev, "group(%d): %s\n", index, np->name); > + dev_dbg(info->dev, "group(%d): %pOFn\n", index, np); > > /* Initialise group */ > grp->name = np->name; > @@ -2519,7 +2519,7 @@ static int rockchip_pinctrl_parse_functions(struct device_node *np, > static u32 grp_index; > u32 i = 0; > > - dev_dbg(info->dev, "parse function(%d): %s\n", index, np->name); > + dev_dbg(info->dev, "parse function(%d): %pOFn\n", index, np); > > func = &info->functions[index]; > > diff --git a/drivers/pinctrl/pinctrl-rza1.c b/drivers/pinctrl/pinctrl-rza1.c > index f76edf664539..042ede3b8ada 100644 > --- a/drivers/pinctrl/pinctrl-rza1.c > +++ b/drivers/pinctrl/pinctrl-rza1.c > @@ -930,8 +930,8 @@ static int rza1_parse_pinmux_node(struct rza1_pinctrl *rza1_pctl, > &npin_configs); > if (ret) { > dev_err(rza1_pctl->dev, > - "Unable to parse pin configuration options for %s\n", > - np->name); > + "Unable to parse pin configuration options for %pOFn\n", > + np); > return ret; > } > > @@ -1226,8 +1226,8 @@ static int rza1_parse_gpiochip(struct rza1_pinctrl *rza1_pctl, > > *chip = rza1_gpiochip_template; > chip->base = -1; > - chip->label = devm_kasprintf(rza1_pctl->dev, GFP_KERNEL, "%s", > - np->name); > + chip->label = devm_kasprintf(rza1_pctl->dev, GFP_KERNEL, "%pOFn", > + np); > chip->ngpio = of_args.args[2]; > chip->of_node = np; > chip->parent = rza1_pctl->dev; > diff --git a/drivers/pinctrl/pinctrl-single.c b/drivers/pinctrl/pinctrl-single.c > index 7ec72ff2419a..1e0614daee9b 100644 > --- a/drivers/pinctrl/pinctrl-single.c > +++ b/drivers/pinctrl/pinctrl-single.c > @@ -1022,14 +1022,14 @@ static int pcs_parse_one_pinctrl_entry(struct pcs_device *pcs, > vals[found].reg = pcs->base + offset; > vals[found].val = pinctrl_spec.args[1]; > > - dev_dbg(pcs->dev, "%s index: 0x%x value: 0x%x\n", > - pinctrl_spec.np->name, offset, pinctrl_spec.args[1]); > + dev_dbg(pcs->dev, "%pOFn index: 0x%x value: 0x%x\n", > + pinctrl_spec.np, offset, pinctrl_spec.args[1]); > > pin = pcs_get_pin_by_offset(pcs, offset); > if (pin < 0) { > dev_err(pcs->dev, > - "could not add functions for %s %ux\n", > - np->name, offset); > + "could not add functions for %pOFn %ux\n", > + np, offset); > break; > } > pins[found++] = pin; > @@ -1135,8 +1135,8 @@ static int pcs_parse_bits_in_pinctrl_entry(struct pcs_device *pcs, > val = pinctrl_spec.args[1]; > mask = pinctrl_spec.args[2]; > > - dev_dbg(pcs->dev, "%s index: 0x%x value: 0x%x mask: 0x%x\n", > - pinctrl_spec.np->name, offset, val, mask); > + dev_dbg(pcs->dev, "%pOFn index: 0x%x value: 0x%x mask: 0x%x\n", > + pinctrl_spec.np, offset, val, mask); > > /* Parse pins in each row from LSB */ > while (mask) { > @@ -1148,8 +1148,8 @@ static int pcs_parse_bits_in_pinctrl_entry(struct pcs_device *pcs, > > if ((mask & mask_pos) == 0) { > dev_err(pcs->dev, > - "Invalid mask for %s at 0x%x\n", > - np->name, offset); > + "Invalid mask for %pOFn at 0x%x\n", > + np, offset); > break; > } > > @@ -1157,8 +1157,8 @@ static int pcs_parse_bits_in_pinctrl_entry(struct pcs_device *pcs, > > if (submask != mask_pos) { > dev_warn(pcs->dev, > - "Invalid submask 0x%x for %s at 0x%x\n", > - submask, np->name, offset); > + "Invalid submask 0x%x for %pOFn at 0x%x\n", > + submask, np, offset); > continue; > } > > @@ -1169,8 +1169,8 @@ static int pcs_parse_bits_in_pinctrl_entry(struct pcs_device *pcs, > pin = pcs_get_pin_by_offset(pcs, offset); > if (pin < 0) { > dev_err(pcs->dev, > - "could not add functions for %s %ux\n", > - np->name, offset); > + "could not add functions for %pOFn %ux\n", > + np, offset); > break; > } > pins[found++] = pin + pin_num_from_lsb; > @@ -1254,16 +1254,16 @@ static int pcs_dt_node_to_map(struct pinctrl_dev *pctldev, > ret = pcs_parse_bits_in_pinctrl_entry(pcs, np_config, map, > num_maps, pgnames); > if (ret < 0) { > - dev_err(pcs->dev, "no pins entries for %s\n", > - np_config->name); > + dev_err(pcs->dev, "no pins entries for %pOFn\n", > + np_config); > goto free_pgnames; > } > } else { > ret = pcs_parse_one_pinctrl_entry(pcs, np_config, map, > num_maps, pgnames); > if (ret < 0) { > - dev_err(pcs->dev, "no pins entries for %s\n", > - np_config->name); > + dev_err(pcs->dev, "no pins entries for %pOFn\n", > + np_config); > goto free_pgnames; > } > } > diff --git a/drivers/pinctrl/pinctrl-st.c b/drivers/pinctrl/pinctrl-st.c > index 0966bb0bf71f..e66af93f2cbf 100644 > --- a/drivers/pinctrl/pinctrl-st.c > +++ b/drivers/pinctrl/pinctrl-st.c > @@ -817,8 +817,8 @@ static int st_pctl_dt_node_to_map(struct pinctrl_dev *pctldev, > > grp = st_pctl_find_group_by_name(info, np->name); > if (!grp) { > - dev_err(info->dev, "unable to find group for node %s\n", > - np->name); > + dev_err(info->dev, "unable to find group for node %pOFn\n", > + np); > return -EINVAL; > } > > @@ -1184,7 +1184,7 @@ static int st_pctl_dt_parse_groups(struct device_node *np, > if (pp->length / sizeof(__be32) >= OF_GPIO_ARGS_MIN) { > npins++; > } else { > - pr_warn("Invalid st,pins in %s node\n", np->name); > + pr_warn("Invalid st,pins in %pOFn node\n", np); > return -EINVAL; > } > } > diff --git a/drivers/pinctrl/sirf/pinctrl-atlas7.c b/drivers/pinctrl/sirf/pinctrl-atlas7.c > index 3abb028f6158..1d16df128b1a 100644 > --- a/drivers/pinctrl/sirf/pinctrl-atlas7.c > +++ b/drivers/pinctrl/sirf/pinctrl-atlas7.c > @@ -6058,8 +6058,8 @@ static int atlas7_gpio_probe(struct platform_device *pdev) > ret = gpiochip_add_data(chip, a7gc); > if (ret) { > dev_err(&pdev->dev, > - "%s: error in probe function with status %d\n", > - np->name, ret); > + "%pOF: error in probe function with status %d\n", > + np, ret); > goto failed; > } > > diff --git a/drivers/pinctrl/stm32/pinctrl-stm32.c b/drivers/pinctrl/stm32/pinctrl-stm32.c > index a9bec6e6fdd1..0fbfcc9ea07c 100644 > --- a/drivers/pinctrl/stm32/pinctrl-stm32.c > +++ b/drivers/pinctrl/stm32/pinctrl-stm32.c > @@ -416,8 +416,8 @@ static int stm32_pctrl_dt_subnode_to_map(struct pinctrl_dev *pctldev, > > pins = of_find_property(node, "pinmux", NULL); > if (!pins) { > - dev_err(pctl->dev, "missing pins property in node %s .\n", > - node->name); > + dev_err(pctl->dev, "missing pins property in node %pOFn .\n", > + node); > return -EINVAL; > } > > diff --git a/drivers/pinctrl/sunxi/pinctrl-sunxi.c b/drivers/pinctrl/sunxi/pinctrl-sunxi.c > index 4d9bf9b3e9f3..3ccbe221e024 100644 > --- a/drivers/pinctrl/sunxi/pinctrl-sunxi.c > +++ b/drivers/pinctrl/sunxi/pinctrl-sunxi.c > @@ -332,15 +332,15 @@ static int sunxi_pctrl_dt_node_to_map(struct pinctrl_dev *pctldev, > > function = sunxi_pctrl_parse_function_prop(node); > if (!function) { > - dev_err(pctl->dev, "missing function property in node %s\n", > - node->name); > + dev_err(pctl->dev, "missing function property in node %pOFn\n", > + node); > return -EINVAL; > } > > pin_prop = sunxi_pctrl_find_pins_prop(node, &npins); > if (!pin_prop) { > - dev_err(pctl->dev, "missing pins property in node %s\n", > - node->name); > + dev_err(pctl->dev, "missing pins property in node %pOFn\n", > + node); > return -EINVAL; > } > > diff --git a/drivers/pinctrl/ti/pinctrl-ti-iodelay.c b/drivers/pinctrl/ti/pinctrl-ti-iodelay.c > index 8782c348ebe9..a4bc506a01a3 100644 > --- a/drivers/pinctrl/ti/pinctrl-ti-iodelay.c > +++ b/drivers/pinctrl/ti/pinctrl-ti-iodelay.c > @@ -452,8 +452,8 @@ static int ti_iodelay_node_iterator(struct pinctrl_dev *pctldev, > > pin = ti_iodelay_offset_to_pin(iod, cfg[pin_index].offset); > if (pin < 0) { > - dev_err(iod->dev, "could not add functions for %s %ux\n", > - np->name, cfg[pin_index].offset); > + dev_err(iod->dev, "could not add functions for %pOFn %ux\n", > + np, cfg[pin_index].offset); > return -ENODEV; > } > pins[pin_index] = pin; > @@ -461,8 +461,8 @@ static int ti_iodelay_node_iterator(struct pinctrl_dev *pctldev, > pd = &iod->pa[pin]; > pd->drv_data = &cfg[pin_index]; > > - dev_dbg(iod->dev, "%s offset=%x a_delay = %d g_delay = %d\n", > - np->name, cfg[pin_index].offset, cfg[pin_index].a_delay, > + dev_dbg(iod->dev, "%pOFn offset=%x a_delay = %d g_delay = %d\n", > + np, cfg[pin_index].offset, cfg[pin_index].a_delay, > cfg[pin_index].g_delay); > > return 0; > -- > 2.17.1 >
On Tue, Aug 28, 2018 at 3:54 AM Rob Herring <robh@kernel.org> wrote: > In preparation to remove the node name pointer from struct device_node, > convert printf users to use the %pOFn format specifier. > > Cc: Simon Horman <horms@verge.net.au> > Cc: Magnus Damm <magnus.damm@gmail.com> > Cc: linux-arm-kernel@lists.infradead.org > Cc: linux-renesas-soc@vger.kernel.org > Signed-off-by: Rob Herring <robh@kernel.org> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> Gr{oetje,eeting}s, Geert
On Tue, Aug 28, 2018 at 4:57 AM Rob Herring <robh@kernel.org> wrote: > In preparation to remove the node name pointer from struct device_node, > convert printf users to use the %pOFn format specifier. > + snprintf((char *)dai->platform_name, DAI_NAME_SIZE, "%llx.%pOFn", > + (unsigned long long) res.start, dma_channel_np); I understand that is not the part of the change, but wouldn't be good to replace that ugly casting with proper specifier as well? I mean %pa ... &res.start > + dev_err(&pdev->dev, "%pOFn sync own reference\n", > + np); One line?
On Mon, Aug 27, 2018 at 08:52:30PM -0500, Rob Herring wrote: > In preparation to remove the node name pointer from struct device_node, > convert printf users to use the %pOFn format specifier. > > Cc: Roger Quadros <rogerq@ti.com> > Cc: Tony Lindgren <tony@atomide.com> > Cc: Kukjin Kim <kgene@kernel.org> > Cc: Krzysztof Kozlowski <krzk@kernel.org> > Cc: Thierry Reding <thierry.reding@gmail.com> > Cc: Jonathan Hunter <jonathanh@nvidia.com> > Cc: linux-omap@vger.kernel.org > Cc: linux-arm-kernel@lists.infradead.org > Cc: linux-samsung-soc@vger.kernel.org > Cc: linux-tegra@vger.kernel.org > Signed-off-by: Rob Herring <robh@kernel.org> > --- > drivers/memory/omap-gpmc.c | 18 +++++++----------- > drivers/memory/samsung/exynos-srom.c | 4 ++-- > drivers/memory/tegra/mc.c | 6 +++--- > drivers/memory/tegra/tegra124-emc.c | 12 ++++++------ > 4 files changed, 18 insertions(+), 22 deletions(-) Acked-by: Thierry Reding <treding@nvidia.com>
On Mon, Aug 27, 2018 at 08:52:44PM -0500, Rob Herring wrote: > In preparation to remove the node name pointer from struct device_node, > convert printf users to use the %pOFn format specifier. > > Cc: Qiang Zhao <qiang.zhao@nxp.com> > Cc: Li Yang <leoyang.li@nxp.com> > Cc: Andy Gross <andy.gross@linaro.org> > Cc: David Brown <david.brown@linaro.org> > Cc: Heiko Stuebner <heiko@sntech.de> > Cc: Thierry Reding <thierry.reding@gmail.com> > Cc: Jonathan Hunter <jonathanh@nvidia.com> > Cc: Santosh Shilimkar <ssantosh@kernel.org> > Cc: linuxppc-dev@lists.ozlabs.org > Cc: linux-arm-kernel@lists.infradead.org > Cc: linux-soc@vger.kernel.org > Signed-off-by: Rob Herring <robh@kernel.org> > --- > drivers/soc/dove/pmu.c | 8 +++--- > drivers/soc/fsl/qe/qe_tdm.c | 4 +-- > drivers/soc/qcom/apr.c | 2 +- > drivers/soc/rockchip/pm_domains.c | 44 +++++++++++++++---------------- > drivers/soc/tegra/pmc.c | 12 ++++----- > drivers/soc/ti/knav_dma.c | 8 +++--- > drivers/soc/ti/knav_qmss_queue.c | 8 +++--- > 7 files changed, 43 insertions(+), 43 deletions(-) Acked-by: Thierry Reding <treding@nvidia.com>
* Rob Herring <robh@kernel.org> [180828 01:58]: > In preparation to remove the node name pointer from struct device_node, > convert printf users to use the %pOFn format specifier. ... > drivers/memory/omap-gpmc.c | 18 +++++++----------- Looks good to me: Acked-by: Tony Lindgren <tony@atomide.com>
* Rob Herring <robh@kernel.org> [180828 01:59]: > In preparation to remove the node name pointer from struct device_node, > convert printf users to use the %pOFn format specifier. ... > drivers/pinctrl/pinctrl-single.c | 32 +++++++++---------- > drivers/pinctrl/ti/pinctrl-ti-iodelay.c | 8 ++--- Acked-by: Tony Lindgren <tony@atomide.com>
On Mon, Aug 27, 2018 at 08:52:39PM -0500, Rob Herring wrote: > In preparation to remove the node name pointer from struct device_node, > convert printf users to use the %pOFn format specifier. > > Cc: Will Deacon <will.deacon@arm.com> > Cc: Mark Rutland <mark.rutland@arm.com> > Cc: linux-arm-kernel@lists.infradead.org > Signed-off-by: Rob Herring <robh@kernel.org> > --- > drivers/perf/arm_pmu_platform.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) Cheers, I can queue this up for 4.20. Let me know if you'd rather take it along with the name pointer removal instead. Will > diff --git a/drivers/perf/arm_pmu_platform.c b/drivers/perf/arm_pmu_platform.c > index 96075cecb0ae..933bd8410fc2 100644 > --- a/drivers/perf/arm_pmu_platform.c > +++ b/drivers/perf/arm_pmu_platform.c > @@ -77,14 +77,14 @@ static int pmu_parse_irq_affinity(struct device_node *node, int i) > > dn = of_parse_phandle(node, "interrupt-affinity", i); > if (!dn) { > - pr_warn("failed to parse interrupt-affinity[%d] for %s\n", > - i, node->name); > + pr_warn("failed to parse interrupt-affinity[%d] for %pOFn\n", > + i, node); > return -EINVAL; > } > > cpu = of_cpu_node_to_id(dn); > if (cpu < 0) { > - pr_warn("failed to find logical CPU for %s\n", dn->name); > + pr_warn("failed to find logical CPU for %pOFn\n", dn); > cpu = nr_cpu_ids; > } > > -- > 2.17.1 >
On Mon, Aug 27, 2018 at 8:57 PM Rob Herring <robh@kernel.org> wrote: > > In preparation to remove the node name pointer from struct device_node, > convert printf users to use the %pOFn format specifier. Please forgive my ignorance, but what is this format specifier do exactly? I cannot find anything listed in the printf specification matching this. Is this something newly introduced? Leo
On 08/28/2018 11:48 AM, Li Yang wrote: > On Mon, Aug 27, 2018 at 8:57 PM Rob Herring <robh@kernel.org> wrote: >> >> In preparation to remove the node name pointer from struct device_node, >> convert printf users to use the %pOFn format specifier. > > Please forgive my ignorance, but what is this format specifier do > exactly? I cannot find anything listed in the printf specification > matching this. Is this something newly introduced? > > Leo > >From Documentation/core-api/printk-formats.rst: kobjects -------- :: %pOF[fnpPcCF] For printing kobject based structs (device nodes). Default behaviour is equivalent to %pOFf. - f - device node full_name - n - device node name - p - device node phandle - P - device node path spec (name + @unit) - F - device node flags - c - major compatible string - C - full compatible string -Tyrel
On Tue, Aug 28, 2018 at 5:16 PM Tyrel Datwyler <tyreld@linux.vnet.ibm.com> wrote: > > On 08/28/2018 11:48 AM, Li Yang wrote: > > On Mon, Aug 27, 2018 at 8:57 PM Rob Herring <robh@kernel.org> wrote: > >> > >> In preparation to remove the node name pointer from struct device_node, > >> convert printf users to use the %pOFn format specifier. > > > > Please forgive my ignorance, but what is this format specifier do > > exactly? I cannot find anything listed in the printf specification > > matching this. Is this something newly introduced? > > > > Leo > > > > From Documentation/core-api/printk-formats.rst: I was trying to find it in the standard c format specifier. :( Thanks a lot for the pointer. > > kobjects > -------- > > :: > > %pOF[fnpPcCF] > > > For printing kobject based structs (device nodes). Default behaviour is > equivalent to %pOFf. > > - f - device node full_name > - n - device node name > - p - device node phandle > - P - device node path spec (name + @unit) > - F - device node flags > - c - major compatible string > - C - full compatible string > > > -Tyrel >
On 08/28/2018 03:29 PM, Li Yang wrote: > On Tue, Aug 28, 2018 at 5:16 PM Tyrel Datwyler > <tyreld@linux.vnet.ibm.com> wrote: >> >> On 08/28/2018 11:48 AM, Li Yang wrote: >>> On Mon, Aug 27, 2018 at 8:57 PM Rob Herring <robh@kernel.org> wrote: >>>> >>>> In preparation to remove the node name pointer from struct device_node, >>>> convert printf users to use the %pOFn format specifier. >>> >>> Please forgive my ignorance, but what is this format specifier do >>> exactly? I cannot find anything listed in the printf specification >>> matching this. Is this something newly introduced? >>> >>> Leo >>> >> >> From Documentation/core-api/printk-formats.rst: > > I was trying to find it in the standard c format specifier. :( > Thanks a lot for the pointer. > No problem. Its worth a look through. The usual integer types are at the top, but that is followed by the pointer types which the kernel provides quite a few for a variety of things. >> >> kobjects >> -------- >> >> :: >> >> %pOF[fnpPcCF] >> >> >> For printing kobject based structs (device nodes). Default behaviour is >> equivalent to %pOFf. >> >> - f - device node full_name >> - n - device node name >> - p - device node phandle >> - P - device node path spec (name + @unit) >> - F - device node flags >> - c - major compatible string >> - C - full compatible string >> >> >> -Tyrel >> >
> Dear Rob, > > On 2018년 08월 28일 10:52, Rob Herring wrote: > > In preparation to remove the node name pointer from struct device_node, > > convert printf users to use the %pOFn format specifier. > > > > Cc: Chanwoo Choi <cw00.choi@samsung.com> > > Cc: MyungJoo Ham <myungjoo.ham@samsung.com> > > Cc: Kyungmin Park <kyungmin.park@samsung.com> > > Cc: Kukjin Kim <kgene@kernel.org> > > Cc: Krzysztof Kozlowski <krzk@kernel.org> > > Cc: linux-pm@vger.kernel.org > > Cc: linux-arm-kernel@lists.infradead.org > > Cc: linux-samsung-soc@vger.kernel.org > > Signed-off-by: Rob Herring <robh@kernel.org> > > --- > > drivers/devfreq/event/exynos-ppmu.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > [] > > Acked-by: Chanwoo Choi <cw00.choi@samsung.com> Acked-by: MyungJoo Ham <myungjoo.ham@samsung.com>
On Mon, 2018-08-27 at 20:52 -0500, Rob Herring wrote: > In preparation to remove the node name pointer from struct device_node, > convert printf users to use the %pOFn format specifier. > > Cc: Linus Walleij <linus.walleij@linaro.org> > Cc: Dong Aisheng <aisheng.dong@nxp.com> > Cc: Fabio Estevam <festevam@gmail.com> > Cc: Shawn Guo <shawnguo@kernel.org> > Cc: Stefan Agner <stefan@agner.ch> > Cc: Pengutronix Kernel Team <kernel@pengutronix.de> > Cc: Sean Wang <sean.wang@mediatek.com> > Cc: Matthias Brugger <matthias.bgg@gmail.com> > Cc: Carlo Caione <carlo@caione.org> > Cc: Kevin Hilman <khilman@baylibre.com> > Cc: Jason Cooper <jason@lakedaemon.net> > Cc: Andrew Lunn <andrew@lunn.ch> > Cc: Gregory Clement <gregory.clement@bootlin.com> > Cc: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com> > Cc: Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com> > Cc: Nicolas Ferre <nicolas.ferre@microchip.com> > Cc: Alexandre Belloni <alexandre.belloni@bootlin.com> > Cc: Heiko Stuebner <heiko@sntech.de> > Cc: Tony Lindgren <tony@atomide.com> > Cc: Haojian Zhuang <haojian.zhuang@linaro.org> > Cc: Patrice Chotard <patrice.chotard@st.com> > Cc: Barry Song <baohua@kernel.org> > Cc: Maxime Coquelin <mcoquelin.stm32@gmail.com> > Cc: Alexandre Torgue <alexandre.torgue@st.com> > Cc: Maxime Ripard <maxime.ripard@bootlin.com> > Cc: Chen-Yu Tsai <wens@csie.org> > Cc: linux-gpio@vger.kernel.org > Cc: linux-mediatek@lists.infradead.org > Cc: linux-arm-kernel@lists.infradead.org > Cc: linux-amlogic@lists.infradead.org > Cc: linux-rockchip@lists.infradead.org > Cc: linux-omap@vger.kernel.org > Signed-off-by: Rob Herring <robh@kernel.org> > --- > drivers/pinctrl/berlin/berlin.c | 6 ++-- > drivers/pinctrl/freescale/pinctrl-imx.c | 7 ++-- > drivers/pinctrl/freescale/pinctrl-imx1-core.c | 12 +++---- > drivers/pinctrl/mediatek/pinctrl-mtk-common.c | 4 +-- For mediatek, Acked-by: Sean Wang <sean.wang@mediatek.com>
On Tue, Aug 28, 2018 at 9:55 AM Rob Herring <robh@kernel.org> wrote: > > In preparation to remove the node name pointer from struct device_node, > convert printf users to use the %pOFn format specifier. > > Cc: Linus Walleij <linus.walleij@linaro.org> > Cc: Dong Aisheng <aisheng.dong@nxp.com> > Cc: Fabio Estevam <festevam@gmail.com> > Cc: Shawn Guo <shawnguo@kernel.org> > Cc: Stefan Agner <stefan@agner.ch> > Cc: Pengutronix Kernel Team <kernel@pengutronix.de> > Cc: Sean Wang <sean.wang@mediatek.com> > Cc: Matthias Brugger <matthias.bgg@gmail.com> > Cc: Carlo Caione <carlo@caione.org> > Cc: Kevin Hilman <khilman@baylibre.com> > Cc: Jason Cooper <jason@lakedaemon.net> > Cc: Andrew Lunn <andrew@lunn.ch> > Cc: Gregory Clement <gregory.clement@bootlin.com> > Cc: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com> > Cc: Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com> > Cc: Nicolas Ferre <nicolas.ferre@microchip.com> > Cc: Alexandre Belloni <alexandre.belloni@bootlin.com> > Cc: Heiko Stuebner <heiko@sntech.de> > Cc: Tony Lindgren <tony@atomide.com> > Cc: Haojian Zhuang <haojian.zhuang@linaro.org> > Cc: Patrice Chotard <patrice.chotard@st.com> > Cc: Barry Song <baohua@kernel.org> > Cc: Maxime Coquelin <mcoquelin.stm32@gmail.com> > Cc: Alexandre Torgue <alexandre.torgue@st.com> > Cc: Maxime Ripard <maxime.ripard@bootlin.com> > Cc: Chen-Yu Tsai <wens@csie.org> > Cc: linux-gpio@vger.kernel.org > Cc: linux-mediatek@lists.infradead.org > Cc: linux-arm-kernel@lists.infradead.org > Cc: linux-amlogic@lists.infradead.org > Cc: linux-rockchip@lists.infradead.org > Cc: linux-omap@vger.kernel.org > Signed-off-by: Rob Herring <robh@kernel.org> > --- > drivers/pinctrl/berlin/berlin.c | 6 ++-- > drivers/pinctrl/freescale/pinctrl-imx.c | 7 ++-- > drivers/pinctrl/freescale/pinctrl-imx1-core.c | 12 +++---- > drivers/pinctrl/mediatek/pinctrl-mtk-common.c | 4 +-- > drivers/pinctrl/meson/pinctrl-meson.c | 2 +- > drivers/pinctrl/mvebu/pinctrl-mvebu.c | 4 +-- > drivers/pinctrl/nomadik/pinctrl-nomadik.c | 6 ++-- > drivers/pinctrl/pinctrl-at91.c | 8 ++--- > drivers/pinctrl/pinctrl-lantiq.c | 8 ++--- > drivers/pinctrl/pinctrl-rockchip.c | 8 ++--- > drivers/pinctrl/pinctrl-rza1.c | 8 ++--- > drivers/pinctrl/pinctrl-single.c | 32 +++++++++---------- > drivers/pinctrl/pinctrl-st.c | 6 ++-- > drivers/pinctrl/sirf/pinctrl-atlas7.c | 4 +-- > drivers/pinctrl/stm32/pinctrl-stm32.c | 4 +-- > drivers/pinctrl/sunxi/pinctrl-sunxi.c | 8 ++--- For sunxi: Acked-by: Chen-Yu Tsai <wens@csie.org>
On Tue, 28 Aug 2018 at 03:54, Rob Herring <robh@kernel.org> wrote: > > In preparation to remove the node name pointer from struct device_node, > convert printf users to use the %pOFn format specifier. > > Cc: Roger Quadros <rogerq@ti.com> > Cc: Tony Lindgren <tony@atomide.com> > Cc: Kukjin Kim <kgene@kernel.org> > Cc: Krzysztof Kozlowski <krzk@kernel.org> > Cc: Thierry Reding <thierry.reding@gmail.com> > Cc: Jonathan Hunter <jonathanh@nvidia.com> > Cc: linux-omap@vger.kernel.org > Cc: linux-arm-kernel@lists.infradead.org > Cc: linux-samsung-soc@vger.kernel.org > Cc: linux-tegra@vger.kernel.org > Signed-off-by: Rob Herring <robh@kernel.org> > --- > drivers/memory/omap-gpmc.c | 18 +++++++----------- > drivers/memory/samsung/exynos-srom.c | 4 ++-- For Samsung: Acked-by: Krzysztof Kozlowski <krzk@kernel.org> Best regards, Krzysztof
Am Dienstag, 28. August 2018, 03:52:44 CEST schrieb Rob Herring: > In preparation to remove the node name pointer from struct device_node, > convert printf users to use the %pOFn format specifier. > drivers/soc/rockchip/pm_domains.c | 44 +++++++++++++++---------------- For the Rockchip-part Acked-by: Heiko Stuebner <heiko@sntech.de>
Am Dienstag, 28. August 2018, 03:52:41 CEST schrieb Rob Herring: > In preparation to remove the node name pointer from struct device_node, > convert printf users to use the %pOFn format specifier. > drivers/pinctrl/pinctrl-rockchip.c | 8 ++--- For the Rockchip-part Acked-by: Heiko Stuebner <heiko@sntech.de>
From: Rob Herring <robh@kernel.org> Date: 2018年8月28日 9:53 > To: linux-kernel@vger.kernel.org > Cc: Qiang Zhao <qiang.zhao@nxp.com>; Leo Li <leoyang.li@nxp.com>; Andy > Gross <andy.gross@linaro.org>; David Brown <david.brown@linaro.org>; Heiko > Stuebner <heiko@sntech.de>; Thierry Reding <thierry.reding@gmail.com>; > Jonathan Hunter <jonathanh@nvidia.com>; Santosh Shilimkar > <ssantosh@kernel.org>; linuxppc-dev@lists.ozlabs.org; > linux-arm-kernel@lists.infradead.org; linux-soc@vger.kernel.org > Subject: [PATCH] soc: Convert to using %pOFn instead of device_node.name > > In preparation to remove the node name pointer from struct device_node, > convert printf users to use the %pOFn format specifier. > > Cc: Qiang Zhao <qiang.zhao@nxp.com> > Cc: Li Yang <leoyang.li@nxp.com> > Cc: Andy Gross <andy.gross@linaro.org> > Cc: David Brown <david.brown@linaro.org> > Cc: Heiko Stuebner <heiko@sntech.de> > Cc: Thierry Reding <thierry.reding@gmail.com> > Cc: Jonathan Hunter <jonathanh@nvidia.com> > Cc: Santosh Shilimkar <ssantosh@kernel.org> > Cc: linuxppc-dev@lists.ozlabs.org > Cc: linux-arm-kernel@lists.infradead.org > Cc: linux-soc@vger.kernel.org > Signed-off-by: Rob Herring <robh@kernel.org> > --- > drivers/soc/dove/pmu.c | 8 +++--- > drivers/soc/fsl/qe/qe_tdm.c | 4 +-- > drivers/soc/qcom/apr.c | 2 +- > drivers/soc/rockchip/pm_domains.c | 44 +++++++++++++++---------------- > drivers/soc/tegra/pmc.c | 12 ++++----- > drivers/soc/ti/knav_dma.c | 8 +++--- > drivers/soc/ti/knav_qmss_queue.c | 8 +++--- > 7 files changed, 43 insertions(+), 43 deletions(-) For qe_tdm part Acked-by: Qiang Zhao <qiang.zhao@nxp.com>
On Tue, Aug 28, 2018 at 3:55 AM Rob Herring <robh@kernel.org> wrote: > In preparation to remove the node name pointer from struct device_node, > convert printf users to use the %pOFn format specifier. > > Cc: Linus Walleij <linus.walleij@linaro.org> Patch applied along with the thundering hoard of ACKs. Yours, Linus Walleij
On 28/08/2018 03:52, Rob Herring wrote: > In preparation to remove the node name pointer from struct device_node, > convert printf users to use the %pOFn format specifier. > > Cc: Daniel Lezcano <daniel.lezcano@linaro.org> > Cc: Thomas Gleixner <tglx@linutronix.de> > Cc: Michal Simek <michal.simek@xilinx.com> > Cc: linux-arm-kernel@lists.infradead.org > Signed-off-by: Rob Herring <robh@kernel.org> > --- Applied for 4.20 Thanks! -- Daniel
On Tue, Aug 28, 2018 at 09:24:20AM +0200, Geert Uytterhoeven wrote: > On Tue, Aug 28, 2018 at 3:54 AM Rob Herring <robh@kernel.org> wrote: > > In preparation to remove the node name pointer from struct device_node, > > convert printf users to use the %pOFn format specifier. > > > > Cc: Simon Horman <horms@verge.net.au> > > Cc: Magnus Damm <magnus.damm@gmail.com> > > Cc: linux-arm-kernel@lists.infradead.org > > Cc: linux-renesas-soc@vger.kernel.org > > Signed-off-by: Rob Herring <robh@kernel.org> > > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> Thanks Rob, thanks Geert, applied for v4.20.
On Tue, Aug 28, 2018 at 9:53 AM Rob Herring <robh@kernel.org> wrote: > > In preparation to remove the node name pointer from struct device_node, > convert printf users to use the %pOFn format specifier. > > Cc: Eugeniy Paltsev <Eugeniy.Paltsev@synopsys.com> > Cc: Michael Turquette <mturquette@baylibre.com> > Cc: Stephen Boyd <sboyd@kernel.org> > Cc: linux-clk@vger.kernel.org > Cc: linux-arm-kernel@lists.infradead.org > Cc: linux-renesas-soc@vger.kernel.org > Cc: linux-omap@vger.kernel.org > Signed-off-by: Rob Herring <robh@kernel.org> > --- > drivers/clk/sunxi/clk-mod0.c | 6 +++--- > drivers/clk/sunxi/clk-sun9i-core.c | 20 ++++++++++---------- > drivers/clk/sunxi/clk-sunxi.c | 4 ++-- For the sunxi bits, Acked-by: Chen-Yu Tsai <wens@csie.org>
On 27-08-18, 20:52, Rob Herring wrote: > In preparation to remove the node name pointer from struct device_node, > convert printf users to use the %pOFn format specifier. > > Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net> > Cc: Viresh Kumar <viresh.kumar@linaro.org> > Cc: linux-arm-kernel@lists.infradead.org > Cc: linux-samsung-soc@vger.kernel.org > Cc: linux-pm@vger.kernel.org > Signed-off-by: Rob Herring <robh@kernel.org> > --- > drivers/cpufreq/s5pv210-cpufreq.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/cpufreq/s5pv210-cpufreq.c b/drivers/cpufreq/s5pv210-cpufreq.c > index 5d31c2db12a3..dbecd7667db2 100644 > --- a/drivers/cpufreq/s5pv210-cpufreq.c > +++ b/drivers/cpufreq/s5pv210-cpufreq.c > @@ -611,8 +611,8 @@ static int s5pv210_cpufreq_probe(struct platform_device *pdev) > for_each_compatible_node(np, NULL, "samsung,s5pv210-dmc") { > id = of_alias_get_id(np, "dmc"); > if (id < 0 || id >= ARRAY_SIZE(dmc_base)) { > - pr_err("%s: failed to get alias of dmc node '%s'\n", > - __func__, np->name); > + pr_err("%s: failed to get alias of dmc node '%pOFn'\n", > + __func__, np); > of_node_put(np); > return id; > } Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
Hi Rob On 08/28/2018 03:52 AM, Rob Herring wrote: > In preparation to remove the node name pointer from struct device_node, > convert printf users to use the %pOFn format specifier. > > Cc: Linus Walleij <linus.walleij@linaro.org> > Cc: Dong Aisheng <aisheng.dong@nxp.com> > Cc: Fabio Estevam <festevam@gmail.com> > Cc: Shawn Guo <shawnguo@kernel.org> > Cc: Stefan Agner <stefan@agner.ch> > Cc: Pengutronix Kernel Team <kernel@pengutronix.de> > Cc: Sean Wang <sean.wang@mediatek.com> > Cc: Matthias Brugger <matthias.bgg@gmail.com> > Cc: Carlo Caione <carlo@caione.org> > Cc: Kevin Hilman <khilman@baylibre.com> > Cc: Jason Cooper <jason@lakedaemon.net> > Cc: Andrew Lunn <andrew@lunn.ch> > Cc: Gregory Clement <gregory.clement@bootlin.com> > Cc: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com> > Cc: Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com> > Cc: Nicolas Ferre <nicolas.ferre@microchip.com> > Cc: Alexandre Belloni <alexandre.belloni@bootlin.com> > Cc: Heiko Stuebner <heiko@sntech.de> > Cc: Tony Lindgren <tony@atomide.com> > Cc: Haojian Zhuang <haojian.zhuang@linaro.org> > Cc: Patrice Chotard <patrice.chotard@st.com> > Cc: Barry Song <baohua@kernel.org> > Cc: Maxime Coquelin <mcoquelin.stm32@gmail.com> > Cc: Alexandre Torgue <alexandre.torgue@st.com> > Cc: Maxime Ripard <maxime.ripard@bootlin.com> > Cc: Chen-Yu Tsai <wens@csie.org> > Cc: linux-gpio@vger.kernel.org > Cc: linux-mediatek@lists.infradead.org > Cc: linux-arm-kernel@lists.infradead.org > Cc: linux-amlogic@lists.infradead.org > Cc: linux-rockchip@lists.infradead.org > Cc: linux-omap@vger.kernel.org > Signed-off-by: Rob Herring <robh@kernel.org> > --- > drivers/pinctrl/berlin/berlin.c | 6 ++-- > drivers/pinctrl/freescale/pinctrl-imx.c | 7 ++-- > drivers/pinctrl/freescale/pinctrl-imx1-core.c | 12 +++---- > drivers/pinctrl/mediatek/pinctrl-mtk-common.c | 4 +-- > drivers/pinctrl/meson/pinctrl-meson.c | 2 +- > drivers/pinctrl/mvebu/pinctrl-mvebu.c | 4 +-- > drivers/pinctrl/nomadik/pinctrl-nomadik.c | 6 ++-- > drivers/pinctrl/pinctrl-at91.c | 8 ++--- > drivers/pinctrl/pinctrl-lantiq.c | 8 ++--- > drivers/pinctrl/pinctrl-rockchip.c | 8 ++--- > drivers/pinctrl/pinctrl-rza1.c | 8 ++--- > drivers/pinctrl/pinctrl-single.c | 32 +++++++++---------- > drivers/pinctrl/pinctrl-st.c | 6 ++-- > drivers/pinctrl/sirf/pinctrl-atlas7.c | 4 +-- > drivers/pinctrl/stm32/pinctrl-stm32.c | 4 +-- > drivers/pinctrl/sunxi/pinctrl-sunxi.c | 8 ++--- > drivers/pinctrl/ti/pinctrl-ti-iodelay.c | 8 ++--- > 17 files changed, 66 insertions(+), 69 deletions(-) > > diff --git a/drivers/pinctrl/pinctrl-st.c b/drivers/pinctrl/pinctrl-st.c > index 0966bb0bf71f..e66af93f2cbf 100644 > --- a/drivers/pinctrl/pinctrl-st.c > +++ b/drivers/pinctrl/pinctrl-st.c > @@ -817,8 +817,8 @@ static int st_pctl_dt_node_to_map(struct pinctrl_dev *pctldev, > > grp = st_pctl_find_group_by_name(info, np->name); > if (!grp) { > - dev_err(info->dev, "unable to find group for node %s\n", > - np->name); > + dev_err(info->dev, "unable to find group for node %pOFn\n", > + np); > return -EINVAL; > } > > @@ -1184,7 +1184,7 @@ static int st_pctl_dt_parse_groups(struct device_node *np, > if (pp->length / sizeof(__be32) >= OF_GPIO_ARGS_MIN) { > npins++; > } else { > - pr_warn("Invalid st,pins in %s node\n", np->name); > + pr_warn("Invalid st,pins in %pOFn node\n", np); > return -EINVAL; > } > } For pinctrl-st: Acked-by: Patrice Chotard <patrice.chotard@st.com> Thanks Patrice
Hi Rob, On Tuesday 28 August 2018 07:22 AM, Rob Herring wrote: > In preparation to remove the node name pointer from struct device_node, > convert printf users to use the %pOFn format specifier. I assume it should be okay to get this merged in the next merge window? Thanks Kishon > > Cc: Kishon Vijay Abraham I <kishon@ti.com> > Cc: linux-arm-kernel@lists.infradead.org > Signed-off-by: Rob Herring <robh@kernel.org> > --- > drivers/phy/broadcom/phy-bcm-cygnus-pcie.c | 4 ++-- > drivers/phy/broadcom/phy-brcm-sata.c | 4 ++-- > drivers/phy/marvell/phy-berlin-sata.c | 6 +++--- > drivers/phy/qualcomm/phy-qcom-qmp.c | 2 +- > drivers/phy/rockchip/phy-rockchip-emmc.c | 4 ++-- > drivers/phy/rockchip/phy-rockchip-inno-usb2.c | 8 ++++---- > drivers/phy/rockchip/phy-rockchip-typec.c | 8 ++++---- > drivers/phy/rockchip/phy-rockchip-usb.c | 4 ++-- > drivers/phy/tegra/xusb.c | 4 ++-- > 9 files changed, 22 insertions(+), 22 deletions(-) > > diff --git a/drivers/phy/broadcom/phy-bcm-cygnus-pcie.c b/drivers/phy/broadcom/phy-bcm-cygnus-pcie.c > index 0f4ac5d63cff..b074682d9dd8 100644 > --- a/drivers/phy/broadcom/phy-bcm-cygnus-pcie.c > +++ b/drivers/phy/broadcom/phy-bcm-cygnus-pcie.c > @@ -153,8 +153,8 @@ static int cygnus_pcie_phy_probe(struct platform_device *pdev) > struct cygnus_pcie_phy *p; > > if (of_property_read_u32(child, "reg", &id)) { > - dev_err(dev, "missing reg property for %s\n", > - child->name); > + dev_err(dev, "missing reg property for %pOFn\n", > + child); > ret = -EINVAL; > goto put_child; > } > diff --git a/drivers/phy/broadcom/phy-brcm-sata.c b/drivers/phy/broadcom/phy-brcm-sata.c > index 8708ea3b4d6d..ac57f5a41708 100644 > --- a/drivers/phy/broadcom/phy-brcm-sata.c > +++ b/drivers/phy/broadcom/phy-brcm-sata.c > @@ -600,8 +600,8 @@ static int brcm_sata_phy_probe(struct platform_device *pdev) > struct brcm_sata_port *port; > > if (of_property_read_u32(child, "reg", &id)) { > - dev_err(dev, "missing reg property in node %s\n", > - child->name); > + dev_err(dev, "missing reg property in node %pOFn\n", > + child); > ret = -EINVAL; > goto put_child; > } > diff --git a/drivers/phy/marvell/phy-berlin-sata.c b/drivers/phy/marvell/phy-berlin-sata.c > index c1bb6725e48f..a91fc67fc4e0 100644 > --- a/drivers/phy/marvell/phy-berlin-sata.c > +++ b/drivers/phy/marvell/phy-berlin-sata.c > @@ -231,14 +231,14 @@ static int phy_berlin_sata_probe(struct platform_device *pdev) > struct phy_berlin_desc *phy_desc; > > if (of_property_read_u32(child, "reg", &phy_id)) { > - dev_err(dev, "missing reg property in node %s\n", > - child->name); > + dev_err(dev, "missing reg property in node %pOFn\n", > + child); > ret = -EINVAL; > goto put_child; > } > > if (phy_id >= ARRAY_SIZE(phy_berlin_power_down_bits)) { > - dev_err(dev, "invalid reg in node %s\n", child->name); > + dev_err(dev, "invalid reg in node %pOFn\n", child); > ret = -EINVAL; > goto put_child; > } > diff --git a/drivers/phy/qualcomm/phy-qcom-qmp.c b/drivers/phy/qualcomm/phy-qcom-qmp.c > index 4c470104a0d6..baa59484a90c 100644 > --- a/drivers/phy/qualcomm/phy-qcom-qmp.c > +++ b/drivers/phy/qualcomm/phy-qcom-qmp.c > @@ -1400,7 +1400,7 @@ static int phy_pipe_clk_register(struct qcom_qmp *qmp, struct device_node *np) > > ret = of_property_read_string(np, "clock-output-names", &init.name); > if (ret) { > - dev_err(qmp->dev, "%s: No clock-output-names\n", np->name); > + dev_err(qmp->dev, "%pOFn: No clock-output-names\n", np); > return ret; > } > > diff --git a/drivers/phy/rockchip/phy-rockchip-emmc.c b/drivers/phy/rockchip/phy-rockchip-emmc.c > index b237360f95f6..19bf84f0bc67 100644 > --- a/drivers/phy/rockchip/phy-rockchip-emmc.c > +++ b/drivers/phy/rockchip/phy-rockchip-emmc.c > @@ -337,8 +337,8 @@ static int rockchip_emmc_phy_probe(struct platform_device *pdev) > return -ENOMEM; > > if (of_property_read_u32(dev->of_node, "reg", ®_offset)) { > - dev_err(dev, "missing reg property in node %s\n", > - dev->of_node->name); > + dev_err(dev, "missing reg property in node %pOFn\n", > + dev->of_node); > return -EINVAL; > } > > diff --git a/drivers/phy/rockchip/phy-rockchip-inno-usb2.c b/drivers/phy/rockchip/phy-rockchip-inno-usb2.c > index 5049dac79bd0..24bd2717abdb 100644 > --- a/drivers/phy/rockchip/phy-rockchip-inno-usb2.c > +++ b/drivers/phy/rockchip/phy-rockchip-inno-usb2.c > @@ -1116,8 +1116,8 @@ static int rockchip_usb2phy_probe(struct platform_device *pdev) > } > > if (of_property_read_u32(np, "reg", ®)) { > - dev_err(dev, "the reg property is not assigned in %s node\n", > - np->name); > + dev_err(dev, "the reg property is not assigned in %pOFn node\n", > + np); > return -EINVAL; > } > > @@ -1143,8 +1143,8 @@ static int rockchip_usb2phy_probe(struct platform_device *pdev) > } > > if (!rphy->phy_cfg) { > - dev_err(dev, "no phy-config can be matched with %s node\n", > - np->name); > + dev_err(dev, "no phy-config can be matched with %pOFn node\n", > + np); > return -EINVAL; > } > > diff --git a/drivers/phy/rockchip/phy-rockchip-typec.c b/drivers/phy/rockchip/phy-rockchip-typec.c > index 76a4b58ec771..c57e496f0b0c 100644 > --- a/drivers/phy/rockchip/phy-rockchip-typec.c > +++ b/drivers/phy/rockchip/phy-rockchip-typec.c > @@ -1145,8 +1145,8 @@ static int rockchip_typec_phy_probe(struct platform_device *pdev) > } > > if (!tcphy->port_cfgs) { > - dev_err(dev, "no phy-config can be matched with %s node\n", > - np->name); > + dev_err(dev, "no phy-config can be matched with %pOFn node\n", > + np); > return -EINVAL; > } > > @@ -1186,8 +1186,8 @@ static int rockchip_typec_phy_probe(struct platform_device *pdev) > continue; > > if (IS_ERR(phy)) { > - dev_err(dev, "failed to create phy: %s\n", > - child_np->name); > + dev_err(dev, "failed to create phy: %pOFn\n", > + child_np); > pm_runtime_disable(dev); > return PTR_ERR(phy); > } > diff --git a/drivers/phy/rockchip/phy-rockchip-usb.c b/drivers/phy/rockchip/phy-rockchip-usb.c > index 3378eeb7a562..269c86329cb8 100644 > --- a/drivers/phy/rockchip/phy-rockchip-usb.c > +++ b/drivers/phy/rockchip/phy-rockchip-usb.c > @@ -208,8 +208,8 @@ static int rockchip_usb_phy_init(struct rockchip_usb_phy_base *base, > rk_phy->np = child; > > if (of_property_read_u32(child, "reg", ®_offset)) { > - dev_err(base->dev, "missing reg property in node %s\n", > - child->name); > + dev_err(base->dev, "missing reg property in node %pOFn\n", > + child); > return -EINVAL; > } > > diff --git a/drivers/phy/tegra/xusb.c b/drivers/phy/tegra/xusb.c > index de1b4ebe4de2..5b3b8863363e 100644 > --- a/drivers/phy/tegra/xusb.c > +++ b/drivers/phy/tegra/xusb.c > @@ -115,8 +115,8 @@ int tegra_xusb_lane_parse_dt(struct tegra_xusb_lane *lane, > > err = match_string(lane->soc->funcs, lane->soc->num_funcs, function); > if (err < 0) { > - dev_err(dev, "invalid function \"%s\" for lane \"%s\"\n", > - function, np->name); > + dev_err(dev, "invalid function \"%s\" for lane \"%pOFn\"\n", > + function, np); > return err; > } > >
On Mon, Sep 3, 2018 at 9:24 PM Kishon Vijay Abraham I <kishon@ti.com> wrote: > > Hi Rob, > > On Tuesday 28 August 2018 07:22 AM, Rob Herring wrote: > > In preparation to remove the node name pointer from struct device_node, > > convert printf users to use the %pOFn format specifier. > > I assume it should be okay to get this merged in the next merge window? Yes, of course. Rob
On 28.8.2018 03:52, Rob Herring wrote: > In preparation to remove the node name pointer from struct device_node, > convert printf users to use the %pOFn format specifier. > > Cc: Michal Simek <michal.simek@xilinx.com> > Cc: linux-arm-kernel@lists.infradead.org > Signed-off-by: Rob Herring <robh@kernel.org> > --- > arch/arm/mach-zynq/slcr.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm/mach-zynq/slcr.c b/arch/arm/mach-zynq/slcr.c > index f0292a30e6f6..10ef99ce1d90 100644 > --- a/arch/arm/mach-zynq/slcr.c > +++ b/arch/arm/mach-zynq/slcr.c > @@ -233,7 +233,7 @@ int __init zynq_early_slcr_init(void) > > register_restart_handler(&zynq_slcr_restart_nb); > > - pr_info("%s mapped to %p\n", np->name, zynq_slcr_base); > + pr_info("%pOFn mapped to %p\n", np, zynq_slcr_base); > > of_node_put(np); > > Applied. M
On Mon, Aug 27, 2018 at 8:53 PM Rob Herring <robh@kernel.org> wrote: > > In preparation to remove the node name pointer from struct device_node, > convert printf users to use the %pOFn format specifier. > @@ -492,8 +492,7 @@ static void __init _ti_omap4_clkctrl_setup(struct device_node *node) > > provider->base = of_iomap(node, 0); > > - provider->clkdm_name = kmalloc(strlen(node->parent->name) + 3, > - GFP_KERNEL); > + provider->clkdm_name = kasprintf(GFP_KERNEL, "%pOFnxxx", node->parent); Turns out xxx was a bad choice as the %p handler eats all alphanumeric characters. Looks like this has already been applied, so I will send a fix. Rob
On Mon, 27 Aug 2018, Rob Herring wrote: > In preparation to remove the node name pointer from struct device_node, > convert printf users to use the %pOFn format specifier. > > Cc: Thomas Gleixner <tglx@linutronix.de> > Cc: Jason Cooper <jason@lakedaemon.net> > Cc: Marc Zyngier <marc.zyngier@arm.com> > Cc: linux-arm-kernel@lists.infradead.org > Signed-off-by: Rob Herring <robh@kernel.org> Should I take it or do you want to take it with others? If the latter, acked-by-me. Thanks, tglx
On Sat, Sep 8, 2018 at 7:15 AM Thomas Gleixner <tglx@linutronix.de> wrote: > > On Mon, 27 Aug 2018, Rob Herring wrote: > > > In preparation to remove the node name pointer from struct device_node, > > convert printf users to use the %pOFn format specifier. > > > > Cc: Thomas Gleixner <tglx@linutronix.de> > > Cc: Jason Cooper <jason@lakedaemon.net> > > Cc: Marc Zyngier <marc.zyngier@arm.com> > > Cc: linux-arm-kernel@lists.infradead.org > > Signed-off-by: Rob Herring <robh@kernel.org> > > Should I take it or do you want to take it with others? If the latter, > acked-by-me. Please take it. There's no dependency. Rob
On Tuesday, August 28, 2018 3:52:15 AM CEST Rob Herring wrote: > In preparation to remove the node name pointer from struct device_node, > convert printf users to use the %pOFn format specifier. > > Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net> > Cc: Viresh Kumar <viresh.kumar@linaro.org> > Cc: linux-arm-kernel@lists.infradead.org > Cc: linux-samsung-soc@vger.kernel.org > Cc: linux-pm@vger.kernel.org > Signed-off-by: Rob Herring <robh@kernel.org> > --- > drivers/cpufreq/s5pv210-cpufreq.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/cpufreq/s5pv210-cpufreq.c b/drivers/cpufreq/s5pv210-cpufreq.c > index 5d31c2db12a3..dbecd7667db2 100644 > --- a/drivers/cpufreq/s5pv210-cpufreq.c > +++ b/drivers/cpufreq/s5pv210-cpufreq.c > @@ -611,8 +611,8 @@ static int s5pv210_cpufreq_probe(struct platform_device *pdev) > for_each_compatible_node(np, NULL, "samsung,s5pv210-dmc") { > id = of_alias_get_id(np, "dmc"); > if (id < 0 || id >= ARRAY_SIZE(dmc_base)) { > - pr_err("%s: failed to get alias of dmc node '%s'\n", > - __func__, np->name); > + pr_err("%s: failed to get alias of dmc node '%pOFn'\n", > + __func__, np); > of_node_put(np); > return id; > } > Applied, thanks!
On Tue, Aug 28, 2018 at 12:02 PM Will Deacon <will.deacon@arm.com> wrote: > > On Mon, Aug 27, 2018 at 08:52:39PM -0500, Rob Herring wrote: > > In preparation to remove the node name pointer from struct device_node, > > convert printf users to use the %pOFn format specifier. > > > > Cc: Will Deacon <will.deacon@arm.com> > > Cc: Mark Rutland <mark.rutland@arm.com> > > Cc: linux-arm-kernel@lists.infradead.org > > Signed-off-by: Rob Herring <robh@kernel.org> > > --- > > drivers/perf/arm_pmu_platform.c | 6 +++--- > > 1 file changed, 3 insertions(+), 3 deletions(-) > > Cheers, I can queue this up for 4.20. Let me know if you'd rather take it > along with the name pointer removal instead. I assumed you were going to take this since I didn't say otherwise, but looks like it is not in linux-next. Please take thru your tree. Rob
On Mon, Aug 27, 2018 at 08:52:44PM -0500, Rob Herring wrote: > In preparation to remove the node name pointer from struct device_node, > convert printf users to use the %pOFn format specifier. > > Cc: Qiang Zhao <qiang.zhao@nxp.com> > Cc: Li Yang <leoyang.li@nxp.com> > Cc: Andy Gross <andy.gross@linaro.org> > Cc: David Brown <david.brown@linaro.org> > Cc: Heiko Stuebner <heiko@sntech.de> > Cc: Thierry Reding <thierry.reding@gmail.com> > Cc: Jonathan Hunter <jonathanh@nvidia.com> > Cc: Santosh Shilimkar <ssantosh@kernel.org> > Cc: linuxppc-dev@lists.ozlabs.org > Cc: linux-arm-kernel@lists.infradead.org > Cc: linux-soc@vger.kernel.org > Signed-off-by: Rob Herring <robh@kernel.org> > --- Acked-by: Andy Gross <andy.gross@linaro.org>
On Fri, Sep 28, 2018 at 04:19:07PM -0500, Rob Herring wrote: > On Tue, Aug 28, 2018 at 12:02 PM Will Deacon <will.deacon@arm.com> wrote: > > > > On Mon, Aug 27, 2018 at 08:52:39PM -0500, Rob Herring wrote: > > > In preparation to remove the node name pointer from struct device_node, > > > convert printf users to use the %pOFn format specifier. > > > > > > Cc: Will Deacon <will.deacon@arm.com> > > > Cc: Mark Rutland <mark.rutland@arm.com> > > > Cc: linux-arm-kernel@lists.infradead.org > > > Signed-off-by: Rob Herring <robh@kernel.org> > > > --- > > > drivers/perf/arm_pmu_platform.c | 6 +++--- > > > 1 file changed, 3 insertions(+), 3 deletions(-) > > > > Cheers, I can queue this up for 4.20. Let me know if you'd rather take it > > along with the name pointer removal instead. > > I assumed you were going to take this since I didn't say otherwise, > but looks like it is not in linux-next. Please take thru your tree. Sorry, slipped through the cracks. I'll get it queued asap for the merge window. Will
diff --git a/arch/arm/mach-omap2/omap_hwmod.c b/arch/arm/mach-omap2/omap_hwmod.c index 2ceffd85dd3d..b5757646355a 100644 --- a/arch/arm/mach-omap2/omap_hwmod.c +++ b/arch/arm/mach-omap2/omap_hwmod.c @@ -738,7 +738,7 @@ static int __init _setup_clkctrl_provider(struct device_node *np) provider->size = size | 0xff; provider->node = np; - pr_debug("%s: %s: %x...%x [+%x]\n", __func__, np->parent->name, + pr_debug("%pOF: %s: %x...%x [+%x]\n", __func__, np->parent, provider->addr, provider->addr + provider->size, provider->offset); @@ -799,9 +799,9 @@ static struct clk *_lookup_clkctrl_clk(struct omap_hwmod *oh) clk = of_clk_get_from_provider(&clkspec); - pr_debug("%s: %s got %p (offset=%x, provider=%s)\n", + pr_debug("%s: %s got %p (offset=%x, provider=%pOFn)\n", __func__, oh->name, clk, clkspec.args[0], - provider->node->parent->name); + provider->node->parent); return clk; } @@ -2107,8 +2107,8 @@ static int of_dev_find_hwmod(struct device_node *np, if (res) continue; if (!strcmp(p, oh->name)) { - pr_debug("omap_hwmod: dt %s[%i] uses hwmod %s\n", - np->name, i, oh->name); + pr_debug("omap_hwmod: dt %pOFn[%i] uses hwmod %s\n", + np, i, oh->name); return i; } } @@ -2210,8 +2210,8 @@ int omap_hwmod_parse_module_range(struct omap_hwmod *oh, return -ENOENT; if (nr_addr != 1 || nr_size != 1) { - pr_err("%s: invalid range for %s->%s\n", __func__, - oh->name, np->name); + pr_err("%s: invalid range for %s->%pOFn\n", __func__, + oh->name, np); return -EINVAL; } @@ -2219,8 +2219,8 @@ int omap_hwmod_parse_module_range(struct omap_hwmod *oh, base = of_translate_address(np, ranges++); size = be32_to_cpup(ranges); - pr_debug("omap_hwmod: %s %s at 0x%llx size 0x%llx\n", - oh->name, np->name, base, size); + pr_debug("omap_hwmod: %s %pOFn at 0x%llx size 0x%llx\n", + oh->name, np, base, size); res->start = base; res->end = base + size - 1; @@ -2322,8 +2322,8 @@ static int __init _init(struct omap_hwmod *oh, void *data) if (r) pr_debug("omap_hwmod: %s missing dt data\n", oh->name); else if (np && index) - pr_warn("omap_hwmod: %s using broken dt data from %s\n", - oh->name, np->name); + pr_warn("omap_hwmod: %s using broken dt data from %pOFn\n", + oh->name, np); r = _init_mpu_rt_base(oh, NULL, index, np); if (r < 0) {
In preparation to remove the node name pointer from struct device_node, convert printf users to use the %pOFn format specifier. Cc: "Benoît Cousson" <bcousson@baylibre.com> Cc: Paul Walmsley <paul@pwsan.com> Cc: Tony Lindgren <tony@atomide.com> Cc: linux-omap@vger.kernel.org Cc: linux-arm-kernel@lists.infradead.org Signed-off-by: Rob Herring <robh@kernel.org> --- arch/arm/mach-omap2/omap_hwmod.c | 22 +++++++++++----------- 1 file changed, 11 insertions(+), 11 deletions(-)