diff mbox series

UBUNTU: snapcraft.yaml: skip non-existent firmware_install step

Message ID 1535633813-22414-2-git-send-email-paolo.pisati@canonical.com
State New
Headers show
Series UBUNTU: snapcraft.yaml: skip non-existent firmware_install step | expand

Commit Message

Paolo Pisati Aug. 30, 2018, 12:56 p.m. UTC
BugLink: https://bugs.launchpad.net/bugs/1789897

Signed-off-by: Paolo Pisati <paolo.pisati@canonical.com>
---
 snapcraft.yaml | 1 +
 1 file changed, 1 insertion(+)

Comments

Kleber Sacilotto de Souza Aug. 31, 2018, 9:01 a.m. UTC | #1
On 08/30/18 14:56, Paolo Pisati wrote:
> BugLink: https://bugs.launchpad.net/bugs/1789897
> 
> Signed-off-by: Paolo Pisati <paolo.pisati@canonical.com>

Acked-by: Kleber Sacilotto de Souza <kleber.souza@canonical.com>

> ---
>  snapcraft.yaml | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/snapcraft.yaml b/snapcraft.yaml
> index d1802df..0518010 100644
> --- a/snapcraft.yaml
> +++ b/snapcraft.yaml
> @@ -18,6 +18,7 @@ parts:
>      kconfigs:
>        - CONFIG_DEBUG_INFO=n
>      kernel-image-target: zImage
> +    kernel-with-firmware: false
>      override-build: |
>        cp debian/scripts/retpoline-extract-one \
>          $SNAPCRAFT_PART_BUILD/scripts/ubuntu-retpoline-extract-one
>
Colin Ian King Aug. 31, 2018, 9:03 a.m. UTC | #2
On 30/08/18 13:56, Paolo Pisati wrote:
> BugLink: https://bugs.launchpad.net/bugs/1789897
> 
> Signed-off-by: Paolo Pisati <paolo.pisati@canonical.com>
> ---
>  snapcraft.yaml | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/snapcraft.yaml b/snapcraft.yaml
> index d1802df..0518010 100644
> --- a/snapcraft.yaml
> +++ b/snapcraft.yaml
> @@ -18,6 +18,7 @@ parts:
>      kconfigs:
>        - CONFIG_DEBUG_INFO=n
>      kernel-image-target: zImage
> +    kernel-with-firmware: false
>      override-build: |
>        cp debian/scripts/retpoline-extract-one \
>          $SNAPCRAFT_PART_BUILD/scripts/ubuntu-retpoline-extract-one
> 

Make sense.

Acked-by: Colin Ian King <colin.king@canonical.com>
diff mbox series

Patch

diff --git a/snapcraft.yaml b/snapcraft.yaml
index d1802df..0518010 100644
--- a/snapcraft.yaml
+++ b/snapcraft.yaml
@@ -18,6 +18,7 @@  parts:
     kconfigs:
       - CONFIG_DEBUG_INFO=n
     kernel-image-target: zImage
+    kernel-with-firmware: false
     override-build: |
       cp debian/scripts/retpoline-extract-one \
         $SNAPCRAFT_PART_BUILD/scripts/ubuntu-retpoline-extract-one