mbox series

[PATCHv3,iproute2,0/2] clang + misc changes

Message ID 20180823010130.147780-1-mahesh@bandewar.net
Headers show
Series clang + misc changes | expand

Message

Mahesh Bandewar Aug. 23, 2018, 1:01 a.m. UTC
From: Mahesh Bandewar <maheshb@google.com>

The primary theme is to make clang compile the iproute2 package without
warnings. Along with this there are two other misc patches in the series.

First patch uses the preferred_family when operating with maddr feature.
Prior to this patch, it would always open an AF_INET socket irrespective
of the family that is preferred via command-line. 

Second patch mostly adds format attributes to make the c-lang compiler
happy and not throw the warning messages.

Mahesh Bandewar (2):
  ipmaddr: use preferred_family when given
  iproute: make clang happy with iproute2 package

 include/json_writer.h |  3 +--
 ip/iplink_can.c       | 19 ++++++++++++-------
 ip/ipmaddr.c          | 13 ++++++++++++-
 lib/color.c           |  1 +
 lib/json_print.c      |  1 +
 lib/json_writer.c     | 15 +--------------
 misc/ss.c             |  3 ++-
 tc/m_ematch.c         |  1 +
 tc/m_ematch.h         |  1 +
 9 files changed, 32 insertions(+), 25 deletions(-)

Comments

Stephen Hemminger Aug. 30, 2018, 2:59 p.m. UTC | #1
On Wed, 22 Aug 2018 18:01:30 -0700
Mahesh Bandewar <mahesh@bandewar.net> wrote:

> From: Mahesh Bandewar <maheshb@google.com>
> 
> The primary theme is to make clang compile the iproute2 package without
> warnings. Along with this there are two other misc patches in the series.
> 
> First patch uses the preferred_family when operating with maddr feature.
> Prior to this patch, it would always open an AF_INET socket irrespective
> of the family that is preferred via command-line. 
> 
> Second patch mostly adds format attributes to make the c-lang compiler
> happy and not throw the warning messages.
> 
> Mahesh Bandewar (2):
>   ipmaddr: use preferred_family when given
>   iproute: make clang happy with iproute2 package
> 
>  include/json_writer.h |  3 +--
>  ip/iplink_can.c       | 19 ++++++++++++-------
>  ip/ipmaddr.c          | 13 ++++++++++++-
>  lib/color.c           |  1 +
>  lib/json_print.c      |  1 +
>  lib/json_writer.c     | 15 +--------------
>  misc/ss.c             |  3 ++-
>  tc/m_ematch.c         |  1 +
>  tc/m_ematch.h         |  1 +
>  9 files changed, 32 insertions(+), 25 deletions(-)
> 
> -- 
> 2.18.0.1017.ga543ac7ca45-goog
> 

Applied, thanks