| Message ID | 20180829094240.27242-1-ruxandra.radulescu@nxp.com |
|---|---|
| Headers | show |
| Series | dpaa2-eth: Move DPAA2 Ethernet driver | expand |
There are a few static checker warnings for the driver but only the first one looks like a possibly real bug. drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.c:1116 dpaa2_eth_stop() error: uninitialized symbol 'dpni_enabled'. drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.c:1671 set_fq_affinity() warn: 'xps_mask' puts 1024 bytes on stack drivers/staging/fsl-dpaa2/ethsw/ethsw.c:742 port_vlans_add() error: uninitialized symbol 'err'. drivers/staging/fsl-dpaa2/ethsw/ethsw.c:886 port_vlans_del() error: uninitialized symbol 'err'. regards, dan carpenter
> -----Original Message----- > From: Dan Carpenter <dan.carpenter@oracle.com> > Sent: Wednesday, August 29, 2018 2:08 PM > To: Ioana Ciocoi Radulescu <ruxandra.radulescu@nxp.com> > Cc: netdev@vger.kernel.org; davem@davemloft.net; > devel@driverdev.osuosl.org; andrew@lunn.ch; Horia Geanta > <horia.geanta@nxp.com>; Madalin-cristian Bucur > <madalin.bucur@nxp.com>; gregkh@linuxfoundation.org; linux- > kernel@vger.kernel.org; Ioana Ciornei <ioana.ciornei@nxp.com>; Laurentiu > Tudor <laurentiu.tudor@nxp.com> > Subject: Re: [PATCH net-next v2 0/2] dpaa2-eth: Move DPAA2 Ethernet > driver > > There are a few static checker warnings for the driver but only the > first one looks like a possibly real bug. Thanks for the report, what tool did you use to get these warnings? > > drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.c:1116 dpaa2_eth_stop() > error: uninitialized symbol 'dpni_enabled'. Will initialize in v3. Not actually a bug, since it's used only as an out param. > drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.c:1671 set_fq_affinity() warn: > 'xps_mask' puts 1024 bytes on stack > drivers/staging/fsl-dpaa2/ethsw/ethsw.c:742 port_vlans_add() error: > uninitialized symbol 'err'. > drivers/staging/fsl-dpaa2/ethsw/ethsw.c:886 port_vlans_del() error: > uninitialized symbol 'err'. The dpaa2 switch driver is not targeted by the current patchset, so I'll fix these in a separate patch on Greg's staging tree. Thanks, Ioana
On Wed, Aug 29, 2018 at 12:06:44PM +0000, Ioana Ciocoi Radulescu wrote: > > > > There are a few static checker warnings for the driver but only the > > first one looks like a possibly real bug. > > Thanks for the report, what tool did you use to get these warnings? > These are Smatch warnings, but you need to build the cross function DB to see the warnings. regards, dan carpenter
From: Ioana Radulescu <ruxandra.radulescu@nxp.com> Date: Wed, 29 Aug 2018 04:42:38 -0500 > The Freescale/NXP DPAA2 Ethernet driver was first included in > drivers/staging, due to its dependencies on two components located > there at the time of its initial submission: > * the fsl-mc bus driver, which was moved to drivers/bus in kernel 4.17 > * the dpio driver, which was moved to drivers/soc/fsl in kernel 4.18 > > More information on the DPAA2 architecture and the interactions > between the fsl-mc bus and the objects present on it can be found in: > Documentation/networking/dpaa2/overview.rst > > For easier review, the patch is generated without the -M option, > although the driver files are moved without any code changes. > > changes since v1[1]: > * remove RFC label, since dependencies have been merged on net-next > * add patch fixing a possible race at probe (reported by Andrew Lunn) > > [1] https://lore.kernel.org/patchwork/patch/971333/ Series applied, thank you.