| Message ID | 1535466449-24190-1-git-send-email-stefan.bader@canonical.com |
|---|---|
| State | Accepted, archived |
| Delegated to: | stephen hemminger |
| Headers | show |
| Series | iprule: Fix destination prefix output | expand |
On Tue, 2018-08-28 at 16:27 +0200, Stefan Bader wrote: > When adding support for JSON output the new code for printing > the destination prefix adds a stray blank character before > the bitmask. This causes some user-space parsing to fail. > > Current output: > ...: from x.x.x.x/l to y.y.y.y /l > Previous output: > ...: from x.x.x.x/l to y.y.y.y/l > > Fixes: 0dd4ccc5 "iprule: add json support" > Signed-off-by: Stefan Bader <stefan.bader@canonical.com> > --- > ip/iprule.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/ip/iprule.c b/ip/iprule.c > index 8b94214..744d6d8 100644 > --- a/ip/iprule.c > +++ b/ip/iprule.c > @@ -239,7 +239,7 @@ int print_rule(const struct sockaddr_nl *who, > struct nlmsghdr *n, void *arg) > > print_string(PRINT_FP, NULL, "to ", NULL); > print_color_string(PRINT_ANY, ifa_family_color(frh- > >family), > - "dst", "%s ", dst); > + "dst", "%s", dst); > if (frh->dst_len != host_len) > print_uint(PRINT_ANY, "dstlen", "/%u ", frh- > >dst_len); > else Acked-by: Luca Boccassi <bluca@debian.org>
diff --git a/ip/iprule.c b/ip/iprule.c index 8b94214..744d6d8 100644 --- a/ip/iprule.c +++ b/ip/iprule.c @@ -239,7 +239,7 @@ int print_rule(const struct sockaddr_nl *who, struct nlmsghdr *n, void *arg) print_string(PRINT_FP, NULL, "to ", NULL); print_color_string(PRINT_ANY, ifa_family_color(frh->family), - "dst", "%s ", dst); + "dst", "%s", dst); if (frh->dst_len != host_len) print_uint(PRINT_ANY, "dstlen", "/%u ", frh->dst_len); else
When adding support for JSON output the new code for printing the destination prefix adds a stray blank character before the bitmask. This causes some user-space parsing to fail. Current output: ...: from x.x.x.x/l to y.y.y.y /l Previous output: ...: from x.x.x.x/l to y.y.y.y/l Fixes: 0dd4ccc5 "iprule: add json support" Signed-off-by: Stefan Bader <stefan.bader@canonical.com> --- ip/iprule.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)