mbox series

[net,0/3] tcp_bbr: PROBE_RTT minor bug fixes

Message ID 20180822214316.174161-1-yyd@google.com
Headers show
Series tcp_bbr: PROBE_RTT minor bug fixes | expand

Message

Kevin(Yudong) Yang Aug. 22, 2018, 9:43 p.m. UTC
From: "Kevin(Yudong) Yang" <yyd@google.com>

This series includes two minor bug fixes for the TCP BBR PROBE_RTT
mechanism, and one preparatory patch:

(1) A preparatory patch to reorganize the PROBE_RTT logic by refactoring
    (into its own function) the code to exit PROBE_RTT, since the next
    patch will be using that code in a new context.

(2) Fix: When BBR restarts from idle and if BBR is in PROBE_RTT mode,
    BBR should check if it's time to exit PROBE_RTT. If yes, then BBR
    should exit PROBE_RTT mode and restore the cwnd to its full value.

(3) Fix: Apply the PROBE_RTT cwnd cap even if the count of fully-ACKed
    packets is 0.

Kevin Yang (3):
  tcp_bbr: add bbr_check_probe_rtt_done() helper
  tcp_bbr: in restart from idle, see if we should exit PROBE_RTT
  tcp_bbr: apply PROBE_RTT cwnd cap even if acked==0

 net/ipv4/tcp_bbr.c | 42 ++++++++++++++++++++++++------------------
 1 file changed, 24 insertions(+), 18 deletions(-)

Comments

David Miller Aug. 23, 2018, 4:45 a.m. UTC | #1
From: Kevin Yang <yyd@google.com>
Date: Wed, 22 Aug 2018 17:43:13 -0400

> From: "Kevin(Yudong) Yang" <yyd@google.com>
> 
> This series includes two minor bug fixes for the TCP BBR PROBE_RTT
> mechanism, and one preparatory patch:
> 
> (1) A preparatory patch to reorganize the PROBE_RTT logic by refactoring
>     (into its own function) the code to exit PROBE_RTT, since the next
>     patch will be using that code in a new context.
> 
> (2) Fix: When BBR restarts from idle and if BBR is in PROBE_RTT mode,
>     BBR should check if it's time to exit PROBE_RTT. If yes, then BBR
>     should exit PROBE_RTT mode and restore the cwnd to its full value.
> 
> (3) Fix: Apply the PROBE_RTT cwnd cap even if the count of fully-ACKed
>     packets is 0.

Series applied, thank you.