diff mbox series

[1/3] scancpan: wrap abstract if too long

Message ID 20180820111623.23173-2-chrismcc@gmail.com
State Changes Requested
Headers show
Series scancpan patches | expand

Commit Message

Christopher McCrory Aug. 20, 2018, 11:16 a.m. UTC 
Signed-off-by: Christopher McCrory <chrismcc@gmail.com>
---
 utils/scancpan | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

Comments

Francois Perrad Aug. 21, 2018, 5:52 a.m. UTC | #1 
2018-08-20 13:16 GMT+02:00 Christopher McCrory <chrismcc@gmail.com>:

> Signed-off-by: Christopher McCrory <chrismcc@gmail.com>
> ---
>  utils/scancpan | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/utils/scancpan b/utils/scancpan
> index 8f47521692..6c90588ed4 100755
> --- a/utils/scancpan
> +++ b/utils/scancpan
> @@ -484,6 +484,8 @@ use HTTP::Tiny;
>  use Safe;
>  use MetaCPAN::API::Tiny;
>  use Digest::SHA qw(sha256_hex);
> +use Text::Wrap;
> +$Text::Wrap::columns = 62;
>
>  # Below, 5.026 should be aligned with the version of perl actually
>  # bundled in Buildroot:
> @@ -663,7 +665,7 @@ while (my ($distname, $dist) = each %dist) {
>      my $brname = brname( $fsname );
>      mkdir $dirname unless -d $dirname;
>      if ($need_target{$distname} && ($force || !-f $cfgname)) {
> -        my $abstract = $dist->{abstract};
> +        my $abstract = wrap("","\t  ",$dist->{abstract});
>

please, be consistent with the coding style, like this :
             my $abstract = wrap( q{}, qq{\t  }, $dist->{abstract} );

François

         my $homepage = $dist->{resources}->{homepage} || qq{
> https://metacpan.org/release/${distname}};
>          say qq{write ${cfgname}} unless $quiet;
>          open my $fh, q{>}, $cfgname;
> --
> 2.14.4
>
> _______________________________________________
> buildroot mailing list
> buildroot@busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
>
<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">2018-08-20 13:16 GMT+02:00 Christopher McCrory <span dir="ltr">&lt;<a href="mailto:chrismcc@gmail.com" target="_blank">chrismcc@gmail.com</a>&gt;</span>:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Signed-off-by: Christopher McCrory &lt;<a href="mailto:chrismcc@gmail.com">chrismcc@gmail.com</a>&gt;<br>
---<br>
 utils/scancpan | 4 +++-<br>
 1 file changed, 3 insertions(+), 1 deletion(-)<br>
<br>
diff --git a/utils/scancpan b/utils/scancpan<br>
index 8f47521692..6c90588ed4 100755<br>
--- a/utils/scancpan<br>
+++ b/utils/scancpan<br>
@@ -484,6 +484,8 @@ use HTTP::Tiny;<br>
 use Safe;<br>
 use MetaCPAN::API::Tiny;<br>
 use Digest::SHA qw(sha256_hex);<br>
+use Text::Wrap;<br>
+$Text::Wrap::columns = 62;<br>
<br>
 # Below, 5.026 should be aligned with the version of perl actually<br>
 # bundled in Buildroot:<br>
@@ -663,7 +665,7 @@ while (my ($distname, $dist) = each %dist) {<br>
     my $brname = brname( $fsname );<br>
     mkdir $dirname unless -d $dirname;<br>
     if ($need_target{$distname} &amp;&amp; ($force || !-f $cfgname)) {<br>
-        my $abstract = $dist-&gt;{abstract};<br>
+        my $abstract = wrap(&quot;&quot;,&quot;\t  &quot;,$dist-&gt;{abstract});<br></blockquote><div><br></div><div>please, be consistent with the coding style, like this :</div><div>             my $abstract = wrap( q{}, qq{\t  }, $dist-&gt;{abstract} );</div><div><br></div><div>François<br></div><div><br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
         my $homepage = $dist-&gt;{resources}-&gt;{homepage} || qq{<a href="https://metacpan.org/release/${distname}" rel="noreferrer" target="_blank">https://metacpan.org/<wbr>release/${distname}</a>};<br>
         say qq{write ${cfgname}} unless $quiet;<br>
         open my $fh, q{&gt;}, $cfgname;<br>
<span class="gmail-HOEnZb"><font color="#888888">-- <br>
2.14.4<br>
<br>
______________________________<wbr>_________________<br>
buildroot mailing list<br>
<a href="mailto:buildroot@busybox.net">buildroot@busybox.net</a><br>
<a href="http://lists.busybox.net/mailman/listinfo/buildroot" rel="noreferrer" target="_blank">http://lists.busybox.net/<wbr>mailman/listinfo/buildroot</a><br>
</font></span></blockquote></div><br></div></div>
Thomas Petazzoni Sept. 20, 2018, 10:04 p.m. UTC | #2 
Hello,

On Mon, 20 Aug 2018 04:16:21 -0700, Christopher McCrory wrote:
> Signed-off-by: Christopher McCrory <chrismcc@gmail.com>
> ---
>  utils/scancpan | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)

Could you send an updated version that takes into account the
comment made by François a month ago ?

Thanks,

Thomas
diff mbox series

Patch

diff --git a/utils/scancpan b/utils/scancpan
index 8f47521692..6c90588ed4 100755
--- a/utils/scancpan
+++ b/utils/scancpan
@@ -484,6 +484,8 @@  use HTTP::Tiny;
 use Safe;
 use MetaCPAN::API::Tiny;
 use Digest::SHA qw(sha256_hex);
+use Text::Wrap;
+$Text::Wrap::columns = 62;
 
 # Below, 5.026 should be aligned with the version of perl actually
 # bundled in Buildroot:
@@ -663,7 +665,7 @@  while (my ($distname, $dist) = each %dist) {
     my $brname = brname( $fsname );
     mkdir $dirname unless -d $dirname;
     if ($need_target{$distname} && ($force || !-f $cfgname)) {
-        my $abstract = $dist->{abstract};
+        my $abstract = wrap("","\t  ",$dist->{abstract});
         my $homepage = $dist->{resources}->{homepage} || qq{https://metacpan.org/release/${distname}};
         say qq{write ${cfgname}} unless $quiet;
         open my $fh, q{>}, $cfgname;