diff mbox series

[17/17] perl-termreadkey: new package

Message ID 20180811182749.20924-18-chrismcc@gmail.com
State Changes Requested
Headers show
Series even more perl modules | expand

Commit Message

Christopher McCrory Aug. 11, 2018, 6:27 p.m. UTC
Signed-off-by: Christopher McCrory <chrismcc@gmail.com>
---
 DEVELOPERS                                     |  1 +
 package/Config.in                              |  1 +
 package/perl-termreadkey/Config.in             | 10 ++++++++++
 package/perl-termreadkey/perl-termreadkey.hash |  6 ++++++
 package/perl-termreadkey/perl-termreadkey.mk   | 13 +++++++++++++
 5 files changed, 31 insertions(+)
 create mode 100644 package/perl-termreadkey/Config.in
 create mode 100644 package/perl-termreadkey/perl-termreadkey.hash
 create mode 100644 package/perl-termreadkey/perl-termreadkey.mk

Comments

Francois Perrad Aug. 12, 2018, 4:55 p.m. UTC | #1
2018-08-11 20:27 GMT+02:00 Christopher McCrory <chrismcc@gmail.com>:

> Signed-off-by: Christopher McCrory <chrismcc@gmail.com>
>

Acked-by: Francois Perrad <francois.perrad@gadz.org>

---
>  DEVELOPERS                                     |  1 +
>  package/Config.in                              |  1 +
>  package/perl-termreadkey/Config.in             | 10 ++++++++++
>  package/perl-termreadkey/perl-termreadkey.hash |  6 ++++++
>  package/perl-termreadkey/perl-termreadkey.mk   | 13 +++++++++++++
>  5 files changed, 31 insertions(+)
>  create mode 100644 package/perl-termreadkey/Config.in
>  create mode 100644 package/perl-termreadkey/perl-termreadkey.hash
>  create mode 100644 package/perl-termreadkey/perl-termreadkey.mk
>
> diff --git a/DEVELOPERS b/DEVELOPERS
> index e04058a37e..dddb9ca60d 100644
> --- a/DEVELOPERS
> +++ b/DEVELOPERS
> @@ -506,6 +506,7 @@ F:  package/perl-params-util
>  F:     package/perl-sub-install
>  F:     package/perl-sys-meminfo
>  F:     package/perl-sys-mmap
> +F:     package/perl-termreadkey
>  F:     package/perl-template-toolkit
>  F:     package/perl-time-parsedate
>  F:     package/perl-x10
> diff --git a/package/Config.in b/package/Config.in
> index 5585ebcdfa..2b36b477c7 100644
> --- a/package/Config.in
> +++ b/package/Config.in
> @@ -734,6 +734,7 @@ menu "Perl libraries/modules"
>         source "package/perl-sub-install/Config.in"
>         source "package/perl-sys-meminfo/Config.in"
>         source "package/perl-sys-mmap/Config.in"
> +       source "package/perl-termreadkey/Config.in"
>         source "package/perl-template-toolkit/Config.in"
>         source "package/perl-time-hires/Config.in"
>         source "package/perl-time-parsedate/Config.in"
> diff --git a/package/perl-termreadkey/Config.in
> b/package/perl-termreadkey/Config.in
> new file mode 100644
> index 0000000000..7157bb6f68
> --- /dev/null
> +++ b/package/perl-termreadkey/Config.in
> @@ -0,0 +1,10 @@
> +config BR2_PACKAGE_PERL_TERMREADKEY
> +       bool "perl-termreadkey"
> +       depends on !BR2_STATIC_LIBS
> +       help
> +         Change terminal modes, and perform non-blocking reads.
> +
> +         https://metacpan.org/release/TermReadKey
> +
> +comment "perl-termreadkey needs a toolchain w/ dynamic library"
> +       depends on BR2_STATIC_LIBS
> diff --git a/package/perl-termreadkey/perl-termreadkey.hash
> b/package/perl-termreadkey/perl-termreadkey.hash
> new file mode 100644
> index 0000000000..168e37223c
> --- /dev/null
> +++ b/package/perl-termreadkey/perl-termreadkey.hash
> @@ -0,0 +1,6 @@
> +# retrieved by scancpan from http://cpan.metacpan.org/
> +md5    e8ea15c16333ac4f8d146d702e83cc0c TermReadKey-2.37.tar.gz
> +sha256 4a9383cf2e0e0194668fe2bd546e894ffad41d556b41d2f2f577c8db682db241
> TermReadKey-2.37.tar.gz
> +
> +# computed by scancpan
> +sha256 9deb4e80e04cca282a98902939225bf0bedac2e04034df5dba80f12bd0a3be26
> README
> diff --git a/package/perl-termreadkey/perl-termreadkey.mk
> b/package/perl-termreadkey/perl-termreadkey.mk
> new file mode 100644
> index 0000000000..ba2193b66b
> --- /dev/null
> +++ b/package/perl-termreadkey/perl-termreadkey.mk
> @@ -0,0 +1,13 @@
> +###########################################################
> #####################
> +#
> +# perl-termreadkey
> +#
> +###########################################################
> #####################
> +
> +PERL_TERMREADKEY_VERSION = 2.37
> +PERL_TERMREADKEY_SOURCE = TermReadKey-$(PERL_TERMREADKEY_VERSION).tar.gz
> +PERL_TERMREADKEY_SITE = $(BR2_CPAN_MIRROR)/authors/id/J/JS/JSTOWE
> +PERL_TERMREADKEY_LICENSE = Artistic or GPL-1.0+
> +PERL_TERMREADKEY_LICENSE_FILES = README
> +
> +$(eval $(perl-package))
> --
> 2.14.4
>
>
<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">2018-08-11 20:27 GMT+02:00 Christopher McCrory <span dir="ltr">&lt;<a href="mailto:chrismcc@gmail.com" target="_blank">chrismcc@gmail.com</a>&gt;</span>:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Signed-off-by: Christopher McCrory &lt;<a href="mailto:chrismcc@gmail.com">chrismcc@gmail.com</a>&gt;<br></blockquote><div><br></div><div>Acked-by: Francois Perrad &lt;<a href="mailto:francois.perrad@gadz.org">francois.perrad@gadz.org</a>&gt;<br></div><div> <br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
---<br>
 DEVELOPERS                                     |  1 +<br>
 package/Config.in                              |  1 +<br>
 package/perl-termreadkey/<wbr>Config.in             | 10 ++++++++++<br>
 package/perl-termreadkey/perl-<wbr>termreadkey.hash |  6 ++++++<br>
 package/perl-termreadkey/<a href="http://perl-termreadkey.mk" rel="noreferrer" target="_blank">perl-<wbr>termreadkey.mk</a>   | 13 +++++++++++++<br>
 5 files changed, 31 insertions(+)<br>
 create mode 100644 package/perl-termreadkey/<wbr>Config.in<br>
 create mode 100644 package/perl-termreadkey/perl-<wbr>termreadkey.hash<br>
 create mode 100644 package/perl-termreadkey/<a href="http://perl-termreadkey.mk" rel="noreferrer" target="_blank">perl-<wbr>termreadkey.mk</a><br>
<br>
diff --git a/DEVELOPERS b/DEVELOPERS<br>
index e04058a37e..dddb9ca60d 100644<br>
--- a/DEVELOPERS<br>
+++ b/DEVELOPERS<br>
@@ -506,6 +506,7 @@ F:  package/perl-params-util<br>
 F:     package/perl-sub-install<br>
 F:     package/perl-sys-meminfo<br>
 F:     package/perl-sys-mmap<br>
+F:     package/perl-termreadkey<br>
 F:     package/perl-template-toolkit<br>
 F:     package/perl-time-parsedate<br>
 F:     package/perl-x10<br>
diff --git a/package/Config.in b/package/Config.in<br>
index 5585ebcdfa..2b36b477c7 100644<br>
--- a/package/Config.in<br>
+++ b/package/Config.in<br>
@@ -734,6 +734,7 @@ menu &quot;Perl libraries/modules&quot;<br>
        source &quot;package/perl-sub-install/<wbr>Config.in&quot;<br>
        source &quot;package/perl-sys-meminfo/<wbr>Config.in&quot;<br>
        source &quot;package/perl-sys-mmap/Config.<wbr>in&quot;<br>
+       source &quot;package/perl-termreadkey/<wbr>Config.in&quot;<br>
        source &quot;package/perl-template-<wbr>toolkit/Config.in&quot;<br>
        source &quot;package/perl-time-hires/<wbr>Config.in&quot;<br>
        source &quot;package/perl-time-parsedate/<wbr>Config.in&quot;<br>
diff --git a/package/perl-termreadkey/<wbr>Config.in b/package/perl-termreadkey/<wbr>Config.in<br>
new file mode 100644<br>
index 0000000000..7157bb6f68<br>
--- /dev/null<br>
+++ b/package/perl-termreadkey/<wbr>Config.in<br>
@@ -0,0 +1,10 @@<br>
+config BR2_PACKAGE_PERL_TERMREADKEY<br>
+       bool &quot;perl-termreadkey&quot;<br>
+       depends on !BR2_STATIC_LIBS<br>
+       help<br>
+         Change terminal modes, and perform non-blocking reads.<br>
+<br>
+         <a href="https://metacpan.org/release/TermReadKey" rel="noreferrer" target="_blank">https://metacpan.org/release/<wbr>TermReadKey</a><br>
+<br>
+comment &quot;perl-termreadkey needs a toolchain w/ dynamic library&quot;<br>
+       depends on BR2_STATIC_LIBS<br>
diff --git a/package/perl-termreadkey/<wbr>perl-termreadkey.hash b/package/perl-termreadkey/<wbr>perl-termreadkey.hash<br>
new file mode 100644<br>
index 0000000000..168e37223c<br>
--- /dev/null<br>
+++ b/package/perl-termreadkey/<wbr>perl-termreadkey.hash<br>
@@ -0,0 +1,6 @@<br>
+# retrieved by scancpan from <a href="http://cpan.metacpan.org/" rel="noreferrer" target="_blank">http://cpan.metacpan.org/</a><br>
+md5    e8ea15c16333ac4f8d146d702e83cc<wbr>0c TermReadKey-2.37.tar.gz<br>
+sha256 4a9383cf2e0e0194668fe2bd546e89<wbr>4ffad41d556b41d2f2f577c8db682d<wbr>b241 TermReadKey-2.37.tar.gz<br>
+<br>
+# computed by scancpan<br>
+sha256 9deb4e80e04cca282a98902939225b<wbr>f0bedac2e04034df5dba80f12bd0a3<wbr>be26 README<br>
diff --git a/package/perl-termreadkey/<a href="http://perl-termreadkey.mk" rel="noreferrer" target="_blank">per<wbr>l-termreadkey.mk</a> b/package/perl-termreadkey/<a href="http://perl-termreadkey.mk" rel="noreferrer" target="_blank">per<wbr>l-termreadkey.mk</a><br>
new file mode 100644<br>
index 0000000000..ba2193b66b<br>
--- /dev/null<br>
+++ b/package/perl-termreadkey/<a href="http://perl-termreadkey.mk" rel="noreferrer" target="_blank">per<wbr>l-termreadkey.mk</a><br>
@@ -0,0 +1,13 @@<br>
+#############################<wbr>##############################<wbr>#####################<br>
+#<br>
+# perl-termreadkey<br>
+#<br>
+#############################<wbr>##############################<wbr>#####################<br>
+<br>
+PERL_TERMREADKEY_VERSION = 2.37<br>
+PERL_TERMREADKEY_SOURCE = TermReadKey-$(PERL_<wbr>TERMREADKEY_VERSION).tar.gz<br>
+PERL_TERMREADKEY_SITE = $(BR2_CPAN_MIRROR)/authors/id/<wbr>J/JS/JSTOWE<br>
+PERL_TERMREADKEY_LICENSE = Artistic or GPL-1.0+<br>
+PERL_TERMREADKEY_LICENSE_<wbr>FILES = README<br>
+<br>
+$(eval $(perl-package))<br>
<span class="gmail-HOEnZb"><font color="#888888">-- <br>
2.14.4<br>
<br>
</font></span></blockquote></div><br></div></div>
Thomas Petazzoni Aug. 13, 2018, 9:57 p.m. UTC | #2
Hello,

Adding Yann and Arnout, licensing question below.

On Sat, 11 Aug 2018 11:27:49 -0700, Christopher McCrory wrote:

> +PERL_TERMREADKEY_VERSION = 2.37
> +PERL_TERMREADKEY_SOURCE = TermReadKey-$(PERL_TERMREADKEY_VERSION).tar.gz
> +PERL_TERMREADKEY_SITE = $(BR2_CPAN_MIRROR)/authors/id/J/JS/JSTOWE
> +PERL_TERMREADKEY_LICENSE = Artistic or GPL-1.0+

This is not correct I believe.

The README file says this:

"""
 Term::ReadKey 2.36 - Change terminal modes, and perform non-blocking reads.

 Copyright (C) 1994-1999 Kenneth Albanowski.
               2001-2016 Jonathan Stowe and others

This package is dual licensed.  You can either choose to license it under
the original terms which were:

 Unlimited distribution and/or modification is allowed as long as this
 copyright notice remains intact.

Or the standard Perl terms:

  This module is free software; you can redistribute it and/or modify it
  under the terms of the Artistic License. For details, see the full
  text of the license in the file "Artistic" that should have been provided
  with the version of perl you are using.

  This program is distributed in the hope that it will be useful, but
  without any warranty; without even the implied warranty of merchantability
  or fitness for a particular purpose.
"""

So it is not under "Artistic or GPL-1.0+", but it is under "Artistic or
<some funky license>".

According to
http://docs.activestate.com/activeperl/5.22/perl/lib/Term/ReadKey.html,
the small "Unlimited distribution..." license was the only license of
this Perl module up to version 2.31, at which point the Artistic
license was added as an option.

I don't know how to SPDX-encode this weird license. Perhaps we should
simply not care, and say the license is just "Artistic" ? Yann ?
Arnout ?

Thanks,

Thomas
Arnout Vandecappelle Aug. 13, 2018, 10:40 p.m. UTC | #3
On 13-08-18 23:57, Thomas Petazzoni wrote:
> Hello,
> 
> Adding Yann and Arnout, licensing question below.
> 
> On Sat, 11 Aug 2018 11:27:49 -0700, Christopher McCrory wrote:
> 
>> +PERL_TERMREADKEY_VERSION = 2.37
>> +PERL_TERMREADKEY_SOURCE = TermReadKey-$(PERL_TERMREADKEY_VERSION).tar.gz
>> +PERL_TERMREADKEY_SITE = $(BR2_CPAN_MIRROR)/authors/id/J/JS/JSTOWE
>> +PERL_TERMREADKEY_LICENSE = Artistic or GPL-1.0+
> 
> This is not correct I believe.
> 
> The README file says this:
> 
> """
>  Term::ReadKey 2.36 - Change terminal modes, and perform non-blocking reads.
> 
>  Copyright (C) 1994-1999 Kenneth Albanowski.
>                2001-2016 Jonathan Stowe and others
> 
> This package is dual licensed.  You can either choose to license it under
> the original terms which were:
> 
>  Unlimited distribution and/or modification is allowed as long as this
>  copyright notice remains intact.
> 
> Or the standard Perl terms:
> 
>   This module is free software; you can redistribute it and/or modify it
>   under the terms of the Artistic License. For details, see the full
>   text of the license in the file "Artistic" that should have been provided
>   with the version of perl you are using.
> 
>   This program is distributed in the hope that it will be useful, but
>   without any warranty; without even the implied warranty of merchantability
>   or fitness for a particular purpose.
> """
> 
> So it is not under "Artistic or GPL-1.0+", but it is under "Artistic or
> <some funky license>".
> 
> According to
> http://docs.activestate.com/activeperl/5.22/perl/lib/Term/ReadKey.html,
> the small "Unlimited distribution..." license was the only license of
> this Perl module up to version 2.31, at which point the Artistic
> license was added as an option.
> 
> I don't know how to SPDX-encode this weird license. Perhaps we should
> simply not care, and say the license is just "Artistic" ? Yann ?
> Arnout ?

 For licenses which don't have an SPDX code, we use "<package> license", so this
would be

PERL_TERMREADKEY_LICENSE = Term::ReadKey license or Artistic-2.0

(it's artistic 2.0 because they refer to Artistic in the version of perl you're
using, and our version has Artistic-2.0).

 Regards,
 Arnout


> 
> Thanks,
> 
> Thomas
>
Yann E. MORIN Aug. 14, 2018, 3:53 p.m. UTC | #4
Thomas, Christopher, All,

On 2018-08-13 23:57 +0200, Thomas Petazzoni spake thusly:
> Adding Yann and Arnout, licensing question below.
> On Sat, 11 Aug 2018 11:27:49 -0700, Christopher McCrory wrote:
> > +PERL_TERMREADKEY_VERSION = 2.37
> > +PERL_TERMREADKEY_SOURCE = TermReadKey-$(PERL_TERMREADKEY_VERSION).tar.gz
> > +PERL_TERMREADKEY_SITE = $(BR2_CPAN_MIRROR)/authors/id/J/JS/JSTOWE
> > +PERL_TERMREADKEY_LICENSE = Artistic or GPL-1.0+
> 
> This is not correct I believe.

IANAL...

Indeed it's not.

> The README file says this:
> 
> """
>  Term::ReadKey 2.36 - Change terminal modes, and perform non-blocking reads.
> 
>  Copyright (C) 1994-1999 Kenneth Albanowski.
>                2001-2016 Jonathan Stowe and others
> 
> This package is dual licensed.  You can either choose to license it under
> the original terms which were:
> 
>  Unlimited distribution and/or modification is allowed as long as this
>  copyright notice remains intact.
> 
> Or the standard Perl terms:
> 
>   This module is free software; you can redistribute it and/or modify it
>   under the terms of the Artistic License. For details, see the full
>   text of the license in the file "Artistic" that should have been provided
>   with the version of perl you are using.
> 
>   This program is distributed in the hope that it will be useful, but
>   without any warranty; without even the implied warranty of merchantability
>   or fitness for a particular purpose.
> """
> 
> So it is not under "Artistic or GPL-1.0+", but it is under "Artistic or
> <some funky license>".
> 
> According to
> http://docs.activestate.com/activeperl/5.22/perl/lib/Term/ReadKey.html,
> the small "Unlimited distribution..." license was the only license of
> this Perl module up to version 2.31, at which point the Artistic
> license was added as an option.
> 
> I don't know how to SPDX-encode this weird license. Perhaps we should
> simply not care, and say the license is just "Artistic" ? Yann ?
> Arnout ?

According to the SPDX FAQ [0]:

  * How does one handle [...] licenses not found in the SPDX License
    List?

    [...] one can add the license text to the SPDX file and define a new
    license label. That license identifier is defined only for that
    specific SPDX document. This is explained in Section 6 of the SPDX
    Specification or see [1].

However, we do not have our own SPDX document in Buildroot, so section 6
does not apply.

However, we already have similar situations, where we simply state
something like:

    FOO_LICENSE = Foo license

So, I would state something similar here:

    PERL_TERMREADKEY_LICENSE = Term::ReadKey license or Artistic-1.0-Perl

Please double-check which versiopn of the Artistic license this is
refering to (i.e. the docs says "see the full text of the license in the
file "Artistic" that should have been provided with the version of perl
you are using.", so I just used Artistic-1.0-Perl but I'm not sure...)

Regards,
Yann E. MORIN.

[0] https://spdx.org/frequently-asked-questions-faq-0
[1] https://spdx.org/spdx-specification-21-web-version#h.1v1yuxt
Christopher McCrory Aug. 15, 2018, 11:24 a.m. UTC | #5
hello


On Tue, Aug 14, 2018 at 8:53 AM, Yann E. MORIN <yann.morin.1998@free.fr>
wrote:

> Thomas, Christopher, All,
>
> On 2018-08-13 23:57 +0200, Thomas Petazzoni spake thusly:
> > Adding Yann and Arnout, licensing question below.
> > On Sat, 11 Aug 2018 11:27:49 -0700, Christopher McCrory wrote:
> > > +PERL_TERMREADKEY_VERSION = 2.37
> > > +PERL_TERMREADKEY_SOURCE = TermReadKey-$(PERL_
> TERMREADKEY_VERSION).tar.gz
> > > +PERL_TERMREADKEY_SITE = $(BR2_CPAN_MIRROR)/authors/id/J/JS/JSTOWE
> > > +PERL_TERMREADKEY_LICENSE = Artistic or GPL-1.0+
> >
> > This is not correct I believe.
>
> IANAL...
>
> Indeed it's not.
>
>

The current maintainer explains it here:

https://github.com/jonathanstowe/TermReadKey/issues/11







> > The README file says this:
> >
> > """
> >  Term::ReadKey 2.36 - Change terminal modes, and perform non-blocking
> reads.
> >
> >  Copyright (C) 1994-1999 Kenneth Albanowski.
> >                2001-2016 Jonathan Stowe and others
> >
> > This package is dual licensed.  You can either choose to license it under
> > the original terms which were:
> >
> >  Unlimited distribution and/or modification is allowed as long as this
> >  copyright notice remains intact.
> >
> > Or the standard Perl terms:
> >
> >   This module is free software; you can redistribute it and/or modify it
> >   under the terms of the Artistic License. For details, see the full
> >   text of the license in the file "Artistic" that should have been
> provided
> >   with the version of perl you are using.
> >
> >   This program is distributed in the hope that it will be useful, but
> >   without any warranty; without even the implied warranty of
> merchantability
> >   or fitness for a particular purpose.
> > """
> >
> > So it is not under "Artistic or GPL-1.0+", but it is under "Artistic or
> > <some funky license>".
> >
> > According to
> > http://docs.activestate.com/activeperl/5.22/perl/lib/Term/ReadKey.html,
> > the small "Unlimited distribution..." license was the only license of
> > this Perl module up to version 2.31, at which point the Artistic
> > license was added as an option.
> >
> > I don't know how to SPDX-encode this weird license. Perhaps we should
> > simply not care, and say the license is just "Artistic" ? Yann ?
> > Arnout ?
>
> According to the SPDX FAQ [0]:
>
>   * How does one handle [...] licenses not found in the SPDX License
>     List?
>
>     [...] one can add the license text to the SPDX file and define a new
>     license label. That license identifier is defined only for that
>     specific SPDX document. This is explained in Section 6 of the SPDX
>     Specification or see [1].
>
> However, we do not have our own SPDX document in Buildroot, so section 6
> does not apply.
>
> However, we already have similar situations, where we simply state
> something like:
>
>     FOO_LICENSE = Foo license
>
> So, I would state something similar here:
>
>     PERL_TERMREADKEY_LICENSE = Term::ReadKey license or Artistic-1.0-Perl
>
> Please double-check which versiopn of the Artistic license this is
> refering to (i.e. the docs says "see the full text of the license in the
> file "Artistic" that should have been provided with the version of perl
> you are using.", so I just used Artistic-1.0-Perl but I'm not sure...)
>
> Regards,
> Yann E. MORIN.
>
> [0] https://spdx.org/frequently-asked-questions-faq-0
> [1] https://spdx.org/spdx-specification-21-web-version#h.1v1yuxt
>
> --
> .-----------------.--------------------.------------------.-
> -------------------.
> |  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics'
> conspiracy: |
> | +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___
>      |
> | +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is
> no  |
> | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v
>  conspiracy.  |
> '------------------------------^-------^------------------^-
> -------------------'
>
Yann E. MORIN Aug. 15, 2018, 4:23 p.m. UTC | #6
Chrsitopher, All,

On 2018-08-15 04:24 -0700, Christopher McCrory spake thusly:
> On Tue, Aug 14, 2018 at 8:53 AM, Yann E. MORIN < [1]yann.morin.1998@free.fr> wrote:
>   On 2018-08-13 23:57 +0200, Thomas Petazzoni spake thusly:
>   > Adding Yann and Arnout, licensing question below.
>   > On Sat, 11 Aug 2018 11:27:49 -0700, Christopher McCrory wrote:
>   > > +PERL_TERMREADKEY_VERSION = 2.37
>   > > +PERL_TERMREADKEY_SOURCE = TermReadKey-$(PERL_ TERMREADKEY_VERSION).tar.gz
>   > > +PERL_TERMREADKEY_SITE = $(BR2_CPAN_MIRROR)/authors/id/ J/JS/JSTOWE
>   > > +PERL_TERMREADKEY_LICENSE = Artistic or GPL-1.0+
>   >
>   > This is not correct I believe.
> 
>   IANAL...
> 
>   Indeed it's not.
> 
> The current maintainer explains it here:
> [2]https://github.com/jonathanstowe/TermReadKey/issues/11

So the watters are even muddier than what I expected. We can't take a
position here. The best we can state then is:

    PERL_TERMREADKEY_LICENSE = TERM::Readkey license

Anything else could be misleading.

If a user has any concern with that license, they'd have to consult with
the legal department in their organisation.

Regards,
Yann E. MORIN.
diff mbox series

Patch

diff --git a/DEVELOPERS b/DEVELOPERS
index e04058a37e..dddb9ca60d 100644
--- a/DEVELOPERS
+++ b/DEVELOPERS
@@ -506,6 +506,7 @@  F:	package/perl-params-util
 F:	package/perl-sub-install
 F:	package/perl-sys-meminfo
 F:	package/perl-sys-mmap
+F:	package/perl-termreadkey
 F:	package/perl-template-toolkit
 F:	package/perl-time-parsedate
 F:	package/perl-x10
diff --git a/package/Config.in b/package/Config.in
index 5585ebcdfa..2b36b477c7 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -734,6 +734,7 @@  menu "Perl libraries/modules"
 	source "package/perl-sub-install/Config.in"
 	source "package/perl-sys-meminfo/Config.in"
 	source "package/perl-sys-mmap/Config.in"
+	source "package/perl-termreadkey/Config.in"
 	source "package/perl-template-toolkit/Config.in"
 	source "package/perl-time-hires/Config.in"
 	source "package/perl-time-parsedate/Config.in"
diff --git a/package/perl-termreadkey/Config.in b/package/perl-termreadkey/Config.in
new file mode 100644
index 0000000000..7157bb6f68
--- /dev/null
+++ b/package/perl-termreadkey/Config.in
@@ -0,0 +1,10 @@ 
+config BR2_PACKAGE_PERL_TERMREADKEY
+	bool "perl-termreadkey"
+	depends on !BR2_STATIC_LIBS
+	help
+	  Change terminal modes, and perform non-blocking reads.
+
+	  https://metacpan.org/release/TermReadKey
+
+comment "perl-termreadkey needs a toolchain w/ dynamic library"
+	depends on BR2_STATIC_LIBS
diff --git a/package/perl-termreadkey/perl-termreadkey.hash b/package/perl-termreadkey/perl-termreadkey.hash
new file mode 100644
index 0000000000..168e37223c
--- /dev/null
+++ b/package/perl-termreadkey/perl-termreadkey.hash
@@ -0,0 +1,6 @@ 
+# retrieved by scancpan from http://cpan.metacpan.org/
+md5    e8ea15c16333ac4f8d146d702e83cc0c TermReadKey-2.37.tar.gz
+sha256 4a9383cf2e0e0194668fe2bd546e894ffad41d556b41d2f2f577c8db682db241 TermReadKey-2.37.tar.gz
+
+# computed by scancpan
+sha256 9deb4e80e04cca282a98902939225bf0bedac2e04034df5dba80f12bd0a3be26 README
diff --git a/package/perl-termreadkey/perl-termreadkey.mk b/package/perl-termreadkey/perl-termreadkey.mk
new file mode 100644
index 0000000000..ba2193b66b
--- /dev/null
+++ b/package/perl-termreadkey/perl-termreadkey.mk
@@ -0,0 +1,13 @@ 
+################################################################################
+#
+# perl-termreadkey
+#
+################################################################################
+
+PERL_TERMREADKEY_VERSION = 2.37
+PERL_TERMREADKEY_SOURCE = TermReadKey-$(PERL_TERMREADKEY_VERSION).tar.gz
+PERL_TERMREADKEY_SITE = $(BR2_CPAN_MIRROR)/authors/id/J/JS/JSTOWE
+PERL_TERMREADKEY_LICENSE = Artistic or GPL-1.0+
+PERL_TERMREADKEY_LICENSE_FILES = README
+
+$(eval $(perl-package))