| Message ID | 20180811182749.20924-7-chrismcc@gmail.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | even more perl modules | expand |
Most of the time, host-perl-* packages are useless on BuildRoot, please, double check the package which introduces this dependency. Note: host-perl-module-build & host-perl-module-build-tiny are obviously useful. François 2018-08-11 20:27 GMT+02:00 Christopher McCrory <chrismcc@gmail.com>: > Signed-off-by: Christopher McCrory <chrismcc@gmail.com> > --- > package/perl-module-runtime/perl-module-runtime.mk | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/package/perl-module-runtime/perl-module-runtime.mk > b/package/perl-module-runtime/perl-module-runtime.mk > index 5ba95f7056..44981dc546 100644 > --- a/package/perl-module-runtime/perl-module-runtime.mk > +++ b/package/perl-module-runtime/perl-module-runtime.mk > @@ -8,7 +8,9 @@ PERL_MODULE_RUNTIME_VERSION = 0.016 > PERL_MODULE_RUNTIME_SOURCE = Module-Runtime-$(PERL_MODULE_ > RUNTIME_VERSION).tar.gz > PERL_MODULE_RUNTIME_SITE = $(BR2_CPAN_MIRROR)/authors/id/Z/ZE/ZEFRAM > PERL_MODULE_RUNTIME_DEPENDENCIES = host-perl-module-build > +HOST_PERL_MODULE_RUNTIME_DEPENDENCIES = host-perl-module-build > PERL_MODULE_RUNTIME_LICENSE = Artistic or GPL-1.0+ > PERL_MODULE_RUNTIME_LICENSE_FILES = README > > $(eval $(perl-package)) > +$(eval $(host-perl-package)) > -- > 2.14.4 > > <div dir="ltr"><div><br></div><div>Most of the time, host-perl-* packages are useless on BuildRoot,</div><div>please, double check the package which introduces this dependency.<br></div><div><br></div><div>Note: host-perl-module-build & host-perl-module-build-tiny are obviously useful.</div><div><br></div><div>François<br></div><div><br></div><div class="gmail_extra"><br><div class="gmail_quote">2018-08-11 20:27 GMT+02:00 Christopher McCrory <span dir="ltr"><<a href="mailto:chrismcc@gmail.com" target="_blank">chrismcc@gmail.com</a>></span>:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Signed-off-by: Christopher McCrory <<a href="mailto:chrismcc@gmail.com">chrismcc@gmail.com</a>><br> ---<br> package/perl-module-runtime/<a href="http://perl-module-runtime.mk" rel="noreferrer" target="_blank">pe<wbr>rl-module-runtime.mk</a> | 2 ++<br> 1 file changed, 2 insertions(+)<br> <br> diff --git a/package/perl-module-runtime/<a href="http://perl-module-runtime.mk" rel="noreferrer" target="_blank"><wbr>perl-module-runtime.mk</a> b/package/perl-module-runtime/<a href="http://perl-module-runtime.mk" rel="noreferrer" target="_blank"><wbr>perl-module-runtime.mk</a><br> index 5ba95f7056..44981dc546 100644<br> --- a/package/perl-module-runtime/<a href="http://perl-module-runtime.mk" rel="noreferrer" target="_blank"><wbr>perl-module-runtime.mk</a><br> +++ b/package/perl-module-runtime/<a href="http://perl-module-runtime.mk" rel="noreferrer" target="_blank"><wbr>perl-module-runtime.mk</a><br> @@ -8,7 +8,9 @@ PERL_MODULE_RUNTIME_VERSION = 0.016<br> PERL_MODULE_RUNTIME_SOURCE = Module-Runtime-$(PERL_MODULE_<wbr>RUNTIME_VERSION).tar.gz<br> PERL_MODULE_RUNTIME_SITE = $(BR2_CPAN_MIRROR)/authors/id/<wbr>Z/ZE/ZEFRAM<br> PERL_MODULE_RUNTIME_<wbr>DEPENDENCIES = host-perl-module-build<br> +HOST_PERL_MODULE_RUNTIME_<wbr>DEPENDENCIES = host-perl-module-build<br> PERL_MODULE_RUNTIME_LICENSE = Artistic or GPL-1.0+<br> PERL_MODULE_RUNTIME_LICENSE_<wbr>FILES = README<br> <br> $(eval $(perl-package))<br> +$(eval $(host-perl-package))<br> <span class="HOEnZb"><font color="#888888">-- <br> 2.14.4<br> <br> </font></span></blockquote></div><br></div></div>
Hello François, (Thanks for reviewing the Perl patches, definitely very useful!) On Sun, 12 Aug 2018 11:21:07 +0200, François Perrad wrote: > Most of the time, host-perl-* packages are useless on BuildRoot, > please, double check the package which introduces this dependency. For which specific patches are you giving this comment ? Does it also apply to host-perl-cgi, host-perl-html-parser and host-perl-html-tagset ? Also François, it is very good when you make comments on patches that have issues, but it would be even better if you could provide your Reviewed-by/Acked-by on the patches that look correct to you. This gives me a sign that you are OK with a specific patch, so that I can merge it, and reduce the backlog of patches. Thanks a lot! Thomas
Hello François, On Sun, 12 Aug 2018 14:13:36 +0200, Thomas Petazzoni wrote: > (Thanks for reviewing the Perl patches, definitely very useful!) > > On Sun, 12 Aug 2018 11:21:07 +0200, François Perrad wrote: > > Most of the time, host-perl-* packages are useless on BuildRoot, > > please, double check the package which introduces this dependency. > > For which specific patches are you giving this comment ? Does it also > apply to host-perl-cgi, host-perl-html-parser and > host-perl-html-tagset ? Could you comment on this specific perl-module-runtime patch, adding the host variant ? Christopher, have you been able to verify if it it's really needed for your use-case ? François, I also need your input/review on: http://patchwork.ozlabs.org/patch/956316/ http://patchwork.ozlabs.org/patch/956590/ Thanks! Thomas
diff --git a/package/perl-module-runtime/perl-module-runtime.mk b/package/perl-module-runtime/perl-module-runtime.mk index 5ba95f7056..44981dc546 100644 --- a/package/perl-module-runtime/perl-module-runtime.mk +++ b/package/perl-module-runtime/perl-module-runtime.mk @@ -8,7 +8,9 @@ PERL_MODULE_RUNTIME_VERSION = 0.016 PERL_MODULE_RUNTIME_SOURCE = Module-Runtime-$(PERL_MODULE_RUNTIME_VERSION).tar.gz PERL_MODULE_RUNTIME_SITE = $(BR2_CPAN_MIRROR)/authors/id/Z/ZE/ZEFRAM PERL_MODULE_RUNTIME_DEPENDENCIES = host-perl-module-build +HOST_PERL_MODULE_RUNTIME_DEPENDENCIES = host-perl-module-build PERL_MODULE_RUNTIME_LICENSE = Artistic or GPL-1.0+ PERL_MODULE_RUNTIME_LICENSE_FILES = README $(eval $(perl-package)) +$(eval $(host-perl-package))
Signed-off-by: Christopher McCrory <chrismcc@gmail.com> --- package/perl-module-runtime/perl-module-runtime.mk | 2 ++ 1 file changed, 2 insertions(+)