diff mbox series

[12/17] perl-template-toolkit: new package

Message ID 20180811182749.20924-13-chrismcc@gmail.com
State Changes Requested
Headers show
Series even more perl modules | expand

Commit Message

Christopher McCrory Aug. 11, 2018, 6:27 p.m. UTC 
Signed-off-by: Christopher McCrory <chrismcc@gmail.com>
---
 DEVELOPERS                                               |  1 +
 package/Config.in                                        |  1 +
 package/perl-template-toolkit/Config.in                  | 11 +++++++++++
 package/perl-template-toolkit/perl-template-toolkit.hash |  6 ++++++
 package/perl-template-toolkit/perl-template-toolkit.mk   | 14 ++++++++++++++
 5 files changed, 33 insertions(+)
 create mode 100644 package/perl-template-toolkit/Config.in
 create mode 100644 package/perl-template-toolkit/perl-template-toolkit.hash
 create mode 100644 package/perl-template-toolkit/perl-template-toolkit.mk

Comments

Francois Perrad Aug. 12, 2018, 8:04 a.m. UTC | #1 
2018-08-11 20:27 GMT+02:00 Christopher McCrory <chrismcc@gmail.com>:

> Signed-off-by: Christopher McCrory <chrismcc@gmail.com>
> ---
>  DEVELOPERS                                               |  1 +
>  package/Config.in                                        |  1 +
>  package/perl-template-toolkit/Config.in                  | 11 +++++++++++
>  package/perl-template-toolkit/perl-template-toolkit.hash |  6 ++++++
>  package/perl-template-toolkit/perl-template-toolkit.mk   | 14
> ++++++++++++++
>  5 files changed, 33 insertions(+)
>  create mode 100644 package/perl-template-toolkit/Config.in
>  create mode 100644 package/perl-template-toolkit/
> perl-template-toolkit.hash
>  create mode 100644 package/perl-template-toolkit/perl-template-toolkit.mk
>
> diff --git a/DEVELOPERS b/DEVELOPERS
> index ce2e31461a..e23ad8a879 100644
> --- a/DEVELOPERS
> +++ b/DEVELOPERS
> @@ -504,6 +504,7 @@ F:  package/perl-params-util
>  F:     package/perl-sub-install
>  F:     package/perl-sys-meminfo
>  F:     package/perl-sys-mmap
> +F:     package/perl-template-toolkit
>
>  N:     Clayton Shotwell <clayton.shotwell@rockwellcollins.com>
>  F:     package/audit/
> diff --git a/package/Config.in b/package/Config.in
> index 57b22af90e..58c75b0d8f 100644
> --- a/package/Config.in
> +++ b/package/Config.in
> @@ -732,6 +732,7 @@ menu "Perl libraries/modules"
>         source "package/perl-sub-install/Config.in"
>         source "package/perl-sys-meminfo/Config.in"
>         source "package/perl-sys-mmap/Config.in"
> +       source "package/perl-template-toolkit/Config.in"
>         source "package/perl-time-hires/Config.in"
>         source "package/perl-timedate/Config.in"
>         source "package/perl-try-tiny/Config.in"
> diff --git a/package/perl-template-toolkit/Config.in
> b/package/perl-template-toolkit/Config.in
> new file mode 100644
> index 0000000000..1caca074aa
> --- /dev/null
> +++ b/package/perl-template-toolkit/Config.in
> @@ -0,0 +1,11 @@
> +config BR2_PACKAGE_PERL_TEMPLATE_TOOLKIT
> +       bool "perl-template-toolkit"
> +       depends on !BR2_STATIC_LIBS
> +       select BR2_PACKAGE_PERL_APPCONFIG
> +       help
> +         comprehensive template processing system
> +
> +         https://metacpan.org/release/Template-Toolkit
> +
> +comment "perl-template-toolkit needs a toolchain w/ dynamic library"
> +       depends on BR2_STATIC_LIBS
> diff --git a/package/perl-template-toolkit/perl-template-toolkit.hash
> b/package/perl-template-toolkit/perl-template-toolkit.hash
> new file mode 100644
> index 0000000000..54d4553695
> --- /dev/null
> +++ b/package/perl-template-toolkit/perl-template-toolkit.hash
> @@ -0,0 +1,6 @@
> +# retrieved by scancpan from http://cpan.metacpan.org/
> +md5    a7fae5d4fe5918f33105d92a62134067 Template-Toolkit-2.27.tar.gz
> +sha256 1311a403264d0134c585af0309ff2a9d5074b8ece23ece5660d31ec96bf2c6dc
> Template-Toolkit-2.27.tar.gz
> +
> +# computed by scancpan
> +sha256 d897b2d98affd4f0489340e54ceb542383101e3d21408dfad025df71d770d842
> README
> diff --git a/package/perl-template-toolkit/perl-template-toolkit.mk
> b/package/perl-template-toolkit/perl-template-toolkit.mk
> new file mode 100644
> index 0000000000..820fb5bd8d
> --- /dev/null
> +++ b/package/perl-template-toolkit/perl-template-toolkit.mk
> @@ -0,0 +1,14 @@
> +###########################################################
> #####################
> +#
> +# perl-template-toolkit
> +#
> +###########################################################
> #####################
> +
> +PERL_TEMPLATE_TOOLKIT_VERSION = 2.27
> +PERL_TEMPLATE_TOOLKIT_SOURCE = Template-Toolkit-$(PERL_
> TEMPLATE_TOOLKIT_VERSION).tar.gz
> +PERL_TEMPLATE_TOOLKIT_SITE = $(BR2_CPAN_MIRROR)/authors/id/A/AB/ABW
> +PERL_TEMPLATE_TOOLKIT_DEPENDENCIES = host-perl-cgi perl-appconfig
>

In fact, host-perl-cgi could be removed, and the patches 01-02-03/17 become
useless.


> +PERL_TEMPLATE_TOOLKIT_LICENSE = Artistic or GPL-1.0+
> +PERL_TEMPLATE_TOOLKIT_LICENSE_FILES = README
>

With adding :
PERL_TEMPLATE_TOOLKIT_CONF_OPTS += TT_XS_ENABLE=n

The module becomes pure perl, so you could remove the BR2_STATIC_LIBS stuff
in the Config.in

François

+
> +$(eval $(perl-package))
> --
> 2.14.4
>
>
<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">2018-08-11 20:27 GMT+02:00 Christopher McCrory <span dir="ltr">&lt;<a href="mailto:chrismcc@gmail.com" target="_blank">chrismcc@gmail.com</a>&gt;</span>:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Signed-off-by: Christopher McCrory &lt;<a href="mailto:chrismcc@gmail.com">chrismcc@gmail.com</a>&gt;<br>
---<br>
 DEVELOPERS                                               |  1 +<br>
 package/Config.in                                        |  1 +<br>
 package/perl-template-toolkit/<wbr>Config.in                  | 11 +++++++++++<br>
 package/perl-template-toolkit/<wbr>perl-template-toolkit.hash |  6 ++++++<br>
 package/perl-template-toolkit/<a href="http://perl-template-toolkit.mk" rel="noreferrer" target="_blank"><wbr>perl-template-toolkit.mk</a>   | 14 ++++++++++++++<br>
 5 files changed, 33 insertions(+)<br>
 create mode 100644 package/perl-template-toolkit/<wbr>Config.in<br>
 create mode 100644 package/perl-template-toolkit/<wbr>perl-template-toolkit.hash<br>
 create mode 100644 package/perl-template-toolkit/<a href="http://perl-template-toolkit.mk" rel="noreferrer" target="_blank"><wbr>perl-template-toolkit.mk</a><br>
<br>
diff --git a/DEVELOPERS b/DEVELOPERS<br>
index ce2e31461a..e23ad8a879 100644<br>
--- a/DEVELOPERS<br>
+++ b/DEVELOPERS<br>
@@ -504,6 +504,7 @@ F:  package/perl-params-util<br>
 F:     package/perl-sub-install<br>
 F:     package/perl-sys-meminfo<br>
 F:     package/perl-sys-mmap<br>
+F:     package/perl-template-toolkit<br>
<br>
 N:     Clayton Shotwell &lt;<a href="mailto:clayton.shotwell@rockwellcollins.com">clayton.shotwell@<wbr>rockwellcollins.com</a>&gt;<br>
 F:     package/audit/<br>
diff --git a/package/Config.in b/package/Config.in<br>
index 57b22af90e..58c75b0d8f 100644<br>
--- a/package/Config.in<br>
+++ b/package/Config.in<br>
@@ -732,6 +732,7 @@ menu &quot;Perl libraries/modules&quot;<br>
        source &quot;package/perl-sub-install/<wbr>Config.in&quot;<br>
        source &quot;package/perl-sys-meminfo/<wbr>Config.in&quot;<br>
        source &quot;package/perl-sys-mmap/Config.<wbr>in&quot;<br>
+       source &quot;package/perl-template-<wbr>toolkit/Config.in&quot;<br>
        source &quot;package/perl-time-hires/<wbr>Config.in&quot;<br>
        source &quot;package/perl-timedate/Config.<wbr>in&quot;<br>
        source &quot;package/perl-try-tiny/Config.<wbr>in&quot;<br>
diff --git a/package/perl-template-<wbr>toolkit/Config.in b/package/perl-template-<wbr>toolkit/Config.in<br>
new file mode 100644<br>
index 0000000000..1caca074aa<br>
--- /dev/null<br>
+++ b/package/perl-template-<wbr>toolkit/Config.in<br>
@@ -0,0 +1,11 @@<br>
+config BR2_PACKAGE_PERL_TEMPLATE_<wbr>TOOLKIT<br>
+       bool &quot;perl-template-toolkit&quot;<br>
+       depends on !BR2_STATIC_LIBS<br>
+       select BR2_PACKAGE_PERL_APPCONFIG<br>
+       help<br>
+         comprehensive template processing system<br>
+<br>
+         <a href="https://metacpan.org/release/Template-Toolkit" rel="noreferrer" target="_blank">https://metacpan.org/release/<wbr>Template-Toolkit</a><br>
+<br>
+comment &quot;perl-template-toolkit needs a toolchain w/ dynamic library&quot;<br>
+       depends on BR2_STATIC_LIBS<br>
diff --git a/package/perl-template-<wbr>toolkit/perl-template-toolkit.<wbr>hash b/package/perl-template-<wbr>toolkit/perl-template-toolkit.<wbr>hash<br>
new file mode 100644<br>
index 0000000000..54d4553695<br>
--- /dev/null<br>
+++ b/package/perl-template-<wbr>toolkit/perl-template-toolkit.<wbr>hash<br>
@@ -0,0 +1,6 @@<br>
+# retrieved by scancpan from <a href="http://cpan.metacpan.org/" rel="noreferrer" target="_blank">http://cpan.metacpan.org/</a><br>
+md5    a7fae5d4fe5918f33105d92a621340<wbr>67 Template-Toolkit-2.27.tar.gz<br>
+sha256 1311a403264d0134c585af0309ff2a<wbr>9d5074b8ece23ece5660d31ec96bf2<wbr>c6dc Template-Toolkit-2.27.tar.gz<br>
+<br>
+# computed by scancpan<br>
+sha256 d897b2d98affd4f0489340e54ceb54<wbr>2383101e3d21408dfad025df71d770<wbr>d842 README<br>
diff --git a/package/perl-template-<wbr>toolkit/<a href="http://perl-template-toolkit.mk" rel="noreferrer" target="_blank">perl-template-toolkit.<wbr>mk</a> b/package/perl-template-<wbr>toolkit/<a href="http://perl-template-toolkit.mk" rel="noreferrer" target="_blank">perl-template-toolkit.<wbr>mk</a><br>
new file mode 100644<br>
index 0000000000..820fb5bd8d<br>
--- /dev/null<br>
+++ b/package/perl-template-<wbr>toolkit/<a href="http://perl-template-toolkit.mk" rel="noreferrer" target="_blank">perl-template-toolkit.<wbr>mk</a><br>
@@ -0,0 +1,14 @@<br>
+#############################<wbr>##############################<wbr>#####################<br>
+#<br>
+# perl-template-toolkit<br>
+#<br>
+#############################<wbr>##############################<wbr>#####################<br>
+<br>
+PERL_TEMPLATE_TOOLKIT_VERSION = 2.27<br>
+PERL_TEMPLATE_TOOLKIT_SOURCE = Template-Toolkit-$(PERL_<wbr>TEMPLATE_TOOLKIT_VERSION).tar.<wbr>gz<br>
+PERL_TEMPLATE_TOOLKIT_SITE = $(BR2_CPAN_MIRROR)/authors/id/<wbr>A/AB/ABW<br>
+PERL_TEMPLATE_TOOLKIT_<wbr>DEPENDENCIES = host-perl-cgi perl-appconfig<br></blockquote><div><br></div><div>In fact, host-perl-cgi could be removed, and the patches 01-02-03/17 become useless.<br></div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
+PERL_TEMPLATE_TOOLKIT_LICENSE = Artistic or GPL-1.0+<br>
+PERL_TEMPLATE_TOOLKIT_<wbr>LICENSE_FILES = README<br></blockquote><div><br></div><div>With adding :<br></div><div>PERL_TEMPLATE_TOOLKIT_CONF_OPTS += TT_XS_ENABLE=n<br></div><div><br></div><div>The module becomes pure perl, so you could remove the BR2_STATIC_LIBS stuff in the Config.in<br></div><div><br></div><div>François</div><div><br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
+<br>
+$(eval $(perl-package))<br>
<span class="gmail-HOEnZb"><font color="#888888">-- <br>
2.14.4<br>
<br>
</font></span></blockquote></div><br></div></div>
Thomas Petazzoni Aug. 13, 2018, 9:33 p.m. UTC | #2 
Hello,

On Sun, 12 Aug 2018 10:04:30 +0200, François Perrad wrote:

> > +PERL_TEMPLATE_TOOLKIT_VERSION = 2.27
> > +PERL_TEMPLATE_TOOLKIT_SOURCE = Template-Toolkit-$(PERL_
> > TEMPLATE_TOOLKIT_VERSION).tar.gz
> > +PERL_TEMPLATE_TOOLKIT_SITE = $(BR2_CPAN_MIRROR)/authors/id/A/AB/ABW
> > +PERL_TEMPLATE_TOOLKIT_DEPENDENCIES = host-perl-cgi perl-appconfig
> >  
> 
> In fact, host-perl-cgi could be removed, and the patches 01-02-03/17 become
> useless.

I have marked patches 01/17, 02/17 and 03/17 as Rejected. Then I have
marked this patch 12/17 as "Changes Requested".

Christopher: please send a new iteration of this patch 12/17.

Thanks!

Thomas
diff mbox series

Patch

diff --git a/DEVELOPERS b/DEVELOPERS
index ce2e31461a..e23ad8a879 100644
--- a/DEVELOPERS
+++ b/DEVELOPERS
@@ -504,6 +504,7 @@  F:	package/perl-params-util
 F:	package/perl-sub-install
 F:	package/perl-sys-meminfo
 F:	package/perl-sys-mmap
+F:	package/perl-template-toolkit
 
 N:	Clayton Shotwell <clayton.shotwell@rockwellcollins.com>
 F:	package/audit/
diff --git a/package/Config.in b/package/Config.in
index 57b22af90e..58c75b0d8f 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -732,6 +732,7 @@  menu "Perl libraries/modules"
 	source "package/perl-sub-install/Config.in"
 	source "package/perl-sys-meminfo/Config.in"
 	source "package/perl-sys-mmap/Config.in"
+	source "package/perl-template-toolkit/Config.in"
 	source "package/perl-time-hires/Config.in"
 	source "package/perl-timedate/Config.in"
 	source "package/perl-try-tiny/Config.in"
diff --git a/package/perl-template-toolkit/Config.in b/package/perl-template-toolkit/Config.in
new file mode 100644
index 0000000000..1caca074aa
--- /dev/null
+++ b/package/perl-template-toolkit/Config.in
@@ -0,0 +1,11 @@ 
+config BR2_PACKAGE_PERL_TEMPLATE_TOOLKIT
+	bool "perl-template-toolkit"
+	depends on !BR2_STATIC_LIBS
+	select BR2_PACKAGE_PERL_APPCONFIG
+	help
+	  comprehensive template processing system
+
+	  https://metacpan.org/release/Template-Toolkit
+
+comment "perl-template-toolkit needs a toolchain w/ dynamic library"
+	depends on BR2_STATIC_LIBS
diff --git a/package/perl-template-toolkit/perl-template-toolkit.hash b/package/perl-template-toolkit/perl-template-toolkit.hash
new file mode 100644
index 0000000000..54d4553695
--- /dev/null
+++ b/package/perl-template-toolkit/perl-template-toolkit.hash
@@ -0,0 +1,6 @@ 
+# retrieved by scancpan from http://cpan.metacpan.org/
+md5    a7fae5d4fe5918f33105d92a62134067 Template-Toolkit-2.27.tar.gz
+sha256 1311a403264d0134c585af0309ff2a9d5074b8ece23ece5660d31ec96bf2c6dc Template-Toolkit-2.27.tar.gz
+
+# computed by scancpan
+sha256 d897b2d98affd4f0489340e54ceb542383101e3d21408dfad025df71d770d842 README
diff --git a/package/perl-template-toolkit/perl-template-toolkit.mk b/package/perl-template-toolkit/perl-template-toolkit.mk
new file mode 100644
index 0000000000..820fb5bd8d
--- /dev/null
+++ b/package/perl-template-toolkit/perl-template-toolkit.mk
@@ -0,0 +1,14 @@ 
+################################################################################
+#
+# perl-template-toolkit
+#
+################################################################################
+
+PERL_TEMPLATE_TOOLKIT_VERSION = 2.27
+PERL_TEMPLATE_TOOLKIT_SOURCE = Template-Toolkit-$(PERL_TEMPLATE_TOOLKIT_VERSION).tar.gz
+PERL_TEMPLATE_TOOLKIT_SITE = $(BR2_CPAN_MIRROR)/authors/id/A/AB/ABW
+PERL_TEMPLATE_TOOLKIT_DEPENDENCIES = host-perl-cgi perl-appconfig
+PERL_TEMPLATE_TOOLKIT_LICENSE = Artistic or GPL-1.0+
+PERL_TEMPLATE_TOOLKIT_LICENSE_FILES = README
+
+$(eval $(perl-package))