| Message ID | 1533825067-28079-1-git-send-email-angelo@amarulasolutions.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | package/sysdig: bump to version 0.22.1 | expand |
Hi Angelo, Angelo Compagnucci writes: > This patch bumps sysdig to version 0.22.1 and adds a new dependency on > elfutils. > > Signed-off-by: Angelo Compagnucci <angelo@amarulasolutions.com> > --- > package/sysdig/Config.in | 1 + > package/sysdig/sysdig.hash | 2 +- > package/sysdig/sysdig.mk | 4 ++-- > 3 files changed, 4 insertions(+), 3 deletions(-) > > diff --git a/package/sysdig/Config.in b/package/sysdig/Config.in > index 6ccb706..b527b78 100644 > --- a/package/sysdig/Config.in > +++ b/package/sysdig/Config.in > @@ -13,6 +13,7 @@ config BR2_PACKAGE_SYSDIG > select BR2_PACKAGE_OPENSSL > select BR2_PACKAGE_JQ > select BR2_PACKAGE_LIBB64 > + select BR2_PACKAGE_ELFUTILS So elfutils is a mandatory dependency now, right? If so, you need to replicate the dependencies of elfutils here. baruch
Hello,
On Thu, 9 Aug 2018 16:31:07 +0200, Angelo Compagnucci wrote:
> + select BR2_PACKAGE_ELFUTILS
When you select an option, you need to replicate its dependencies:
config BR2_PACKAGE_ELFUTILS
bool "elfutils"
depends on BR2_USE_WCHAR
depends on !BR2_STATIC_LIBS
# Only glibc and uClibc implement the myriad of required GNUisms
depends on BR2_TOOLCHAIN_USES_UCLIBC || BR2_TOOLCHAIN_USES_GLIBC
Currently, BR2_PACKAGE_SYSDIG only has:
config BR2_PACKAGE_SYSDIG
bool "sysdig"
depends on BR2_LINUX_KERNEL
depends on BR2_INSTALL_LIBSTDCPP # libjson
depends on BR2_PACKAGE_LUAJIT_ARCH_SUPPORTS
depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_8
depends on !BR2_STATIC_LIBS # luajit
Therefore, it should be changed to:
config BR2_PACKAGE_SYSDIG
bool "sysdig"
depends on BR2_LINUX_KERNEL
depends on BR2_INSTALL_LIBSTDCPP # libjson
depends on BR2_PACKAGE_LUAJIT_ARCH_SUPPORTS
depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_8
depends on BR2_USE_WCHAR # elfutils
depends on !BR2_STATIC_LIBS # luajit, elfutils
depends on BR2_TOOLCHAIN_USES_UCLIBC || BR2_TOOLCHAIN_USES_GLIBC # elfutils
Is elfutils really a mandatory dependency of this new version of sysdig ?
Thanks!
Thomas
Dear Thomas, On Thu, Aug 9, 2018 at 9:59 PM, Thomas Petazzoni <thomas.petazzoni@bootlin.com> wrote: > Hello, > > On Thu, 9 Aug 2018 16:31:07 +0200, Angelo Compagnucci wrote: > >> + select BR2_PACKAGE_ELFUTILS > > When you select an option, you need to replicate its dependencies: > > config BR2_PACKAGE_ELFUTILS > bool "elfutils" > depends on BR2_USE_WCHAR > depends on !BR2_STATIC_LIBS > # Only glibc and uClibc implement the myriad of required GNUisms > depends on BR2_TOOLCHAIN_USES_UCLIBC || BR2_TOOLCHAIN_USES_GLIBC > > Currently, BR2_PACKAGE_SYSDIG only has: > > config BR2_PACKAGE_SYSDIG > bool "sysdig" > depends on BR2_LINUX_KERNEL > depends on BR2_INSTALL_LIBSTDCPP # libjson > depends on BR2_PACKAGE_LUAJIT_ARCH_SUPPORTS > depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_8 > depends on !BR2_STATIC_LIBS # luajit > > Therefore, it should be changed to: > > config BR2_PACKAGE_SYSDIG > bool "sysdig" > depends on BR2_LINUX_KERNEL > depends on BR2_INSTALL_LIBSTDCPP # libjson > depends on BR2_PACKAGE_LUAJIT_ARCH_SUPPORTS > depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_8 > depends on BR2_USE_WCHAR # elfutils > depends on !BR2_STATIC_LIBS # luajit, elfutils > depends on BR2_TOOLCHAIN_USES_UCLIBC || BR2_TOOLCHAIN_USES_GLIBC # elfutils > > Is elfutils really a mandatory dependency of this new version of sysdig ? Yes it is, I jest sent a v2 of the patch > > Thanks! > > Thomas > -- > Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons) > Embedded Linux and Kernel engineering > https://bootlin.com
diff --git a/package/sysdig/Config.in b/package/sysdig/Config.in index 6ccb706..b527b78 100644 --- a/package/sysdig/Config.in +++ b/package/sysdig/Config.in @@ -13,6 +13,7 @@ config BR2_PACKAGE_SYSDIG select BR2_PACKAGE_OPENSSL select BR2_PACKAGE_JQ select BR2_PACKAGE_LIBB64 + select BR2_PACKAGE_ELFUTILS help Sysdig is open source, system-level exploration: capture system state and activity from a running Linux diff --git a/package/sysdig/sysdig.hash b/package/sysdig/sysdig.hash index 63a9e38..0c242e5 100644 --- a/package/sysdig/sysdig.hash +++ b/package/sysdig/sysdig.hash @@ -1,2 +1,2 @@ # locally computed -sha256 480d5d8fd7e7373c08008c30bd8e2c7595d5c45d710bf07bd15a522021b560f6 sysdig-0.19.1.tar.gz +sha256 b0ca30473c813c8086187e171f1b8faee6e72689fc02cb1e54ff9f8563bfbe89 sysdig-0.22.1.tar.gz diff --git a/package/sysdig/sysdig.mk b/package/sysdig/sysdig.mk index a9c9f21..49b4bf8 100644 --- a/package/sysdig/sysdig.mk +++ b/package/sysdig/sysdig.mk @@ -4,7 +4,7 @@ # ################################################################################ -SYSDIG_VERSION = 0.19.1 +SYSDIG_VERSION = 0.22.1 SYSDIG_SITE = $(call github,draios,sysdig,$(SYSDIG_VERSION)) SYSDIG_LICENSE = GPL-2.0 SYSDIG_LICENSE_FILES = COPYING @@ -12,7 +12,7 @@ SYSDIG_CONF_OPTS = -DUSE_BUNDLED_LUAJIT=OFF -DUSE_BUNDLED_ZLIB=OFF \ -DUSE_BUNDLED_JSONCPP=OFF -DENABLE_DKMS=OFF -DUSE_BUNDLED_CURL=OFF \ -DUSE_BUNDLED_NCURSES=OFF -DUSE_BUNDLED_OPENSSL=OFF \ -DUSE_BUNDLED_JQ=OFF -DUSE_BUNDLED_B64=OFF -SYSDIG_DEPENDENCIES = zlib luajit jsoncpp libcurl ncurses openssl jq libb64 +SYSDIG_DEPENDENCIES = zlib luajit jsoncpp libcurl ncurses openssl jq libb64 elfutils SYSDIG_SUPPORTS_IN_SOURCE_BUILD = NO # sysdig creates the module Makefile from a template, which contains a
This patch bumps sysdig to version 0.22.1 and adds a new dependency on elfutils. Signed-off-by: Angelo Compagnucci <angelo@amarulasolutions.com> --- package/sysdig/Config.in | 1 + package/sysdig/sysdig.hash | 2 +- package/sysdig/sysdig.mk | 4 ++-- 3 files changed, 4 insertions(+), 3 deletions(-)