mbox series

[SRU,Bionic,0/2] Fixes for LP:1776927

Message ID cover.1529082268.git.joseph.salisbury@canonical.com
Headers show
Series Fixes for LP:1776927 | expand

Message

Joseph Salisbury June 22, 2018, 5:26 p.m. UTC
== SRU Justification ==
Running up two containers using ipvlan with IPv6 autoconf active triggers 
an assertion failure in the kernel (cloud image running on Brightbox).
This is a regression caused by commit e9997c2938b2. 

This regression is fixed by commit 8230819494b3 but also requires commit 94333fac44d1 
as a prereq.

== Fixes ==
94333fac44d1 ("ipvlan: drop ipv6 dependency")
8230819494b3 ("ipvlan: use per device spinlock to protect addrs list updates")

== Regression Potential ==
Low.  Fixes a current regression.  The fix was also sent to stable, so
it has had additional upstream review.

== Test Case ==
A test kernel was built with these patches and tested by the original bug reporter.
The bug reporter states the test kernel resolved the bug.

Matteo Croce (1):
  ipvlan: drop ipv6 dependency

Paolo Abeni (1):
  ipvlan: use per device spinlock to protect addrs list updates

 drivers/net/Kconfig              |  1 -
 drivers/net/ipvlan/ipvlan.h      |  1 +
 drivers/net/ipvlan/ipvlan_core.c | 96 +++++++++++++++++++++++++++++-----------
 drivers/net/ipvlan/ipvlan_main.c | 93 +++++++++++++++++++++++++++-----------

 4 files changed, 137 insertions(+), 54 deletions(-)

Comments

Kleber Sacilotto de Souza July 27, 2018, 7:33 a.m. UTC | #1
On 06/22/18 19:26, Joseph Salisbury wrote:
> == SRU Justification ==
> Running up two containers using ipvlan with IPv6 autoconf active triggers 
> an assertion failure in the kernel (cloud image running on Brightbox).
> This is a regression caused by commit e9997c2938b2. 
> 
> This regression is fixed by commit 8230819494b3 but also requires commit 94333fac44d1 
> as a prereq.
> 
> == Fixes ==
> 94333fac44d1 ("ipvlan: drop ipv6 dependency")
> 8230819494b3 ("ipvlan: use per device spinlock to protect addrs list updates")
> 
> == Regression Potential ==
> Low.  Fixes a current regression.  The fix was also sent to stable, so
> it has had additional upstream review.
> 
> == Test Case ==
> A test kernel was built with these patches and tested by the original bug reporter.
> The bug reporter states the test kernel resolved the bug.
> 
> Matteo Croce (1):
>   ipvlan: drop ipv6 dependency
> 
> Paolo Abeni (1):
>   ipvlan: use per device spinlock to protect addrs list updates
> 
>  drivers/net/Kconfig              |  1 -
>  drivers/net/ipvlan/ipvlan.h      |  1 +
>  drivers/net/ipvlan/ipvlan_core.c | 96 +++++++++++++++++++++++++++++-----------
>  drivers/net/ipvlan/ipvlan_main.c | 93 +++++++++++++++++++++++++++-----------
> 
>  4 files changed, 137 insertions(+), 54 deletions(-)
> 

Acked-by: Kleber Sacilotto de Souza <kleber.souza@canonical.com>
Stefan Bader July 30, 2018, 11:06 a.m. UTC | #2
On 22.06.2018 19:26, Joseph Salisbury wrote:
> == SRU Justification ==
> Running up two containers using ipvlan with IPv6 autoconf active triggers 
> an assertion failure in the kernel (cloud image running on Brightbox).
> This is a regression caused by commit e9997c2938b2. 
> 
> This regression is fixed by commit 8230819494b3 but also requires commit 94333fac44d1 
> as a prereq.
> 
> == Fixes ==
> 94333fac44d1 ("ipvlan: drop ipv6 dependency")
> 8230819494b3 ("ipvlan: use per device spinlock to protect addrs list updates")
> 
> == Regression Potential ==
> Low.  Fixes a current regression.  The fix was also sent to stable, so
> it has had additional upstream review.
> 
> == Test Case ==
> A test kernel was built with these patches and tested by the original bug reporter.
> The bug reporter states the test kernel resolved the bug.
> 
> Matteo Croce (1):
>   ipvlan: drop ipv6 dependency
> 
> Paolo Abeni (1):
>   ipvlan: use per device spinlock to protect addrs list updates
> 
>  drivers/net/Kconfig              |  1 -
>  drivers/net/ipvlan/ipvlan.h      |  1 +
>  drivers/net/ipvlan/ipvlan_core.c | 96 +++++++++++++++++++++++++++++-----------
>  drivers/net/ipvlan/ipvlan_main.c | 93 +++++++++++++++++++++++++++-----------
> 
>  4 files changed, 137 insertions(+), 54 deletions(-)
> 
Acked-by: Stefan Bader <stefan.bader@canonical.com>
Kleber Sacilotto de Souza July 30, 2018, 1:53 p.m. UTC | #3
On 06/22/18 19:26, Joseph Salisbury wrote:
> == SRU Justification ==
> Running up two containers using ipvlan with IPv6 autoconf active triggers 
> an assertion failure in the kernel (cloud image running on Brightbox).
> This is a regression caused by commit e9997c2938b2. 
> 
> This regression is fixed by commit 8230819494b3 but also requires commit 94333fac44d1 
> as a prereq.
> 
> == Fixes ==
> 94333fac44d1 ("ipvlan: drop ipv6 dependency")
> 8230819494b3 ("ipvlan: use per device spinlock to protect addrs list updates")
> 
> == Regression Potential ==
> Low.  Fixes a current regression.  The fix was also sent to stable, so
> it has had additional upstream review.
> 
> == Test Case ==
> A test kernel was built with these patches and tested by the original bug reporter.
> The bug reporter states the test kernel resolved the bug.
> 
> Matteo Croce (1):
>   ipvlan: drop ipv6 dependency
> 
> Paolo Abeni (1):
>   ipvlan: use per device spinlock to protect addrs list updates
> 
>  drivers/net/Kconfig              |  1 -
>  drivers/net/ipvlan/ipvlan.h      |  1 +
>  drivers/net/ipvlan/ipvlan_core.c | 96 +++++++++++++++++++++++++++++-----------
>  drivers/net/ipvlan/ipvlan_main.c | 93 +++++++++++++++++++++++++++-----------
> 
>  4 files changed, 137 insertions(+), 54 deletions(-)
> 

Applied to bionic/master-next branch.

Thanks,
Kleber