| Message ID | 20180725150149.30774-2-gary.bisson@boundarydevices.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [1/8] firmware-imx: bump to version 7.5 | expand |
On 25-07-18 17:01, Gary Bisson wrote: > This new package includes new binaries for i.MX8QXP. > > Signed-off-by: Gary Bisson <gary.bisson@boundarydevices.com> I've applied this patch to master, the rest is changes requested. Regards, Arnout > --- > package/freescale-imx/firmware-imx/firmware-imx.hash | 2 +- > package/freescale-imx/firmware-imx/firmware-imx.mk | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/package/freescale-imx/firmware-imx/firmware-imx.hash b/package/freescale-imx/firmware-imx/firmware-imx.hash > index dd0e13a7cf..c4930bb67d 100644 > --- a/package/freescale-imx/firmware-imx/firmware-imx.hash > +++ b/package/freescale-imx/firmware-imx/firmware-imx.hash > @@ -1,4 +1,4 @@ > # Locally calculated > -sha256 8a8ec439d014e928f42c49bab1c382914ec5b4f1041df28e5d687eb194bd07ab firmware-imx-7.4.bin > +sha256 a8f099bdf786b2da1e8b43094950c033ccdbf93f1b8a93caffb912e1500cd735 firmware-imx-7.5.bin > sha256 faf01d10e484879247963eb97d96622a980232e22a35e487dfe53b13708b686a EULA > sha256 0f34f6175247762e2e1c38319aadf657a53f00ce124e569dfc61b30451549e7a COPYING > diff --git a/package/freescale-imx/firmware-imx/firmware-imx.mk b/package/freescale-imx/firmware-imx/firmware-imx.mk > index b9756fc2bf..0a503d7a66 100644 > --- a/package/freescale-imx/firmware-imx/firmware-imx.mk > +++ b/package/freescale-imx/firmware-imx/firmware-imx.mk > @@ -4,7 +4,7 @@ > # > ################################################################################ > > -FIRMWARE_IMX_VERSION = 7.4 > +FIRMWARE_IMX_VERSION = 7.5 > FIRMWARE_IMX_SITE = $(FREESCALE_IMX_SITE) > FIRMWARE_IMX_SOURCE = firmware-imx-$(FIRMWARE_IMX_VERSION).bin > >
Hello, On Sat, 28 Jul 2018 23:53:44 +0200, Arnout Vandecappelle wrote: > On 25-07-18 17:01, Gary Bisson wrote: > > This new package includes new binaries for i.MX8QXP. > > > > Signed-off-by: Gary Bisson <gary.bisson@boundarydevices.com> > > I've applied this patch to master, the rest is changes requested. I don't know if we have been clear enough with Gary about what changes we want. Do we want to stay with a virtual package ? If so, what should be the name of the virtual package vs. the name of the package for the "old" i.MX VPUs ? On my side, while I agree that imx-vpu-cnm violates the rule of "we name packages like their upstream name", I believe this is a violation that is acceptable because the naming chosen by Gary is the one that is the easiest to understand and the most obvious: imx-vpu is the virtual package, imx-vpu-hantro and imx-vpu-cnm are the providers. Best regards, Thomas
Hi Thomas, Arnout, On Sun, Jul 29, 2018 at 03:08:25PM +0200, Thomas Petazzoni wrote: > Hello, > > On Sat, 28 Jul 2018 23:53:44 +0200, Arnout Vandecappelle wrote: > > On 25-07-18 17:01, Gary Bisson wrote: > > > This new package includes new binaries for i.MX8QXP. > > > > > > Signed-off-by: Gary Bisson <gary.bisson@boundarydevices.com> > > > > I've applied this patch to master, the rest is changes requested. > > I don't know if we have been clear enough with Gary about what changes > we want. Do we want to stay with a virtual package ? That's a good question. But I plan on offering the alternative series without the virtual package, maybe that will help making the decision. It shouldn't be too hard to do. The way I see it using a virtual package is cleaner and is more future-proof (I wouldn't be surprised another imx-vpu-xxx package shows up in a near future). However it also makes it "harder" to select imx-vpuwrap/libimxvpuapi since it depends on imx-vpu, the provider package isn't automatically selected as it used to. > If so, what should > be the name of the virtual package vs. the name of the package for the > "old" i.MX VPUs ? > > On my side, while I agree that imx-vpu-cnm violates the rule of "we > name packages like their upstream name", I believe this is a violation > that is acceptable because the naming chosen by Gary is the one that is > the easiest to understand and the most obvious: imx-vpu is the virtual > package, imx-vpu-hantro and imx-vpu-cnm are the providers. Glad to hear someone agrees with that naming which really makes more sense to me than what is done by NXP. Regards, Gary
diff --git a/package/freescale-imx/firmware-imx/firmware-imx.hash b/package/freescale-imx/firmware-imx/firmware-imx.hash index dd0e13a7cf..c4930bb67d 100644 --- a/package/freescale-imx/firmware-imx/firmware-imx.hash +++ b/package/freescale-imx/firmware-imx/firmware-imx.hash @@ -1,4 +1,4 @@ # Locally calculated -sha256 8a8ec439d014e928f42c49bab1c382914ec5b4f1041df28e5d687eb194bd07ab firmware-imx-7.4.bin +sha256 a8f099bdf786b2da1e8b43094950c033ccdbf93f1b8a93caffb912e1500cd735 firmware-imx-7.5.bin sha256 faf01d10e484879247963eb97d96622a980232e22a35e487dfe53b13708b686a EULA sha256 0f34f6175247762e2e1c38319aadf657a53f00ce124e569dfc61b30451549e7a COPYING diff --git a/package/freescale-imx/firmware-imx/firmware-imx.mk b/package/freescale-imx/firmware-imx/firmware-imx.mk index b9756fc2bf..0a503d7a66 100644 --- a/package/freescale-imx/firmware-imx/firmware-imx.mk +++ b/package/freescale-imx/firmware-imx/firmware-imx.mk @@ -4,7 +4,7 @@ # ################################################################################ -FIRMWARE_IMX_VERSION = 7.4 +FIRMWARE_IMX_VERSION = 7.5 FIRMWARE_IMX_SITE = $(FREESCALE_IMX_SITE) FIRMWARE_IMX_SOURCE = firmware-imx-$(FIRMWARE_IMX_VERSION).bin
This new package includes new binaries for i.MX8QXP. Signed-off-by: Gary Bisson <gary.bisson@boundarydevices.com> --- package/freescale-imx/firmware-imx/firmware-imx.hash | 2 +- package/freescale-imx/firmware-imx/firmware-imx.mk | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)