| Message ID | 20180725014734.9199-1-oohall@gmail.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | hw/phb4: Print the PEs in the EEH dump in hex | expand |
| Context | Check | Description |
|---|---|---|
| snowpatch_ozlabs/apply_patch | warning | master/apply_patch Patch failed to apply |
| snowpatch_ozlabs/apply_patch | fail | Failed to apply to any branch |
On 25/07/18 11:47, Oliver O'Halloran wrote: > Linux always displays the PE number in hexidecimal while skiboot > displays the PEST index (PE number) in decimal. This makes correlating > errors between Skiboot and Linux more annoying than it should be so > this patch makes Skiboot print the PEST number in hex. > > Signed-off-by: Oliver O'Halloran <oohall@gmail.com> Snowpatch reports that this patch doesn't apply.
On Wed, Jul 25, 2018 at 5:51 PM, Andrew Donnellan <andrew.donnellan@au1.ibm.com> wrote: > On 25/07/18 11:47, Oliver O'Halloran wrote: >> >> Linux always displays the PE number in hexidecimal while skiboot >> displays the PEST index (PE number) in decimal. This makes correlating >> errors between Skiboot and Linux more annoying than it should be so >> this patch makes Skiboot print the PEST number in hex. >> >> Signed-off-by: Oliver O'Halloran <oohall@gmail.com> > > > Snowpatch reports that this patch doesn't apply. *groan* Seems I added a newline to that function in a different patch in my test branch. > > -- > Andrew Donnellan OzLabs, ADL Canberra > andrew.donnellan@au1.ibm.com IBM Australia Limited >
diff --git a/hw/phb4.c b/hw/phb4.c index 5d2dcd0483c7..58b5f6091f41 100644 --- a/hw/phb4.c +++ b/hw/phb4.c @@ -2050,7 +2050,7 @@ static void phb4_eeh_dump_regs(struct phb4 *p) for (i = 0; i < OPAL_PHB4_NUM_PEST_REGS; i++) { if (!s->pestA[i] && !s->pestB[i]) continue; - PHBERR(p, " PEST[%03d] = %016llx %016llx\n", + PHBERR(p, " PEST[%03x] = %016llx %016llx\n", i, s->pestA[i], s->pestB[i]); }
Linux always displays the PE number in hexidecimal while skiboot displays the PEST index (PE number) in decimal. This makes correlating errors between Skiboot and Linux more annoying than it should be so this patch makes Skiboot print the PEST number in hex. Signed-off-by: Oliver O'Halloran <oohall@gmail.com> --- hw/phb4.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)