mbox series

[v3,0/2] Add support for cpcap regulators on Tegra based Xoom devices.

Message ID 20180724132541.17039-1-pgwipeout@gmail.com
Headers show
Series Add support for cpcap regulators on Tegra based Xoom devices. | expand

Message

Peter Geis July 24, 2018, 1:25 p.m. UTC 
Good Morning,

This is revision three of the patch.
I have changed the device match from Tegra to Xoom as per Dmitry's
suggestion, to be more accurate.

The CPCAP regulator driver can support various devices, but currently only supports Omap4 devices.
Adds the sw2 and sw4 voltage tables, which power the Tegra core, and a DT match for the Tegra device.
Tested on the Motorola Xoom MZ602, but supports the MZ600 (CDMA), MZ602 (LTE), and
MZ604 (Wifi).

v3:
Changed the devicetree match from Tegra to Xoom.

v2:
Stopped reinventing the wheel, using git email now.
Rebased against regulator for-next branch.

v1:
Fix conversion of tabulation to spaces.

Peter Geis (2):
  Add sw2_sw4 voltage table to cpcap regulator.
  Add support for CPCAP regulators on Motorola Xoom devices.

 .../bindings/regulator/cpcap-regulator.txt    |   1 +
 drivers/regulator/cpcap-regulator.c           | 103 ++++++++++++++++++
 2 files changed, 104 insertions(+)

Comments

Mark Brown July 24, 2018, 2:36 p.m. UTC | #1 
On Tue, Jul 24, 2018 at 09:25:40AM -0400, Peter Geis wrote:
> SW2 and SW4 use a shared table to provide voltage to the cpu core and
> devices on Tegra hardware.
> Added this table to the cpcap regulator driver as the first step to
> supporting this device on Tegra.

Please submit patches using subject lines reflecting the style for the
subsystem.  This makes it easier for people to identify relevant
patches.  Look at what existing commits in the area you're changing are
doing and make sure your subject lines visually resemble what they're
doing.
Peter Geis July 24, 2018, 3:52 p.m. UTC | #2 
On 07/24/2018 10:36 AM, Mark Brown wrote:
> On Tue, Jul 24, 2018 at 09:25:40AM -0400, Peter Geis wrote:
>> SW2 and SW4 use a shared table to provide voltage to the cpu core and
>> devices on Tegra hardware.
>> Added this table to the cpcap regulator driver as the first step to
>> supporting this device on Tegra.
> 
> Please submit patches using subject lines reflecting the style for the
> subsystem.  This makes it easier for people to identify relevant
> patches.  Look at what existing commits in the area you're changing are
> doing and make sure your subject lines visually resemble what they're
> doing.
> 

Copy, should I resubmit?
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Mark Brown July 24, 2018, 4:02 p.m. UTC | #3 
On Tue, Jul 24, 2018 at 11:52:48AM -0400, Peter Geis wrote:
> On 07/24/2018 10:36 AM, Mark Brown wrote:

> > Please submit patches using subject lines reflecting the style for the
> > subsystem.  This makes it easier for people to identify relevant
> > patches.  Look at what existing commits in the area you're changing are
> > doing and make sure your subject lines visually resemble what they're
> > doing.

> Copy, should I resubmit?

No, it's OK - I already applied.