| Message ID | 20180721191358.13952-2-hauke@hauke-m.de |
|---|---|
| State | Changes Requested, archived |
| Delegated to: | David Miller |
| Headers | show |
| Series | net: Add support for Lantiq / Intel vrx200 network | expand |
Hi Hauke, On Sat, Jul 21, 2018 at 09:13:55PM +0200, Hauke Mehrtens wrote: > When a DMA channel is opened the IRQ should not get activated > automatically, this allows it to pull data out manually without the help > of interrupts. This is needed for a workaround in the vrx200 Ethernet > driver. > > Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de> > --- > arch/mips/lantiq/xway/dma.c | 1 - > drivers/net/ethernet/lantiq_etop.c | 1 + > 2 files changed, 1 insertion(+), 1 deletion(-) If you'd like this to go via the netdev tree to keep it with the rest of the series: Acked-by: Paul Burton <paul.burton@mips.com> Though I'd be happier if we didn't have DMA code seemingly used only by an ethernet driver in arch/mips/ :) Thanks, Paul
On 07/24/2018 02:19 AM, Paul Burton wrote: > Hi Hauke, > > On Sat, Jul 21, 2018 at 09:13:55PM +0200, Hauke Mehrtens wrote: >> When a DMA channel is opened the IRQ should not get activated >> automatically, this allows it to pull data out manually without the help >> of interrupts. This is needed for a workaround in the vrx200 Ethernet >> driver. >> >> Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de> >> --- >> arch/mips/lantiq/xway/dma.c | 1 - >> drivers/net/ethernet/lantiq_etop.c | 1 + >> 2 files changed, 1 insertion(+), 1 deletion(-) > > If you'd like this to go via the netdev tree to keep it with the rest of > the series: > > Acked-by: Paul Burton <paul.burton@mips.com> Thanks, I also prefer that this goes through netdev. > Though I'd be happier if we didn't have DMA code seemingly used only by > an ethernet driver in arch/mips/ :) There are also some out of tree driver that use this DMA code. This should probably be converted to a DMA channel driver but that is not very high on my todo list. Hauke
From: Hauke Mehrtens <hauke@hauke-m.de> Date: Tue, 24 Jul 2018 07:32:27 +0200 > > > On 07/24/2018 02:19 AM, Paul Burton wrote: >> Hi Hauke, >> >> On Sat, Jul 21, 2018 at 09:13:55PM +0200, Hauke Mehrtens wrote: >>> When a DMA channel is opened the IRQ should not get activated >>> automatically, this allows it to pull data out manually without the help >>> of interrupts. This is needed for a workaround in the vrx200 Ethernet >>> driver. >>> >>> Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de> >>> --- >>> arch/mips/lantiq/xway/dma.c | 1 - >>> drivers/net/ethernet/lantiq_etop.c | 1 + >>> 2 files changed, 1 insertion(+), 1 deletion(-) >> >> If you'd like this to go via the netdev tree to keep it with the rest of >> the series: >> >> Acked-by: Paul Burton <paul.burton@mips.com> > > Thanks, I also prefer that this goes through netdev. Please be sure to repost your series with Paul's ACK added. Also, in the patch postings and cover letter, put "net-next" in the Subject line so that the target tree is clear, like: Subject: [PATCH net-next 1/4] MIPS: ... Thank you.
diff --git a/arch/mips/lantiq/xway/dma.c b/arch/mips/lantiq/xway/dma.c index 4b9fbb6744ad..3a90bb4edacc 100644 --- a/arch/mips/lantiq/xway/dma.c +++ b/arch/mips/lantiq/xway/dma.c @@ -106,7 +106,6 @@ ltq_dma_open(struct ltq_dma_channel *ch) spin_lock_irqsave(<q_dma_lock, flag); ltq_dma_w32(ch->nr, LTQ_DMA_CS); ltq_dma_w32_mask(0, DMA_CHAN_ON, LTQ_DMA_CCTRL); - ltq_dma_w32_mask(0, 1 << ch->nr, LTQ_DMA_IRNEN); spin_unlock_irqrestore(<q_dma_lock, flag); } EXPORT_SYMBOL_GPL(ltq_dma_open); diff --git a/drivers/net/ethernet/lantiq_etop.c b/drivers/net/ethernet/lantiq_etop.c index afc810069440..c978a857a25c 100644 --- a/drivers/net/ethernet/lantiq_etop.c +++ b/drivers/net/ethernet/lantiq_etop.c @@ -438,6 +438,7 @@ ltq_etop_open(struct net_device *dev) if (!IS_TX(i) && (!IS_RX(i))) continue; ltq_dma_open(&ch->dma); + ltq_dma_enable_irq(&ch->dma); napi_enable(&ch->napi); } phy_start(dev->phydev);
When a DMA channel is opened the IRQ should not get activated automatically, this allows it to pull data out manually without the help of interrupts. This is needed for a workaround in the vrx200 Ethernet driver. Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de> --- arch/mips/lantiq/xway/dma.c | 1 - drivers/net/ethernet/lantiq_etop.c | 1 + 2 files changed, 1 insertion(+), 1 deletion(-)