mbox series

[0/2,Cosmic,SRU,Bionic] More complete fix for ext4 regression

Message ID 20180716230050.24741-1-dann.frazier@canonical.com
Headers show
Series More complete fix for ext4 regression | expand

Message

dann frazier July 16, 2018, 11 p.m. UTC 
BugLink: https://bugs.launchpad.net/bugs/1781709

While we had a partial for the ext4 corruption issue triggered by stress-ng's
'chdir' test, we are still seeing ext4 errors with the 'mknod' and 'dentry'
tests. The maintainer has provided a more complete fix that addresses those
as well.

Theodore Ts'o (1):
  UBUNTU: SAUCE: ext4: check for allocation block validity with block
    group locked

dann frazier (1):
  UBUNTU: SAUCE: Revert "UBUNTU: SAUCE: ext4: fix
    ext4_validate_inode_bitmap: comm stress-ng: Corrupt inode bitmap"

 fs/ext4/balloc.c | 3 +++
 1 file changed, 3 insertions(+)

Comments

Colin Ian King July 16, 2018, 11:07 p.m. UTC | #1 
On 17/07/18 00:00, dann frazier wrote:
> BugLink: https://bugs.launchpad.net/bugs/1781709
> 
> While we had a partial for the ext4 corruption issue triggered by stress-ng's
> 'chdir' test, we are still seeing ext4 errors with the 'mknod' and 'dentry'
> tests. The maintainer has provided a more complete fix that addresses those
> as well.
> 
> Theodore Ts'o (1):
>   UBUNTU: SAUCE: ext4: check for allocation block validity with block
>     group locked
> 
> dann frazier (1):
>   UBUNTU: SAUCE: Revert "UBUNTU: SAUCE: ext4: fix
>     ext4_validate_inode_bitmap: comm stress-ng: Corrupt inode bitmap"
> 
>  fs/ext4/balloc.c | 3 +++
>  1 file changed, 3 insertions(+)
> 

Seems sane to me and fixes the issue, so..

Acked-by: Colin Ian King <colin.king@canonical.com>
Stefan Bader July 17, 2018, 8:53 a.m. UTC | #2 
On 17.07.2018 01:00, dann frazier wrote:
> BugLink: https://bugs.launchpad.net/bugs/1781709
> 
> While we had a partial for the ext4 corruption issue triggered by stress-ng's
> 'chdir' test, we are still seeing ext4 errors with the 'mknod' and 'dentry'
> tests. The maintainer has provided a more complete fix that addresses those
> as well.
> 
> Theodore Ts'o (1):
>   UBUNTU: SAUCE: ext4: check for allocation block validity with block
>     group locked
> 
> dann frazier (1):
>   UBUNTU: SAUCE: Revert "UBUNTU: SAUCE: ext4: fix
>     ext4_validate_inode_bitmap: comm stress-ng: Corrupt inode bitmap"
> 
>  fs/ext4/balloc.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
Acked-by: Stefan Bader <stefan.bader@canonical.com>
Stefan Bader July 17, 2018, 2:35 p.m. UTC | #3 
On 17.07.2018 01:00, dann frazier wrote:
> BugLink: https://bugs.launchpad.net/bugs/1781709
> 
> While we had a partial for the ext4 corruption issue triggered by stress-ng's
> 'chdir' test, we are still seeing ext4 errors with the 'mknod' and 'dentry'
> tests. The maintainer has provided a more complete fix that addresses those
> as well.
> 
> Theodore Ts'o (1):
>   UBUNTU: SAUCE: ext4: check for allocation block validity with block
>     group locked
> 
> dann frazier (1):
>   UBUNTU: SAUCE: Revert "UBUNTU: SAUCE: ext4: fix
>     ext4_validate_inode_bitmap: comm stress-ng: Corrupt inode bitmap"
> 
>  fs/ext4/balloc.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
Applied for the 2018.07.02-5 re-spin.
Thadeu Lima de Souza Cascardo July 24, 2018, 7 p.m. UTC | #4 
Applied to cosmic master-next branch and unstable master branch.

Thanks.
Cascardo.

Applied-to: cosmic/master-next
Applied-to: unstable/master