| Message ID | 20180614203410.10482-1-guillaume.gardet@free.fr |
|---|---|
| State | Accepted |
| Commit | a53729456bbf88677f994e3afdc7f642773300c9 |
| Delegated to: | Minkyu Kang |
| Headers | show |
| Series | [U-Boot] snow: set fdtfile | expand |
Hi, This is a reminder for this patch. Guillaume Le 14/06/2018 à 22:34, Guillaume GARDET a écrit : > Needed to boot with EFI distro boot. > > Signed-off-by: Guillaume GARDET <guillaume.gardet@free.fr> > > Cc: Akshay Saraswat <akshay.s@samsung.com> > Cc: Tom Rini <trini@konsulko.com> > --- > include/configs/snow.h | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/include/configs/snow.h b/include/configs/snow.h > index 3b0db32ece..c546a5a6d0 100644 > --- a/include/configs/snow.h > +++ b/include/configs/snow.h > @@ -8,6 +8,9 @@ > #ifndef __CONFIG_SNOW_H > #define __CONFIG_SNOW_H > > +#define EXYNOS_FDTFILE_SETTING \ > + "fdtfile=exynos5250-snow.dtb\0" > + > #include <configs/exynos5250-common.h> > #include <configs/exynos5-dt-common.h> > #include <configs/exynos5-common.h>
On Thu, Jun 14, 2018 at 9:34 PM, Guillaume GARDET <guillaume.gardet@free.fr> wrote: > Needed to boot with EFI distro boot. > > Signed-off-by: Guillaume GARDET <guillaume.gardet@free.fr> > > Cc: Akshay Saraswat <akshay.s@samsung.com> > Cc: Tom Rini <trini@konsulko.com> > --- > include/configs/snow.h | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/include/configs/snow.h b/include/configs/snow.h > index 3b0db32ece..c546a5a6d0 100644 > --- a/include/configs/snow.h > +++ b/include/configs/snow.h > @@ -8,6 +8,9 @@ > #ifndef __CONFIG_SNOW_H > #define __CONFIG_SNOW_H > > +#define EXYNOS_FDTFILE_SETTING \ > + "fdtfile=exynos5250-snow.dtb\0" Isn't it set in configs/snow_defconfig with CONFIG_DEFAULT_DEVICE_TREE="exynos5250-snow" > #include <configs/exynos5250-common.h> > #include <configs/exynos5-dt-common.h> > #include <configs/exynos5-common.h> > -- > 2.17.1 > > _______________________________________________ > U-Boot mailing list > U-Boot@lists.denx.de > https://lists.denx.de/listinfo/u-boot
Hi, Le 13/07/2018 à 19:20, Peter Robinson a écrit : > On Thu, Jun 14, 2018 at 9:34 PM, Guillaume GARDET > <guillaume.gardet@free.fr> wrote: >> Needed to boot with EFI distro boot. >> >> Signed-off-by: Guillaume GARDET <guillaume.gardet@free.fr> >> >> Cc: Akshay Saraswat <akshay.s@samsung.com> >> Cc: Tom Rini <trini@konsulko.com> >> --- >> include/configs/snow.h | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/include/configs/snow.h b/include/configs/snow.h >> index 3b0db32ece..c546a5a6d0 100644 >> --- a/include/configs/snow.h >> +++ b/include/configs/snow.h >> @@ -8,6 +8,9 @@ >> #ifndef __CONFIG_SNOW_H >> #define __CONFIG_SNOW_H >> >> +#define EXYNOS_FDTFILE_SETTING \ >> + "fdtfile=exynos5250-snow.dtb\0" > Isn't it set in configs/snow_defconfig with > CONFIG_DEFAULT_DEVICE_TREE="exynos5250-snow" No, CONFIG_DEFAULT_DEVICE_TREE is only used for U-Boot DT, not to set fdtfile var. Guillaume > >> #include <configs/exynos5250-common.h> >> #include <configs/exynos5-dt-common.h> >> #include <configs/exynos5-common.h> >> -- >> 2.17.1 >> >> _______________________________________________ >> U-Boot mailing list >> U-Boot@lists.denx.de >> https://lists.denx.de/listinfo/u-boot
Hi, 2018년 7월 16일 (월) 17:49, Guillaume Gardet <guillaume.gardet@free.fr>님이 작성: > Hi, > > > Le 13/07/2018 à 19:20, Peter Robinson a écrit : > > On Thu, Jun 14, 2018 at 9:34 PM, Guillaume GARDET > > <guillaume.gardet@free.fr> wrote: > >> Needed to boot with EFI distro boot. > >> > >> Signed-off-by: Guillaume GARDET <guillaume.gardet@free.fr> > >> > >> Cc: Akshay Saraswat <akshay.s@samsung.com> > >> Cc: Tom Rini <trini@konsulko.com> > >> --- > >> include/configs/snow.h | 3 +++ > >> 1 file changed, 3 insertions(+) > >> > >> diff --git a/include/configs/snow.h b/include/configs/snow.h > >> index 3b0db32ece..c546a5a6d0 100644 > >> --- a/include/configs/snow.h > >> +++ b/include/configs/snow.h > >> @@ -8,6 +8,9 @@ > >> #ifndef __CONFIG_SNOW_H > >> #define __CONFIG_SNOW_H > >> > >> +#define EXYNOS_FDTFILE_SETTING \ > >> + "fdtfile=exynos5250-snow.dtb\0" > > Isn't it set in configs/snow_defconfig with > > CONFIG_DEFAULT_DEVICE_TREE="exynos5250-snow" > > No, CONFIG_DEFAULT_DEVICE_TREE is only used for U-Boot DT, not to set > fdtfile var. > > Guillaume > > > > >> #include <configs/exynos5250-common.h> > >> #include <configs/exynos5-dt-common.h> > >> #include <configs/exynos5-common.h> > >> -- > >> 2.17.1 > >> > >> _______________________________________________ > >> U-Boot mailing list > >> U-Boot@lists.denx.de > >> https://lists.denx.de/listinfo/u-boot > > _______________________________________________ > U-Boot mailing list > U-Boot@lists.denx.de > https://lists.denx.de/listinfo/u-boot I'll pick this patch up soon. Thanks, Minkyu Kang.
Hi, 2018년 7월 16일 (월) 18:04, Minkyu Kang <promsoft@gmail.com>님이 작성: > Hi, > > 2018년 7월 16일 (월) 17:49, Guillaume Gardet <guillaume.gardet@free.fr>님이 작성: > >> Hi, >> >> >> Le 13/07/2018 à 19:20, Peter Robinson a écrit : >> > On Thu, Jun 14, 2018 at 9:34 PM, Guillaume GARDET >> > <guillaume.gardet@free.fr> wrote: >> >> Needed to boot with EFI distro boot. >> >> >> >> Signed-off-by: Guillaume GARDET <guillaume.gardet@free.fr> >> >> >> >> Cc: Akshay Saraswat <akshay.s@samsung.com> >> >> Cc: Tom Rini <trini@konsulko.com> >> >> --- >> >> include/configs/snow.h | 3 +++ >> >> 1 file changed, 3 insertions(+) >> >> >> >> diff --git a/include/configs/snow.h b/include/configs/snow.h >> >> index 3b0db32ece..c546a5a6d0 100644 >> >> --- a/include/configs/snow.h >> >> +++ b/include/configs/snow.h >> >> @@ -8,6 +8,9 @@ >> >> #ifndef __CONFIG_SNOW_H >> >> #define __CONFIG_SNOW_H >> >> >> >> +#define EXYNOS_FDTFILE_SETTING \ >> >> + "fdtfile=exynos5250-snow.dtb\0" >> > Isn't it set in configs/snow_defconfig with >> > CONFIG_DEFAULT_DEVICE_TREE="exynos5250-snow" >> >> No, CONFIG_DEFAULT_DEVICE_TREE is only used for U-Boot DT, not to set >> fdtfile var. >> >> Guillaume >> >> > >> >> #include <configs/exynos5250-common.h> >> >> #include <configs/exynos5-dt-common.h> >> >> #include <configs/exynos5-common.h> >> >> -- >> >> 2.17.1 >> >> >> >> _______________________________________________ >> >> U-Boot mailing list >> >> U-Boot@lists.denx.de >> >> https://lists.denx.de/listinfo/u-boot >> >> _______________________________________________ >> U-Boot mailing list >> U-Boot@lists.denx.de >> https://lists.denx.de/listinfo/u-boot > > > I'll pick this patch up soon. > > Thanks, > Minkyu Kang. > applied to u-boot-samsung. Thanks, Minkyu Kang. >
diff --git a/include/configs/snow.h b/include/configs/snow.h index 3b0db32ece..c546a5a6d0 100644 --- a/include/configs/snow.h +++ b/include/configs/snow.h @@ -8,6 +8,9 @@ #ifndef __CONFIG_SNOW_H #define __CONFIG_SNOW_H +#define EXYNOS_FDTFILE_SETTING \ + "fdtfile=exynos5250-snow.dtb\0" + #include <configs/exynos5250-common.h> #include <configs/exynos5-dt-common.h> #include <configs/exynos5-common.h>
Needed to boot with EFI distro boot. Signed-off-by: Guillaume GARDET <guillaume.gardet@free.fr> Cc: Akshay Saraswat <akshay.s@samsung.com> Cc: Tom Rini <trini@konsulko.com> --- include/configs/snow.h | 3 +++ 1 file changed, 3 insertions(+)