Message ID | 1297157343-3213-1-git-send-email-tomoya-linux@dsn.okisemi.com |
---|---|
State | Accepted, archived |
Delegated to: | David Miller |
Headers | show |
From: Tomoya MORINAGA <tomoya-linux@dsn.okisemi.com> Date: Tue, 8 Feb 2011 18:29:01 +0900 > Currently, 800k comms fails since prop_seg set zero. > (EG20T PCH CAN register of prop_seg must be set more than 1) > To prevent prop_seg set to zero, change tseg2_min 1 to 2. > > Signed-off-by: Tomoya MORINAGA <tomoya-linux@dsn.okisemi.com> Applied. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Tomoya, On 02/08/2011 10:29 AM, Tomoya MORINAGA wrote: > Currently, 800k comms fails since prop_seg set zero. > (EG20T PCH CAN register of prop_seg must be set more than 1) > To prevent prop_seg set to zero, change tseg2_min 1 to 2. > > Signed-off-by: Tomoya MORINAGA <tomoya-linux@dsn.okisemi.com> > --- > drivers/net/can/pch_can.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/net/can/pch_can.c b/drivers/net/can/pch_can.c > index c42e972..9b171d1 100644 > --- a/drivers/net/can/pch_can.c > +++ b/drivers/net/can/pch_can.c > @@ -187,7 +187,7 @@ static struct can_bittiming_const pch_can_bittiming_const = { > .name = KBUILD_MODNAME, > .tseg1_min = 1, > .tseg1_max = 16, > - .tseg2_min = 1, > + .tseg2_min = 2, > .tseg2_max = 8, > .sjw_max = 4, > .brp_min = 1, I just realized that this fix is wrong. You wanted to set tseg1_min to 2 (and not tseg2_min). Could you please send a patch? Thanks, Wolfgang. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/net/can/pch_can.c b/drivers/net/can/pch_can.c index c42e972..9b171d1 100644 --- a/drivers/net/can/pch_can.c +++ b/drivers/net/can/pch_can.c @@ -187,7 +187,7 @@ static struct can_bittiming_const pch_can_bittiming_const = { .name = KBUILD_MODNAME, .tseg1_min = 1, .tseg1_max = 16, - .tseg2_min = 1, + .tseg2_min = 2, .tseg2_max = 8, .sjw_max = 4, .brp_min = 1,
Currently, 800k comms fails since prop_seg set zero. (EG20T PCH CAN register of prop_seg must be set more than 1) To prevent prop_seg set to zero, change tseg2_min 1 to 2. Signed-off-by: Tomoya MORINAGA <tomoya-linux@dsn.okisemi.com> --- drivers/net/can/pch_can.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)