| Message ID | 20180628020256.27494-1-mikey@neuling.org |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [1/4] pdbg: Fix htm return codes | expand |
Thanks Mikey, I've applied this series. On Thursday, 28 June 2018 12:02:53 PM AEST Michael Neuling wrote: > The following commit change the way htm is run causing all htm > commands to fail. > > commit 92006e53c927472d62ee1637e6ad6cad35b53d5e > Author: Alistair Popple <alistair@popple.id.au> > Date: Wed Jun 20 15:34:09 2018 +1000 > pdbg: Use new command parsing > > This fixes it by correctly setting the return code. > > Signed-off-by: Michael Neuling <mikey@neuling.org> > --- > src/main.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/main.c b/src/main.c > index f89db2fa76..06612fd042 100644 > --- a/src/main.c > +++ b/src/main.c > @@ -742,7 +742,7 @@ int main(int argc, char *argv[]) > /* Process subcommands. Currently only 'htm'. > * TODO: Move htm command parsing to optcmd once htm clean-up is complete */ > if (!strcmp(argv[optind], "htm")) { > - run_htm(optind, argc, argv); > + rc = run_htm(optind, argc, argv); > goto found_action; > } > >
diff --git a/src/main.c b/src/main.c index f89db2fa76..06612fd042 100644 --- a/src/main.c +++ b/src/main.c @@ -742,7 +742,7 @@ int main(int argc, char *argv[]) /* Process subcommands. Currently only 'htm'. * TODO: Move htm command parsing to optcmd once htm clean-up is complete */ if (!strcmp(argv[optind], "htm")) { - run_htm(optind, argc, argv); + rc = run_htm(optind, argc, argv); goto found_action; }
The following commit change the way htm is run causing all htm commands to fail. commit 92006e53c927472d62ee1637e6ad6cad35b53d5e Author: Alistair Popple <alistair@popple.id.au> Date: Wed Jun 20 15:34:09 2018 +1000 pdbg: Use new command parsing This fixes it by correctly setting the return code. Signed-off-by: Michael Neuling <mikey@neuling.org> --- src/main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)