| Message ID | 1530901970-14972-1-git-send-email-pawel.mikolaj.chmiel@gmail.com |
|---|---|
| Headers | show |
| Series | Initial support for Samsung Galaxy S and Galaxy S 4G | expand |
On Fri, Jul 06, 2018 at 08:32:42PM +0200, Paweł Chmiel wrote: > Adds missing interrupt-controller property to gph2 block, > to silence following warnings during build > /soc/pinctrl@e0200000/gph2: Missing interrupt-controller or interrupt-map property > > It's reguired by Samsung aries boards, an S5PV210 based > Samsung Galaxy S (i9000) and Galaxy S 4G phones, which are added in next patches. > > Signed-off-by: Paweł Chmiel <pawel.mikolaj.chmiel@gmail.com> > --- > arch/arm/boot/dts/s5pv210-pinctrl.dtsi | 2 ++ > 1 file changed, 2 insertions(+) > Thanks, applied. Best regards, Krzysztof -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Fri, Jul 06, 2018 at 08:32:43PM +0200, Paweł Chmiel wrote: > This DTS file have initial support Samsung Aries based phones. > Initial version have support for: > - sdcard > - internal memory (present only on non 4g variant) > - max8998 pmic and rtc > - max17040 fuel gauge > - gpio keys > - fimd (no panel driver yet) > - usb (peripherial mode) > - wifi > > Signed-off-by: Paweł Chmiel <pawel.mikolaj.chmiel@gmail.com> > --- > Changes from v2: > - Restored pinctrl nodes order > - Correct order of nodes > > Changes from v1: > - Removed duplicated and unneeded headers > - Corrected node names > - Added missing spaces > - Removed unneeded pinctrl and sorted entries > - Set correct interrupt type for max8998 pmic > - Add missing regulators > --- > --- I applied this and 3/9 but then dtc complained about warnings make dtbs W=1: arch/arm/boot/dts/s5pv210-galaxys.dtb: Warning (unit_address_vs_reg): /soc/fimd@f8000000/display-timings/timing@0: node has a unit name, but no reg property arch/arm/boot/dts/s5pv210-galaxys.dtb: Warning (avoid_unnecessary_addr_size): /soc/fimd@f8000000: unnecessary #address-cells/#size-cells without "ranges" or child "reg" property These should be fixed (unless such warning come from following bindings, e.g. like in case of ports for Exynos HDMI nodes). Please, always run dtbs W=1 for DTS patches, check with sparse for regular code and checkpatch for everything. Checks with smatch and coccinelle are also appreciated (although coccinelle is run by kbuild bot). Best regards, Krzysztof -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Fri, Jul 06, 2018 at 08:32:48PM +0200, Paweł Chmiel wrote: > This is result of running savedefconfig. > It's preparation for adding support for Samsung Aries devices. > > Signed-off-by: Paweł Chmiel <pawel.mikolaj.chmiel@gmail.com> > --- > arch/arm/configs/s5pv210_defconfig | 1 - > 1 file changed, 1 deletion(-) > Thanks, applied. Best regards, Krzysztof -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Fri, Jul 06, 2018 at 08:32:49PM +0200, Paweł Chmiel wrote: > Enable config options required for Samsung Aries based phones. > ARM_APPENDED_DTB is also needed, because stock bootloader > does not support loading dtb files. > > Signed-off-by: Paweł Chmiel <pawel.mikolaj.chmiel@gmail.com> > --- > arch/arm/configs/s5pv210_defconfig | 33 +++++++++++++++++++++++++++++++-- > 1 file changed, 31 insertions(+), 2 deletions(-) > Thanks, applied. Best regards, Krzysztof -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Fri, Jul 06, 2018 at 08:32:50PM +0200, Paweł Chmiel wrote: > This commit enables few options which are required to boot > typical Linux distro. It was tested by booting ArchLinux ARM > from sdcard. > > Signed-off-by: Paweł Chmiel <pawel.mikolaj.chmiel@gmail.com> > --- > arch/arm/configs/s5pv210_defconfig | 15 +++++++++++++++ > 1 file changed, 15 insertions(+) > Thanks, applied. Best regards, Krzysztof -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Fri, Jul 06, 2018 at 08:32:41PM +0200, Paweł Chmiel wrote: > This patch series adds support for Samsung Galaxy S and Galaxy S 4G. > Both are commercial phone based on Aries family. > > Changes from v2: > - Restored pinctrl nodes order > - Correct order of nodes in aries dtsi file > - Added Reviewed-by to one of patches > - Added Acked-by to one of patches > - Squashed two patches updating samsung-boards documentation I applied first DTS patch and last defconfig. You can resend only the DTS patches after fixing dtc warnings. Then I'll apply them with the bindings change. Best regards, Krzysztof -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
This patch series adds support for Samsung Galaxy S and Galaxy S 4G. Both are commercial phone based on Aries family. Changes from v2: - Restored pinctrl nodes order - Correct order of nodes in aries dtsi file - Added Reviewed-by to one of patches - Added Acked-by to one of patches - Squashed two patches updating samsung-boards documentation Changes from v1: - Removed duplicated and unneeded headers - Corrected node names - Formatting fixes - Removed unneeded pinctrl and sorted entries - Set correct interrupt type for max8998 pmic - Add missing regulators - Added missing commit msg - Added stdout-path - Added information why we hardcode bootargs - Added new patch which adds information, that there are samsung boards, not using exynos bases soc. - Split patch updating s5pv210_defconfig into three parts. First is result of make savedefconfig, second adds drivers required by both devices and last adds some options, which are usefull in booting typical Linux distribution. Jonathan Bakker (2): ARM: dts: s5pv210: Add initial DTS for SGH-T959P phone dt-bindings: samsung: Document bindings for SGH-T959P board Paweł Chmiel (7): ARM: dts: s5pv210: Add missing interrupt-controller property to gph2 ARM: dts: s5pv210: Add initial DTS for Samsung Aries based phones ARM: dts: s5pv210: Add initial DTS for Samsung Galaxy S phone dt-bindings: samsung: Document bindings for Samsung aries boards ARM: s5pv210_defconfig: Run make savedefconfig ARM: s5pv210_defconfig: Enable drivers for Samsung Aries based phones ARM: s5pv210_defconfig: Enable options needed to boot typical Linux distro .../bindings/arm/samsung/samsung-boards.txt | 5 +- arch/arm/boot/dts/Makefile | 2 + arch/arm/boot/dts/s5pv210-aries.dtsi | 423 +++++++++++++++++++++ arch/arm/boot/dts/s5pv210-fascinate4g.dts | 45 +++ arch/arm/boot/dts/s5pv210-galaxys.dts | 77 ++++ arch/arm/boot/dts/s5pv210-pinctrl.dtsi | 2 + arch/arm/configs/s5pv210_defconfig | 49 ++- 7 files changed, 599 insertions(+), 4 deletions(-) create mode 100644 arch/arm/boot/dts/s5pv210-aries.dtsi create mode 100644 arch/arm/boot/dts/s5pv210-fascinate4g.dts create mode 100644 arch/arm/boot/dts/s5pv210-galaxys.dts