diff mbox series

[2/2] ARM: imx_v6_v7_defconfig: Select ULPI support

Message ID 1529930043-6387-2-git-send-email-festevam@gmail.com
State New
Headers show
Series [1/2] ARM: imx_v6_v7_defconfig: Re-sync defconfig | expand

Commit Message

Fabio Estevam June 25, 2018, 12:34 p.m. UTC
From: Fabio Estevam <fabio.estevam@nxp.com>

Select CONFIG_USB_CHIPIDEA_ULPI and CONFIG_USB_ULPI_BUS so that
USB ULPI can be functional on some boards like imx51-babbge.

This fixes a kernel hang in 4.18-rc1 on i.mx51-babbage when
the bootloader does not initialize USB.

Suggested-by: Andrey Smirnov <andrew.smirnov@gmail.com>
Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
---
 arch/arm/configs/imx_v6_v7_defconfig | 2 ++
 1 file changed, 2 insertions(+)

Comments

Lucas Stach June 25, 2018, 12:57 p.m. UTC | #1
Am Montag, den 25.06.2018, 09:34 -0300 schrieb Fabio Estevam:
> From: Fabio Estevam <fabio.estevam@nxp.com>
> 
> Select CONFIG_USB_CHIPIDEA_ULPI and CONFIG_USB_ULPI_BUS so that
> USB ULPI can be functional on some boards like imx51-babbge.
> 
> This fixes a kernel hang in 4.18-rc1 on i.mx51-babbage when
> the bootloader does not initialize USB.

If the kernel hangs without those options, we might want to have a
check for them in the driver, so it aborts the initialization with a
big warning if the port is using ULPI mode and those options aren't
selected.

Regards,
Lucas

> Suggested-by: Andrey Smirnov <andrew.smirnov@gmail.com>
> Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
> ---
>  arch/arm/configs/imx_v6_v7_defconfig | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/arch/arm/configs/imx_v6_v7_defconfig
> b/arch/arm/configs/imx_v6_v7_defconfig
> index d14de86..2da678c 100644
> --- a/arch/arm/configs/imx_v6_v7_defconfig
> +++ b/arch/arm/configs/imx_v6_v7_defconfig
> @@ -300,6 +300,7 @@ CONFIG_USB_STORAGE=y
>  CONFIG_USB_CHIPIDEA=y
>  CONFIG_USB_CHIPIDEA_UDC=y
>  CONFIG_USB_CHIPIDEA_HOST=y
> +CONFIG_USB_CHIPIDEA_ULPI=y
>  CONFIG_USB_SERIAL=m
>  CONFIG_USB_SERIAL_GENERIC=y
>  CONFIG_USB_SERIAL_FTDI_SIO=m
> @@ -336,6 +337,7 @@ CONFIG_USB_GADGETFS=m
>  CONFIG_USB_FUNCTIONFS=m
>  CONFIG_USB_MASS_STORAGE=m
>  CONFIG_USB_G_SERIAL=m
> +CONFIG_USB_ULPI_BUS=y
>  CONFIG_MMC=y
>  CONFIG_MMC_SDHCI=y
>  CONFIG_MMC_SDHCI_PLTFM=y
Fabio Estevam June 25, 2018, 1:07 p.m. UTC | #2
Hi Lucas,

On Mon, Jun 25, 2018 at 9:57 AM, Lucas Stach <l.stach@pengutronix.de> wrote:

> If the kernel hangs without those options, we might want to have a
> check for them in the driver, so it aborts the initialization with a
> big warning if the port is using ULPI mode and those options aren't
> selected.

That's a good idea. Will do as suggested.

Thanks
Shawn Guo July 1, 2018, 1:20 p.m. UTC | #3
On Mon, Jun 25, 2018 at 09:34:03AM -0300, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@nxp.com>
> 
> Select CONFIG_USB_CHIPIDEA_ULPI and CONFIG_USB_ULPI_BUS so that
> USB ULPI can be functional on some boards like imx51-babbge.
> 
> This fixes a kernel hang in 4.18-rc1 on i.mx51-babbage when
> the bootloader does not initialize USB.

Is this hang a regression or what?

Shawn

> 
> Suggested-by: Andrey Smirnov <andrew.smirnov@gmail.com>
> Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
> ---
>  arch/arm/configs/imx_v6_v7_defconfig | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/arch/arm/configs/imx_v6_v7_defconfig b/arch/arm/configs/imx_v6_v7_defconfig
> index d14de86..2da678c 100644
> --- a/arch/arm/configs/imx_v6_v7_defconfig
> +++ b/arch/arm/configs/imx_v6_v7_defconfig
> @@ -300,6 +300,7 @@ CONFIG_USB_STORAGE=y
>  CONFIG_USB_CHIPIDEA=y
>  CONFIG_USB_CHIPIDEA_UDC=y
>  CONFIG_USB_CHIPIDEA_HOST=y
> +CONFIG_USB_CHIPIDEA_ULPI=y
>  CONFIG_USB_SERIAL=m
>  CONFIG_USB_SERIAL_GENERIC=y
>  CONFIG_USB_SERIAL_FTDI_SIO=m
> @@ -336,6 +337,7 @@ CONFIG_USB_GADGETFS=m
>  CONFIG_USB_FUNCTIONFS=m
>  CONFIG_USB_MASS_STORAGE=m
>  CONFIG_USB_G_SERIAL=m
> +CONFIG_USB_ULPI_BUS=y
>  CONFIG_MMC=y
>  CONFIG_MMC_SDHCI=y
>  CONFIG_MMC_SDHCI_PLTFM=y
> -- 
> 2.7.4
>
Fabio Estevam July 1, 2018, 1:24 p.m. UTC | #4
Hi Shawn,

On Sun, Jul 1, 2018 at 10:20 AM, Shawn Guo <shawnguo@kernel.org> wrote:
> On Mon, Jun 25, 2018 at 09:34:03AM -0300, Fabio Estevam wrote:
>> From: Fabio Estevam <fabio.estevam@nxp.com>
>>
>> Select CONFIG_USB_CHIPIDEA_ULPI and CONFIG_USB_ULPI_BUS so that
>> USB ULPI can be functional on some boards like imx51-babbge.
>>
>> This fixes a kernel hang in 4.18-rc1 on i.mx51-babbage when
>> the bootloader does not initialize USB.
>
> Is this hang a regression or what?

Yes, it is a regression in 4.18-rc1 caused by commit  03e6275ae381
("usb: chipidea: Fix ULPI on imx51")

I have also sent a USB kernel patch that avoids the hang, but we need
both the USB patch + the defconfig change in 4.18.

Thanks
Shawn Guo July 3, 2018, 2:02 a.m. UTC | #5
On Mon, Jun 25, 2018 at 09:34:03AM -0300, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@nxp.com>
> 
> Select CONFIG_USB_CHIPIDEA_ULPI and CONFIG_USB_ULPI_BUS so that
> USB ULPI can be functional on some boards like imx51-babbge.
> 
> This fixes a kernel hang in 4.18-rc1 on i.mx51-babbage when
> the bootloader does not initialize USB.
> 
> Suggested-by: Andrey Smirnov <andrew.smirnov@gmail.com>
> Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>

Applied this one as a fix.

Shawn
Shawn Guo July 3, 2018, 2:07 a.m. UTC | #6
On Tue, Jul 03, 2018 at 10:02:37AM +0800, Shawn Guo wrote:
> On Mon, Jun 25, 2018 at 09:34:03AM -0300, Fabio Estevam wrote:
> > From: Fabio Estevam <fabio.estevam@nxp.com>
> > 
> > Select CONFIG_USB_CHIPIDEA_ULPI and CONFIG_USB_ULPI_BUS so that
> > USB ULPI can be functional on some boards like imx51-babbge.
> > 
> > This fixes a kernel hang in 4.18-rc1 on i.mx51-babbage when
> > the bootloader does not initialize USB.
> > 
> > Suggested-by: Andrey Smirnov <andrew.smirnov@gmail.com>
> > Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
> 
> Applied this one as a fix.

Dropped for now, as I suspect that such selection should be done by
driver Kconfig as a dependency.

Shawn
Shawn Guo July 3, 2018, 1:10 p.m. UTC | #7
On Mon, Jun 25, 2018 at 09:34:03AM -0300, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@nxp.com>
> 
> Select CONFIG_USB_CHIPIDEA_ULPI and CONFIG_USB_ULPI_BUS so that
> USB ULPI can be functional on some boards like imx51-babbge.
> 
> This fixes a kernel hang in 4.18-rc1 on i.mx51-babbage when
> the bootloader does not initialize USB.
> 
> Suggested-by: Andrey Smirnov <andrew.smirnov@gmail.com>
> Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>

Applied with editing the commit log a bit to mention commit
03e6275ae381 ("usb: chipidea: Fix ULPI on imx51").

Shawn
Fabio Estevam July 3, 2018, 1:12 p.m. UTC | #8
On Tue, Jul 3, 2018 at 10:10 AM, Shawn Guo <shawnguo@kernel.org> wrote:

> Applied with editing the commit log a bit to mention commit
> 03e6275ae381 ("usb: chipidea: Fix ULPI on imx51").

Thanks a lot, Shawn!
diff mbox series

Patch

diff --git a/arch/arm/configs/imx_v6_v7_defconfig b/arch/arm/configs/imx_v6_v7_defconfig
index d14de86..2da678c 100644
--- a/arch/arm/configs/imx_v6_v7_defconfig
+++ b/arch/arm/configs/imx_v6_v7_defconfig
@@ -300,6 +300,7 @@  CONFIG_USB_STORAGE=y
 CONFIG_USB_CHIPIDEA=y
 CONFIG_USB_CHIPIDEA_UDC=y
 CONFIG_USB_CHIPIDEA_HOST=y
+CONFIG_USB_CHIPIDEA_ULPI=y
 CONFIG_USB_SERIAL=m
 CONFIG_USB_SERIAL_GENERIC=y
 CONFIG_USB_SERIAL_FTDI_SIO=m
@@ -336,6 +337,7 @@  CONFIG_USB_GADGETFS=m
 CONFIG_USB_FUNCTIONFS=m
 CONFIG_USB_MASS_STORAGE=m
 CONFIG_USB_G_SERIAL=m
+CONFIG_USB_ULPI_BUS=y
 CONFIG_MMC=y
 CONFIG_MMC_SDHCI=y
 CONFIG_MMC_SDHCI_PLTFM=y