Message ID | 1529320103-7711-2-git-send-email-radhey.shyam.pandey@xilinx.com |
---|---|
State | Superseded, archived |
Delegated to: | David Miller |
Headers | show |
Series | Fixes coding style in xilinx_emaclite.c | expand |
On Mon, Jun 18, 2018 at 2:08 PM, Radhey Shyam Pandey <radhey.shyam.pandey@xilinx.com> wrote: > Switch hardcoded function name with a reference to __func__ making > the code more maintainable. Address below checkpatch warning: > > WARNING: Prefer using '"%s...", __func__' to using 'xemaclite_mdio_read', > this function's name, in a string > + "xemaclite_mdio_read(phy_id=%i, reg=%x) == %x\n", > > WARNING: Prefer using '"%s...", __func__' to using 'xemaclite_mdio_write', > this function's name, in a string > + "xemaclite_mdio_write(phy_id=%i, reg=%x, val=%x)\n", > For dev_dbg() the __func__ should be completely dropped away.
On Wed, 2018-06-20 at 00:36 +0300, Andy Shevchenko wrote: > On Mon, Jun 18, 2018 at 2:08 PM, Radhey Shyam Pandey > <radhey.shyam.pandey@xilinx.com> wrote: > > Switch hardcoded function name with a reference to __func__ making > > the code more maintainable. Address below checkpatch warning: > > > > WARNING: Prefer using '"%s...", __func__' to using 'xemaclite_mdio_read', > > this function's name, in a string > > + "xemaclite_mdio_read(phy_id=%i, reg=%x) == %x\n", > > > > WARNING: Prefer using '"%s...", __func__' to using 'xemaclite_mdio_write', > > this function's name, in a string > > + "xemaclite_mdio_write(phy_id=%i, reg=%x, val=%x)\n", > > > > For dev_dbg() the __func__ should be completely dropped away. Not really the same. dev_dbg without CONFIG_DYNAMIC_DEBUG does not have the ability to prefix __func__.
> -----Original Message----- > From: Joe Perches [mailto:joe@perches.com] > Sent: Wednesday, June 20, 2018 4:08 AM > To: Andy Shevchenko <andy.shevchenko@gmail.com>; Radhey Shyam > Pandey <radheys@xilinx.com> > Cc: David S. Miller <davem@davemloft.net>; Andrew Lunn > <andrew@lunn.ch>; Michal Simek <michals@xilinx.com>; netdev > <netdev@vger.kernel.org>; linux-arm Mailing List <linux-arm- > kernel@lists.infradead.org>; Linux Kernel Mailing List <linux- > kernel@vger.kernel.org> > Subject: Re: [PATCH 1/5] net: emaclite: Use __func__ instead of hardcoded > name > > On Wed, 2018-06-20 at 00:36 +0300, Andy Shevchenko wrote: > > On Mon, Jun 18, 2018 at 2:08 PM, Radhey Shyam Pandey > > <radhey.shyam.pandey@xilinx.com> wrote: > > > Switch hardcoded function name with a reference to __func__ making > > > the code more maintainable. Address below checkpatch warning: > > > > > > WARNING: Prefer using '"%s...", __func__' to using > 'xemaclite_mdio_read', > > > this function's name, in a string > > > + "xemaclite_mdio_read(phy_id=%i, reg=%x) == %x\n", > > > > > > WARNING: Prefer using '"%s...", __func__' to using > 'xemaclite_mdio_write', > > > this function's name, in a string > > > + "xemaclite_mdio_write(phy_id=%i, reg=%x, val=%x)\n", > > > > > > > For dev_dbg() the __func__ should be completely dropped away. > > Not really the same. > > dev_dbg without CONFIG_DYNAMIC_DEBUG does not have > the ability to prefix __func__. Yes. If it's acceptable, prefer to use __func__ to support all configurations >
diff --git a/drivers/net/ethernet/xilinx/xilinx_emaclite.c b/drivers/net/ethernet/xilinx/xilinx_emaclite.c index 2a0c06e..0544134 100644 --- a/drivers/net/ethernet/xilinx/xilinx_emaclite.c +++ b/drivers/net/ethernet/xilinx/xilinx_emaclite.c @@ -757,7 +757,7 @@ static int xemaclite_mdio_read(struct mii_bus *bus, int phy_id, int reg) rc = xemaclite_readl(lp->base_addr + XEL_MDIORD_OFFSET); dev_dbg(&lp->ndev->dev, - "xemaclite_mdio_read(phy_id=%i, reg=%x) == %x\n", + "%s(phy_id=%i, reg=%x) == %x\n", __func__, phy_id, reg, rc); return rc; @@ -780,7 +780,7 @@ static int xemaclite_mdio_write(struct mii_bus *bus, int phy_id, int reg, u32 ctrl_reg; dev_dbg(&lp->ndev->dev, - "xemaclite_mdio_write(phy_id=%i, reg=%x, val=%x)\n", + "%s(phy_id=%i, reg=%x, val=%x)\n", __func__, phy_id, reg, val); if (xemaclite_mdio_wait(lp))