diff mbox series

[1/4] sysvinit: reduce number of mkdir calls in inittab

Message ID 20180611060016.20755-2-casantos@datacom.com.br
State Accepted
Commit dc267db6ab4d54ed3ddb582774fb51ef64332649
Headers show
Series synchronize initab files and enable swap on startup | expand

Commit Message

Carlos Santos June 11, 2018, 6 a.m. UTC
The default sysvinit inittab does two separate mkdir calls to create
/dev/pts and /dev/shm. Reduce this to call mkdir only once for both
directories.

This removes id "si3" but keeps ids "si4".."si9" intact rather than
renumbering them. This would just increase the turmoil without any
practical effect.

Based on commit e9db8122fb, by Florian La Roche <F.LaRoche@pilz.de>.

Signed-off-by: Carlos Santos <casantos@datacom.com.br>
---
 package/sysvinit/inittab | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

Comments

Peter Korsgaard June 12, 2018, 9:22 a.m. UTC | #1
>>>>> "Carlos" == Carlos Santos <casantos@datacom.com.br> writes:

 > The default sysvinit inittab does two separate mkdir calls to create
 > /dev/pts and /dev/shm. Reduce this to call mkdir only once for both
 > directories.

 > This removes id "si3" but keeps ids "si4".."si9" intact rather than
 > renumbering them. This would just increase the turmoil without any
 > practical effect.

 > Based on commit e9db8122fb, by Florian La Roche <F.LaRoche@pilz.de>.

 > Signed-off-by: Carlos Santos <casantos@datacom.com.br>

Committed, thanks.
Peter Korsgaard June 17, 2018, 3:54 p.m. UTC | #2
>>>>> "Carlos" == Carlos Santos <casantos@datacom.com.br> writes:

 > The default sysvinit inittab does two separate mkdir calls to create
 > /dev/pts and /dev/shm. Reduce this to call mkdir only once for both
 > directories.

 > This removes id "si3" but keeps ids "si4".."si9" intact rather than
 > renumbering them. This would just increase the turmoil without any
 > practical effect.

 > Based on commit e9db8122fb, by Florian La Roche <F.LaRoche@pilz.de>.

 > Signed-off-by: Carlos Santos <casantos@datacom.com.br>

Committed to 2018.02.x, thanks.
diff mbox series

Patch

diff --git a/package/sysvinit/inittab b/package/sysvinit/inittab
index 7eaef59d9e..2ca253ad6c 100644
--- a/package/sysvinit/inittab
+++ b/package/sysvinit/inittab
@@ -6,8 +6,7 @@  id:3:initdefault:
 
 si0::sysinit:/bin/mount -t proc proc /proc
 si1::sysinit:/bin/mount -o remount,rw /
-si2::sysinit:/bin/mkdir -p /dev/pts
-si3::sysinit:/bin/mkdir -p /dev/shm
+si2::sysinit:/bin/mkdir -p /dev/pts /dev/shm
 si4::sysinit:/bin/mount -a
 si5::sysinit:/bin/ln -sf /proc/self/fd /dev/fd 2>/dev/null
 si6::sysinit:/bin/ln -sf /proc/self/fd/0 /dev/stdin 2>/dev/null