Message ID | 1527056424-14528-1-git-send-email-michal.vokac@ysoft.com |
---|---|
Headers | show |
Series | Add support for QCA8334 switch | expand |
On 05/22/2018 11:20 PM, Michal Vokáč wrote: > This series basically adds support for a QCA8334 ethernet switch to the > qca8k driver. It is a four-port variant of the already supported seven > port QCA8337. Register map is the same for the whole familly and all chips > have the same device ID. > > Major part of this series enhances the CPU port setting. Currently the CPU > port is not set to any sensible defaults compatible with the xGMII > interface. This series forces the CPU port to its maximum bandwidth and > also allows to adjust the new defaults using fixed-link device tree > sub-node. > > Alongside these changes I fixed two checkpatch warnings regarding SPDX and > redundant parentheses. Looks great, thanks Michal! Do you have any features or things you are working on that would be added later to the driver? > > Changes in v3: > - Rebased on latest net-next/master. > - Corrected fixed-link documentation. > > Michal Vokáč (7): > net: dsa: qca8k: Add QCA8334 binding documentation > net: dsa: qca8k: Add support for QCA8334 switch > net: dsa: qca8k: Enable RXMAC when bringing up a port > net: dsa: qca8k: Force CPU port to its highest bandwidth > net: dsa: qca8k: Allow overwriting CPU port setting > net: dsa: qca8k: Replace GPL boilerplate by SPDX > net: dsa: qca8k: Remove redundant parentheses > > .../devicetree/bindings/net/dsa/qca8k.txt | 23 +++++++- > drivers/net/dsa/qca8k.c | 64 ++++++++++++++++++---- > drivers/net/dsa/qca8k.h | 7 ++- > 3 files changed, 79 insertions(+), 15 deletions(-) >
From: "Michal Vokáč" <vokac.m@gmail.com> Date: Wed, 23 May 2018 08:20:17 +0200 > This series basically adds support for a QCA8334 ethernet switch to the > qca8k driver. It is a four-port variant of the already supported seven > port QCA8337. Register map is the same for the whole familly and all chips > have the same device ID. > > Major part of this series enhances the CPU port setting. Currently the CPU > port is not set to any sensible defaults compatible with the xGMII > interface. This series forces the CPU port to its maximum bandwidth and > also allows to adjust the new defaults using fixed-link device tree > sub-node. > > Alongside these changes I fixed two checkpatch warnings regarding SPDX and > redundant parentheses. > > Changes in v3: > - Rebased on latest net-next/master. > - Corrected fixed-link documentation. Series applied, thank you.
On 23.5.2018 17:39, Florian Fainelli wrote: > > > On 05/22/2018 11:20 PM, Michal Vokáč wrote: >> This series basically adds support for a QCA8334 ethernet switch to the >> qca8k driver. It is a four-port variant of the already supported seven >> port QCA8337. Register map is the same for the whole familly and all chips >> have the same device ID. >> >> Major part of this series enhances the CPU port setting. Currently the CPU >> port is not set to any sensible defaults compatible with the xGMII >> interface. This series forces the CPU port to its maximum bandwidth and >> also allows to adjust the new defaults using fixed-link device tree >> sub-node. >> >> Alongside these changes I fixed two checkpatch warnings regarding SPDX and >> redundant parentheses. > > Looks great, thanks Michal! Do you have any features or things you are > working on that would be added later to the driver? Thank you too Florian. And also big thank to you Andrew. You helped me a lot to debug the RGMII issue. I have been stuck at that for more than a month and would not resolve it without your help. As I have done this in a process of upgrading our BSP to a more recent kernel, and hopefully mainline, I now need to move on to other parts of the board. So unfortunately no, I do not have any other enhancements planned to this driver for now. But as we are probably one of the few with access to the NDA covered Qualcomm documentation I see a great opportunity to work on that later. I am afraid "later" means something like next year in this case as I am basically the only kernel developer in our company and not yet very experienced. Thank you all for your time, Michal
> Thank you too Florian. And also big thank to you Andrew. You helped me > a lot to debug the RGMII issue. I have been stuck at that for more than > a month and would not resolve it without your help. We are here to help. I also got stuck figuring out RGMII issues, so i know what it feels like... > As I have done this in a process of upgrading our BSP to a more recent > kernel, and hopefully mainline, I now need to move on to other parts of > the board. Do you think you can mainline the board? It would be nice to have an in kernel board using this switch. If you post the device tree patches, please Cc: me. Andrew