| Message ID | 1526909293-56377-4-git-send-email-michal.vokac@ysoft.com |
|---|---|
| State | Superseded, archived |
| Delegated to: | David Miller |
| Headers | show |
| Series | Add support for QCA8334 switch | expand |
On Mon, May 21, 2018 at 03:28:09PM +0200, Michal Vokáč wrote: > When a port is brought up/down do not enable/disable only the TXMAC > but the RXMAC as well. This is essential for the CPU port to work. > > Signed-off-by: Michal Vokáč <michal.vokac@ysoft.com> Reviewed-by: Andrew Lunn <andrew@lunn.ch> Andrew
On 05/21/2018 06:28 AM, Michal Vokáč wrote: > When a port is brought up/down do not enable/disable only the TXMAC > but the RXMAC as well. This is essential for the CPU port to work. > > Signed-off-by: Michal Vokáč <michal.vokac@ysoft.com> Reviewed-by: Florian Fainelli <f.fainelli@gmail.com> Should this have: Fixes: 6b93fb46480a ("net-next: dsa: add new driver for qca8xxx family")?
On 21.5.2018 17:17, Florian Fainelli wrote: > > On 05/21/2018 06:28 AM, Michal Vokáč wrote: >> When a port is brought up/down do not enable/disable only the TXMAC >> but the RXMAC as well. This is essential for the CPU port to work. >> >> Signed-off-by: Michal Vokáč <michal.vokac@ysoft.com> > > Reviewed-by: Florian Fainelli <f.fainelli@gmail.com> > > Should this have: > > Fixes: 6b93fb46480a ("net-next: dsa: add new driver for qca8xxx family")? Yes, I think it is a good idea to can add this. Will do it in v2. Thanks, Michal
diff --git a/drivers/net/dsa/qca8k.c b/drivers/net/dsa/qca8k.c index 6a3ffb2..0d224f3 100644 --- a/drivers/net/dsa/qca8k.c +++ b/drivers/net/dsa/qca8k.c @@ -516,7 +516,7 @@ qca8k_set_pad_ctrl(struct qca8k_priv *priv, int port, int mode) static void qca8k_port_set_status(struct qca8k_priv *priv, int port, int enable) { - u32 mask = QCA8K_PORT_STATUS_TXMAC; + u32 mask = QCA8K_PORT_STATUS_TXMAC | QCA8K_PORT_STATUS_RXMAC; pr_debug("qca: port %i set status %i\n", port, enable);
When a port is brought up/down do not enable/disable only the TXMAC but the RXMAC as well. This is essential for the CPU port to work. Signed-off-by: Michal Vokáč <michal.vokac@ysoft.com> --- drivers/net/dsa/qca8k.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)