diff mbox series

[net-next,7/7] net: dsa: qca8k: Remove rudundant parentheses

Message ID 1526909293-56377-8-git-send-email-michal.vokac@ysoft.com
State Superseded, archived
Delegated to: David Miller
Headers show
Series Add support for QCA8334 switch | expand

Commit Message

Michal Vokáč May 21, 2018, 1:28 p.m. UTC
Fix warning reported by checkpatch.

Signed-off-by: Michal Vokáč <michal.vokac@ysoft.com>
---
 drivers/net/dsa/qca8k.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Andrew Lunn May 21, 2018, 2:48 p.m. UTC | #1
On Mon, May 21, 2018 at 03:28:13PM +0200, Michal Vokáč wrote:
> Fix warning reported by checkpatch.
> 
> Signed-off-by: Michal Vokáč <michal.vokac@ysoft.com>

Reviewed-by: Andrew Lunn <andrew@lunn.ch>

    Andrew
Florian Fainelli May 21, 2018, 3:21 p.m. UTC | #2
On 05/21/2018 06:28 AM, Michal Vokáč wrote:
> Fix warning reported by checkpatch.

Nit in the subject: should be redundant, with that:

Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
Michal Vokáč May 22, 2018, 5:52 a.m. UTC | #3
On 21.5.2018 17:21, Florian Fainelli wrote:
> 
> On 05/21/2018 06:28 AM, Michal Vokáč wrote:
>> Fix warning reported by checkpatch.
> 
> Nit in the subject: should be redundant, with that:
> 
> Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>

Thanks, I will fix it.

Michal
diff mbox series

Patch

diff --git a/drivers/net/dsa/qca8k.c b/drivers/net/dsa/qca8k.c
index c834893..c0da402 100644
--- a/drivers/net/dsa/qca8k.c
+++ b/drivers/net/dsa/qca8k.c
@@ -513,7 +513,7 @@  qca8k_port_set_status(struct qca8k_priv *priv, int port, int enable)
 	pr_debug("qca: port %i set status %i\n", port, enable);
 
 	/* Port 0 and 6 have no internal PHY */
-	if ((port > 0) && (port < 6))
+	if (port > 0 && port < 6)
 		mask |= QCA8K_PORT_STATUS_LINK_AUTO;
 
 	if (enable)