Message ID | 1525338346-31684-1-git-send-email-shubhrajyoti.datta@gmail.com |
---|---|
State | Changes Requested, archived |
Headers | show |
Series | [1/2] dt-bindings: gpio-xilinx: Update no-init property | expand |
On Thu, May 3, 2018 at 11:05 AM, <shubhrajyoti.datta@gmail.com> wrote: > From: Shubhrajyoti Datta <shubhrajyoti.datta@xilinx.com> > > In some cases the user may not want to initialise the > gpios to default. Add a property to allow the same. This is specially > useful in case the PS is reset and PL is not. > > Signed-off-by: Shubhrajyoti Datta <shubhrajyoti.datta@xilinx.com> (...) > @@ -25,6 +25,7 @@ Optional properties: > - xlnx,dout-default-2 : as above but the second channel > - xlnx,gpio2-width : as above but for the second channel > - xlnx,tri-default-2 : as above but for the second channel > +- xlnx,no-init : No initialisation at probe This doesn't seem very Xilinx-specific? It looks more like something any GPIO driver would want to do. So a no-init-hardware; in gpio.txt seems more appropriate, if this is even needed, see comments on next patch. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Thu, May 3, 2018 at 11:05 AM, <shubhrajyoti.datta@gmail.com> wrote: > From: Shubhrajyoti Datta <shubhrajyoti.datta@xilinx.com> > > Add a dt property to indicate no initialisation at probe. > In some cases the user may want no initialisation of the > gpios. For example PS only reset the user may not want the > re-initialisation of the ip. > > Signed-off-by: Shubhrajyoti Datta <shubhrajyoti.datta@xilinx.com> Usually the recommendation is to leave electronics in the power-on-state until their state is explicitly changed. Is it possible to just make the new "no-init" behaviour the default? Do we even need to keep the initialization code? Michal? Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/Documentation/devicetree/bindings/gpio/gpio-xilinx.txt b/Documentation/devicetree/bindings/gpio/gpio-xilinx.txt index 63bf4be..3a09d9e 100644 --- a/Documentation/devicetree/bindings/gpio/gpio-xilinx.txt +++ b/Documentation/devicetree/bindings/gpio/gpio-xilinx.txt @@ -25,6 +25,7 @@ Optional properties: - xlnx,dout-default-2 : as above but the second channel - xlnx,gpio2-width : as above but for the second channel - xlnx,tri-default-2 : as above but for the second channel +- xlnx,no-init : No initialisation at probe Example: