| Message ID | 20180510231657.28503-7-paul.burton@mips.com |
|---|---|
| State | Changes Requested, archived |
| Delegated to: | David Miller |
| Headers | show |
| Series | net: pch_gbe: MIPS support | expand |
> + ethernet-phy@0 { > + compatible = "ethernet-phy-id001c.c915"; You only need to specify the compatible string like this if the PHY has its own ID wrong. The AT802x gets this right, so you don't need this. Andrew
> eg20t_mac@2,0,1 { > compatible = "pci8086,8802"; > reg = <0x00020100 0 0 0 0>; > - phy-reset-gpios = <&eg20t_gpio 6 > - GPIO_ACTIVE_LOW>; > + > + #address-cells = <1>; > + #size-cells = <0>; It is generally a good idea to put an 'mdio' container which the PHYs are on. You then pass this container node to of_mdiobus_register(). > + > + ethernet-phy@0 { > + compatible = "ethernet-phy-id001c.c915"; > + reg = <0>; > + reset-gpios = <&eg20t_gpio 6 GPIO_ACTIVE_LOW>; > + reset-assert-us = <25000>; > + reset-deassert-us = <25000>; > + }; Andrew
diff --git a/arch/mips/boot/dts/img/boston.dts b/arch/mips/boot/dts/img/boston.dts index 65af3f6ba81c..cb55f7ba20c3 100644 --- a/arch/mips/boot/dts/img/boston.dts +++ b/arch/mips/boot/dts/img/boston.dts @@ -144,8 +144,17 @@ eg20t_mac@2,0,1 { compatible = "pci8086,8802"; reg = <0x00020100 0 0 0 0>; - phy-reset-gpios = <&eg20t_gpio 6 - GPIO_ACTIVE_LOW>; + + #address-cells = <1>; + #size-cells = <0>; + + ethernet-phy@0 { + compatible = "ethernet-phy-id001c.c915"; + reg = <0>; + reset-gpios = <&eg20t_gpio 6 GPIO_ACTIVE_LOW>; + reset-assert-us = <25000>; + reset-deassert-us = <25000>; + }; }; eg20t_gpio: eg20t_gpio@2,0,2 {
The pch_gbe driver support for PHY reset GPIOs is now provided by the standard phylib infrastructure, using a standard PHY binding. Adjust the Boston devicetree to make use of the standard PHY binding. This is possible because we bundle the DT along with the kernel binary into a Flattened Image Tree, so the DT and kernel are always shipped together for the Boston platform. Signed-off-by: Paul Burton <paul.burton@mips.com> Cc: Andrew Lunn <andrew@lunn.ch> Cc: David S. Miller <davem@davemloft.net> Cc: linux-mips@linux-mips.org Cc: netdev@vger.kernel.org --- Changes in v6: - New patch. Changes in v5: None Changes in v4: None Changes in v3: None Changes in v2: None arch/mips/boot/dts/img/boston.dts | 13 +++++++++++-- 1 file changed, 11 insertions(+), 2 deletions(-)